All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "USB: usb_driver_claim_interface: add sanity checking" has been added to the 4.5-stable tree
@ 2016-04-09 23:46 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-04-09 23:46 UTC (permalink / raw)
  To: oneukum, ONeukum, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    USB: usb_driver_claim_interface: add sanity checking

to the 4.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-usb_driver_claim_interface-add-sanity-checking.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 0b818e3956fc1ad976bee791eadcbb3b5fec5bfd Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Wed, 16 Mar 2016 13:26:17 +0100
Subject: USB: usb_driver_claim_interface: add sanity checking

From: Oliver Neukum <oneukum@suse.com>

commit 0b818e3956fc1ad976bee791eadcbb3b5fec5bfd upstream.

Attacks that trick drivers into passing a NULL pointer
to usb_driver_claim_interface() using forged descriptors are
known. This thwarts them by sanity checking.

Signed-off-by: Oliver Neukum <ONeukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/core/driver.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -502,11 +502,15 @@ static int usb_unbind_interface(struct d
 int usb_driver_claim_interface(struct usb_driver *driver,
 				struct usb_interface *iface, void *priv)
 {
-	struct device *dev = &iface->dev;
+	struct device *dev;
 	struct usb_device *udev;
 	int retval = 0;
 	int lpm_disable_error;
 
+	if (!iface)
+		return -ENODEV;
+
+	dev = &iface->dev;
 	if (dev->driver)
 		return -EBUSY;
 


Patches currently in stable-queue which might be from oneukum@suse.com are

queue-4.5/usb-cdc-acm-more-sanity-checking.patch
queue-4.5/usb-mct_u232-add-sanity-checking-in-probe.patch
queue-4.5/usb-digi_acceleport-do-sanity-checking-for-the-number-of-ports.patch
queue-4.5/usb-cypress_m8-add-endpoint-sanity-check.patch
queue-4.5/usb-retry-reset-if-a-device-times-out.patch
queue-4.5/usb-hub-fix-a-typo-in-hub_port_init-leading-to-wrong-logic.patch
queue-4.5/usb-usb_driver_claim_interface-add-sanity-checking.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-09 23:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-09 23:46 Patch "USB: usb_driver_claim_interface: add sanity checking" has been added to the 4.5-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.