* [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
@ 2016-04-29 13:06 ` Helmut Schaa
0 siblings, 0 replies; 6+ messages in thread
From: Helmut Schaa @ 2016-04-29 13:06 UTC (permalink / raw)
To: linux-wireless
Cc: ath9k-devel, kvalo, ath9k-devel, Helmut Schaa, Felix Fietkau
Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
"ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
never evaluate to true.
Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
marcros instead.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Felix Fietkau <nbd@openwrt.org>
---
Just stumbled over that piece of code while looking into TX99, so
this is only compile-tested.
Felix, can you please confirm if this is correct or if removing
the whole block would be better?
Thanks,
Helmut
drivers/net/wireless/ath/ath9k/ar9003_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
index 81ab3ca..ae304355 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
@@ -1010,7 +1010,7 @@ static void ar9003_hw_set_rfmode(struct ath_hw *ah,
if (IS_CHAN_A_FAST_CLOCK(ah, chan))
rfMode |= (AR_PHY_MODE_DYNAMIC | AR_PHY_MODE_DYN_CCK_DISABLE);
- if (rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF))
+ if (IS_CHAN_HALF_RATE(chan) || IS_CHAN_QUARTER_RATE(chan))
REG_RMW_FIELD(ah, AR_PHY_FRAME_CTL,
AR_PHY_FRAME_CTL_CF_OVERLAP_WINDOW, 3);
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [ath9k-devel] [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
@ 2016-04-29 13:06 ` Helmut Schaa
0 siblings, 0 replies; 6+ messages in thread
From: Helmut Schaa @ 2016-04-29 13:06 UTC (permalink / raw)
To: ath9k-devel
Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
"ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
never evaluate to true.
Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
marcros instead.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Felix Fietkau <nbd@openwrt.org>
---
Just stumbled over that piece of code while looking into TX99, so
this is only compile-tested.
Felix, can you please confirm if this is correct or if removing
the whole block would be better?
Thanks,
Helmut
drivers/net/wireless/ath/ath9k/ar9003_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
index 81ab3ca..ae304355 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
@@ -1010,7 +1010,7 @@ static void ar9003_hw_set_rfmode(struct ath_hw *ah,
if (IS_CHAN_A_FAST_CLOCK(ah, chan))
rfMode |= (AR_PHY_MODE_DYNAMIC | AR_PHY_MODE_DYN_CCK_DISABLE);
- if (rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF))
+ if (IS_CHAN_HALF_RATE(chan) || IS_CHAN_QUARTER_RATE(chan))
REG_RMW_FIELD(ah, AR_PHY_FRAME_CTL,
AR_PHY_FRAME_CTL_CF_OVERLAP_WINDOW, 3);
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
2016-04-29 13:06 ` [ath9k-devel] " Helmut Schaa
@ 2016-04-30 3:52 ` Felix Fietkau
-1 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2016-04-30 3:52 UTC (permalink / raw)
To: Helmut Schaa, linux-wireless; +Cc: ath9k-devel, kvalo, ath9k-devel
On 2016-04-29 20:06, Helmut Schaa wrote:
> Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
> "ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
> condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
> never evaluate to true.
>
> Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
> marcros instead.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
> ---
> Just stumbled over that piece of code while looking into TX99, so
> this is only compile-tested.
>
> Felix, can you please confirm if this is correct or if removing
> the whole block would be better?
This patch looks good to me.
Acked-by: Felix Fietkau <nbd@openwrt.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ath9k-devel] [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
@ 2016-04-30 3:52 ` Felix Fietkau
0 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2016-04-30 3:52 UTC (permalink / raw)
To: ath9k-devel
On 2016-04-29 20:06, Helmut Schaa wrote:
> Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
> "ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
> condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
> never evaluate to true.
>
> Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
> marcros instead.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
> ---
> Just stumbled over that piece of code while looking into TX99, so
> this is only compile-tested.
>
> Felix, can you please confirm if this is correct or if removing
> the whole block would be better?
This patch looks good to me.
Acked-by: Felix Fietkau <nbd@openwrt.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
2016-04-29 13:06 ` [ath9k-devel] " Helmut Schaa
@ 2016-05-09 18:13 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2016-05-09 18:13 UTC (permalink / raw)
To: Helmut Schaa; +Cc: linux-wireless, ath9k-devel, ath9k-devel, Felix Fietkau
Helmut Schaa <helmut.schaa@googlemail.com> writes:
> Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
> "ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
> condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
> never evaluate to true.
>
> Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
> marcros instead.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
Thanks, applied to ath.git.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ath9k-devel] [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
@ 2016-05-09 18:13 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2016-05-09 18:13 UTC (permalink / raw)
To: ath9k-devel
Helmut Schaa <helmut.schaa@googlemail.com> writes:
> Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
> "ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
> condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
> never evaluate to true.
>
> Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
> marcros instead.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
Thanks, applied to ath.git.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-09 18:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-29 13:06 [PATCH] ath9k: Fix symbol overlap window for half/quarter channels Helmut Schaa
2016-04-29 13:06 ` [ath9k-devel] " Helmut Schaa
2016-04-30 3:52 ` Felix Fietkau
2016-04-30 3:52 ` [ath9k-devel] " Felix Fietkau
2016-05-09 18:13 ` Kalle Valo
2016-05-09 18:13 ` [ath9k-devel] " Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.