From: Aditya <yashsri421@gmail.com> To: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org Cc: lukas.bulwahn@gmail.com, dwaipayanray1@gmail.com, broonie@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] checkpatch: add warning for avoiding .L prefix symbols in assembly files Date: Wed, 20 Jan 2021 18:23:16 +0530 [thread overview] Message-ID: <14707ab9-1872-4f8c-3ed8-e77b663c3adb@gmail.com> (raw) In-Reply-To: <e5c5f8495fbdd063f4272f02a259bbf28b199bdd.camel@perches.com> On 20/1/21 2:51 pm, Joe Perches wrote: > On Wed, 2021-01-20 at 12:55 +0530, Aditya Srivastava wrote: >> Local symbols prefixed with '.L' do not emit symbol table entries, as >> they have special meaning for the assembler. >> >> '.L' prefixed symbols can be used within a code region, but should be >> avoided for denoting a range of code via 'SYM_*_START/END' annotations. >> >> Add a new check to emit a warning on finding the usage of '.L' symbols >> in '.S' files, if it lies within SYM_*_START/END annotation pair. > > I believe this needs a test for $file as it won't work well on > patches as the SYM_*_START/END may not be in the patch context. > Okay. > Also, is this supposed to work for local labels like '.L<foo>:'? > I don't think a warning should be generated for those. > Yes, currently it will generate warning for all symbols which start with .L and have non- white character symbol following it, if it is lying within SYM_*_START/END annotation pair. Should I reduce the check to \.L_\S+ instead? (please note "_" following ".L") Pardon me, I'm not good with assembly :/ Thanks Aditya
WARNING: multiple messages have this Message-ID (diff)
From: Aditya <yashsri421@gmail.com> To: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org Cc: broonie@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, clang-built-linux@googlegroups.com, dwaipayanray1@gmail.com Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: add warning for avoiding .L prefix symbols in assembly files Date: Wed, 20 Jan 2021 18:23:16 +0530 [thread overview] Message-ID: <14707ab9-1872-4f8c-3ed8-e77b663c3adb@gmail.com> (raw) In-Reply-To: <e5c5f8495fbdd063f4272f02a259bbf28b199bdd.camel@perches.com> On 20/1/21 2:51 pm, Joe Perches wrote: > On Wed, 2021-01-20 at 12:55 +0530, Aditya Srivastava wrote: >> Local symbols prefixed with '.L' do not emit symbol table entries, as >> they have special meaning for the assembler. >> >> '.L' prefixed symbols can be used within a code region, but should be >> avoided for denoting a range of code via 'SYM_*_START/END' annotations. >> >> Add a new check to emit a warning on finding the usage of '.L' symbols >> in '.S' files, if it lies within SYM_*_START/END annotation pair. > > I believe this needs a test for $file as it won't work well on > patches as the SYM_*_START/END may not be in the patch context. > Okay. > Also, is this supposed to work for local labels like '.L<foo>:'? > I don't think a warning should be generated for those. > Yes, currently it will generate warning for all symbols which start with .L and have non- white character symbol following it, if it is lying within SYM_*_START/END annotation pair. Should I reduce the check to \.L_\S+ instead? (please note "_" following ".L") Pardon me, I'm not good with assembly :/ Thanks Aditya _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-01-20 14:47 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-20 7:25 [PATCH] checkpatch: add warning for avoiding .L prefix symbols in assembly files Aditya Srivastava 2021-01-20 7:25 ` [Linux-kernel-mentees] " Aditya Srivastava 2021-01-20 9:21 ` Joe Perches 2021-01-20 9:21 ` [Linux-kernel-mentees] " Joe Perches 2021-01-20 12:53 ` Aditya [this message] 2021-01-20 12:53 ` Aditya 2021-01-20 18:43 ` Joe Perches 2021-01-20 18:43 ` [Linux-kernel-mentees] " Joe Perches 2021-01-20 18:57 ` Nick Desaulniers 2021-01-20 18:57 ` [Linux-kernel-mentees] " Nick Desaulniers via Linux-kernel-mentees 2021-01-20 22:59 ` Josh Poimboeuf 2021-01-20 22:59 ` [Linux-kernel-mentees] " Josh Poimboeuf 2021-01-22 13:18 ` Aditya 2021-01-22 13:18 ` [Linux-kernel-mentees] " Aditya 2021-01-22 19:10 ` Joe Perches 2021-01-22 19:10 ` [Linux-kernel-mentees] " Joe Perches 2021-01-22 20:13 ` Aditya 2021-01-22 20:13 ` [Linux-kernel-mentees] " Aditya 2021-01-22 20:36 ` Fāng-ruì Sòng 2021-01-22 20:36 ` [Linux-kernel-mentees] " Fāng-ruì Sòng via Linux-kernel-mentees 2021-01-23 15:14 ` [PATCH v2] " Aditya Srivastava 2021-01-23 15:14 ` [Linux-kernel-mentees] " Aditya Srivastava 2021-01-23 17:21 ` Joe Perches 2021-01-23 17:21 ` [Linux-kernel-mentees] " Joe Perches 2021-01-23 18:23 ` Aditya 2021-01-23 18:23 ` [Linux-kernel-mentees] " Aditya 2021-01-23 19:04 ` [PATCH v3] " Aditya Srivastava 2021-01-23 19:04 ` [Linux-kernel-mentees] " Aditya Srivastava 2021-01-23 21:01 ` Joe Perches 2021-01-23 21:01 ` [Linux-kernel-mentees] " Joe Perches 2021-01-25 18:15 ` Nick Desaulniers 2021-01-25 18:15 ` [Linux-kernel-mentees] " Nick Desaulniers via Linux-kernel-mentees
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=14707ab9-1872-4f8c-3ed8-e77b663c3adb@gmail.com \ --to=yashsri421@gmail.com \ --cc=broonie@kernel.org \ --cc=clang-built-linux@googlegroups.com \ --cc=dwaipayanray1@gmail.com \ --cc=joe@perches.com \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas.bulwahn@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.