All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xie Ziyao <xieziyao@huawei.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] typo: Add necessary spaces in the outputs
Date: Wed, 16 Jun 2021 20:07:41 +0800	[thread overview]
Message-ID: <147203f7-eccc-09fb-4dd5-7083881fe84b@huawei.com> (raw)
In-Reply-To: <YMniMEyDjhCLcx8g@pevik>

Hi, Petr,

> 
>> Ping. I checked it based on the latest code. Are there any changes that need
>> to be added?
> Well, as I note previously on some places it'd be better to join string, e.g.
> testcases/kernel/syscalls/setsid/setsid01.c
> testcases/open_posix_testsuite/conformance/interfaces/sched_setparam/2-1.c
> testcases/kernel/syscalls/sysinfo/sysinfo02.c
> 
> The reason is that string on single line is easier to grep.
> That's why checkpatch.pl from kernel relaxed max line from 80 to 100
> (good at least for string).
> 
> But I'm ok to merge it without.
> 
Thanks, by the way, would you mind fixing this while you merge?

It's also fine that I send v2 patch later to fix the problem.

Thanks for your review.

Kind Regards,
Ziyao

  parent reply	other threads:[~2021-06-16 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:45 [LTP] [PATCH] typo: Add necessary spaces in the outputs Xie Ziyao
2021-05-18  9:27 ` Li Wang
2021-05-20  5:03   ` Petr Vorel
2021-06-16 11:11     ` Xie Ziyao
2021-06-16 11:36       ` Petr Vorel
2021-06-16 11:38         ` Petr Vorel
2021-06-16 12:07         ` Xie Ziyao [this message]
2021-06-16 13:22           ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=147203f7-eccc-09fb-4dd5-7083881fe84b@huawei.com \
    --to=xieziyao@huawei.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.