All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] typo: Add necessary spaces in the outputs
Date: Thu, 20 May 2021 07:03:57 +0200	[thread overview]
Message-ID: <YKXtvaeckoJ2HJzJ@pevik> (raw)
In-Reply-To: <CAEemH2en6C3dUzspuVwNVmRiUeBQWK38bLPT7+ZwErVFQG+i-w@mail.gmail.com>

Hi,

> On Tue, May 18, 2021 at 2:45 PM Xie Ziyao <xieziyao@huawei.com> wrote:

> > Add necessary spaces in the outputs.

> > Signed-off-by: Xie Ziyao <xieziyao@huawei.com>

> Reviewed-by: Li Wang <liwang@redhat.com>

Actually, for some of these it'd be good to join the string:

e.g.: testcases/kernel/fs/fsx-linux/fsx-linux.c
warn("save_buffer: short write, 0x%x bytes instead "
 			     "of 0x%llx\n",

The rule could be: anything <= 100 (instead of 80 which was common in the past).
This is related to the change in checkpatch.pl (kernel) a year ago
bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")

Feel free to ignore it.

Kind regards,
Petr

  reply	other threads:[~2021-05-20  5:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:45 [LTP] [PATCH] typo: Add necessary spaces in the outputs Xie Ziyao
2021-05-18  9:27 ` Li Wang
2021-05-20  5:03   ` Petr Vorel [this message]
2021-06-16 11:11     ` Xie Ziyao
2021-06-16 11:36       ` Petr Vorel
2021-06-16 11:38         ` Petr Vorel
2021-06-16 12:07         ` Xie Ziyao
2021-06-16 13:22           ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKXtvaeckoJ2HJzJ@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.