From: Krzysztof Kozlowski <krzk@kernel.org> To: Tomasz Figa <tomasz.figa@gmail.com>, Krzysztof Kozlowski <krzk@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim <kgene@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de>, javier@osg.samsung.com, Linus Walleij <linus.walleij@linaro.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com> Subject: [PATCH v3 16/17] ARM: dts: s3c2416: Use macros for pinctrl configuration Date: Sun, 4 Sep 2016 13:04:19 +0200 [thread overview] Message-ID: <1472987060-28293-17-git-send-email-krzk@kernel.org> (raw) In-Reply-To: <1472987060-28293-1-git-send-email-krzk@kernel.org> From: Krzysztof Kozlowski <k.kozlowski@samsung.com> Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 ++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi index 527e3193817f..6274359fb323 100644 --- a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi +++ b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi @@ -8,6 +8,8 @@ * published by the Free Software Foundation. */ +#include <dt-bindings/pinctrl/samsung.h> + &pinctrl_0 { /* * Pin banks @@ -83,91 +85,91 @@ uart0_data: uart0-data { samsung,pins = "gph-0", "gph-1"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart0_fctl: uart0-fctl { samsung,pins = "gph-8", "gph-9"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart1_data: uart1-data { samsung,pins = "gph-2", "gph-3"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart1_fctl: uart1-fctl { samsung,pins = "gph-10", "gph-11"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart2_data: uart2-data { samsung,pins = "gph-4", "gph-5"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart2_fctl: uart2-fctl { samsung,pins = "gph-6", "gph-7"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart3_data: uart3-data { samsung,pins = "gph-6", "gph-7"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; extuart_clk: extuart-clk { samsung,pins = "gph-12"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; i2c0_bus: i2c0-bus { samsung,pins = "gpe-14", "gpe-15"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; spi0_bus: spi0-bus { samsung,pins = "gpe-11", "gpe-12", "gpe-13"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_clk: sd0-clk { samsung,pins = "gpe-5"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_cmd: sd0-cmd { samsung,pins = "gpe-6"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_bus1: sd0-bus1 { samsung,pins = "gpe-7"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_bus4: sd0-bus4 { samsung,pins = "gpe-8", "gpe-9", "gpe-10"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_cmd: sd1-cmd { samsung,pins = "gpl-8"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_clk: sd1-clk { samsung,pins = "gpl-9"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_bus1: sd1-bus1 { samsung,pins = "gpl-0"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_bus4: sd1-bus4 { samsung,pins = "gpl-1", "gpl-2", "gpl-3"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; }; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 16/17] ARM: dts: s3c2416: Use macros for pinctrl configuration Date: Sun, 4 Sep 2016 13:04:19 +0200 [thread overview] Message-ID: <1472987060-28293-17-git-send-email-krzk@kernel.org> (raw) In-Reply-To: <1472987060-28293-1-git-send-email-krzk@kernel.org> From: Krzysztof Kozlowski <k.kozlowski@samsung.com> Usage of DTS macros instead of hard-coded numbers makes code easier to read. One does not have to remember which value means pull-up/down or specific driver strength. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 ++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi index 527e3193817f..6274359fb323 100644 --- a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi +++ b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi @@ -8,6 +8,8 @@ * published by the Free Software Foundation. */ +#include <dt-bindings/pinctrl/samsung.h> + &pinctrl_0 { /* * Pin banks @@ -83,91 +85,91 @@ uart0_data: uart0-data { samsung,pins = "gph-0", "gph-1"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart0_fctl: uart0-fctl { samsung,pins = "gph-8", "gph-9"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart1_data: uart1-data { samsung,pins = "gph-2", "gph-3"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart1_fctl: uart1-fctl { samsung,pins = "gph-10", "gph-11"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart2_data: uart2-data { samsung,pins = "gph-4", "gph-5"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart2_fctl: uart2-fctl { samsung,pins = "gph-6", "gph-7"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; uart3_data: uart3-data { samsung,pins = "gph-6", "gph-7"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; extuart_clk: extuart-clk { samsung,pins = "gph-12"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; i2c0_bus: i2c0-bus { samsung,pins = "gpe-14", "gpe-15"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; spi0_bus: spi0-bus { samsung,pins = "gpe-11", "gpe-12", "gpe-13"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_clk: sd0-clk { samsung,pins = "gpe-5"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_cmd: sd0-cmd { samsung,pins = "gpe-6"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_bus1: sd0-bus1 { samsung,pins = "gpe-7"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd0_bus4: sd0-bus4 { samsung,pins = "gpe-8", "gpe-9", "gpe-10"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_cmd: sd1-cmd { samsung,pins = "gpl-8"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_clk: sd1-clk { samsung,pins = "gpl-9"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_bus1: sd1-bus1 { samsung,pins = "gpl-0"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; sd1_bus4: sd1-bus4 { samsung,pins = "gpl-1", "gpl-2", "gpl-3"; - samsung,pin-function = <2>; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; }; }; -- 2.7.4
next prev parent reply other threads:[~2016-09-04 11:06 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-04 11:04 [PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 01/17] pinctrl: dt-bindings: samsung: " Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-07 21:18 ` Linus Walleij 2016-09-07 21:18 ` Linus Walleij 2016-09-07 21:18 ` Linus Walleij [not found] ` <CGME20160916075624eucas1p23a12de912f92f0c557f17fbd394b186e@eucas1p2.samsung.com> 2016-09-16 7:56 ` Krzysztof Kozlowski 2016-09-16 7:56 ` Krzysztof Kozlowski 2016-09-16 7:56 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 02/17] pinctrl: dt-bindings: samsung: Update documentation with new macros Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-07 21:19 ` Linus Walleij 2016-09-07 21:19 ` Linus Walleij 2016-09-07 21:19 ` Linus Walleij 2016-09-12 16:10 ` Rob Herring 2016-09-12 16:10 ` Rob Herring 2016-09-12 16:10 ` Rob Herring 2016-09-04 11:04 ` [PATCH v3 03/17] ARM: dts: exynos: Use common macros for pinctrl configuration Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 04/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos3250 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 05/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4210 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 06/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4x12 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 07/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4415 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 08/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5250 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 09/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5260 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 10/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5410 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 11/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos542x/exynos5800 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 12/17] ARM: dts: exynos: Fix mismatched value for SD4 pull up/down configuration on exynos4210 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 13/17] ARM: dts: exynos: Fix mismatched values of SD drive strengh configuration on exynos4415 Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 14/17] ARM: dts: s3c64xx: Use common macros for pinctrl configuration Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 15/17] ARM: dts: s5pv210: Use " Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski [this message] 2016-09-04 11:04 ` [PATCH v3 16/17] ARM: dts: s3c2416: " Krzysztof Kozlowski 2016-09-04 11:04 ` [PATCH v3 17/17] ARM: dts: s3c64xx: " Krzysztof Kozlowski 2016-09-04 11:04 ` Krzysztof Kozlowski 2016-10-09 7:04 ` [PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration Tomasz Figa 2016-10-09 7:04 ` Tomasz Figa 2016-10-09 7:04 ` Tomasz Figa 2016-10-09 16:39 ` Krzysztof Kozlowski 2016-10-09 16:39 ` Krzysztof Kozlowski 2016-10-09 16:39 ` Krzysztof Kozlowski 2016-10-09 17:49 ` Tomasz Figa 2016-10-09 17:49 ` Tomasz Figa 2016-10-09 17:49 ` Tomasz Figa 2016-10-09 17:52 ` Krzysztof Kozlowski 2016-10-09 17:52 ` Krzysztof Kozlowski 2016-10-09 17:52 ` Krzysztof Kozlowski 2016-10-21 9:02 ` Linus Walleij 2016-10-21 9:02 ` Linus Walleij 2016-10-21 9:02 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1472987060-28293-17-git-send-email-krzk@kernel.org \ --to=krzk@kernel.org \ --cc=arnd@arndb.de \ --cc=b.zolnierkie@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=javier@osg.samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.