All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "shawnguo@kernel.org" <shawnguo@kernel.org>,
	"maitysanchayan@gmail.com" <maitysanchayan@gmail.com>
Cc: "stefan@agner.ch" <stefan@agner.ch>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight
Date: Fri, 16 Sep 2016 13:38:54 +0000	[thread overview]
Message-ID: <1474033134.3103.27.camel@toradex.com> (raw)
In-Reply-To: <dff8d58c4021719184af2c83773e86f175ad910e.1473833908.git.maitysanchayan@gmail.com>

On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> Use enable-gpios property of PWM backlight driver for backlight
> control. While at it also fix the use of brightness levels required
> by EDT displays which require inverted PWM's.

That part I am missing below. Did you forget to include it?

> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 8c67dd8..9100bde 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -49,7 +49,10 @@
>  
>  	backlight: backlight {
>  		compatible = "pwm-backlight";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_bl_on>;
>  		pwms = <&pwm4 0 5000000>;
> +		enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
>  		status = "disabled";
>  	};
>  
> @@ -614,6 +617,12 @@
>  		>;
>  	};
>  
> +	pinctrl_gpio_bl_on: gpioblon {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> +		>;
> +	};
> +
>  	pinctrl_gpio_keys: gpio1io04grp {
>  		fsl,pins = <
>  			/* Power button */

WARNING: multiple messages have this Message-ID (diff)
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "shawnguo@kernel.org" <shawnguo@kernel.org>,
	"maitysanchayan@gmail.com" <maitysanchayan@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"stefan@agner.ch" <stefan@agner.ch>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight
Date: Fri, 16 Sep 2016 13:38:54 +0000	[thread overview]
Message-ID: <1474033134.3103.27.camel@toradex.com> (raw)
In-Reply-To: <dff8d58c4021719184af2c83773e86f175ad910e.1473833908.git.maitysanchayan@gmail.com>

On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> Use enable-gpios property of PWM backlight driver for backlight
> control. While at it also fix the use of brightness levels required
> by EDT displays which require inverted PWM's.

That part I am missing below. Did you forget to include it?

> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 8c67dd8..9100bde 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -49,7 +49,10 @@
>  
>  	backlight: backlight {
>  		compatible = "pwm-backlight";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_bl_on>;
>  		pwms = <&pwm4 0 5000000>;
> +		enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
>  		status = "disabled";
>  	};
>  
> @@ -614,6 +617,12 @@
>  		>;
>  	};
>  
> +	pinctrl_gpio_bl_on: gpioblon {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> +		>;
> +	};
> +
>  	pinctrl_gpio_keys: gpio1io04grp {
>  		fsl,pins = <
>  			/* Power button */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: marcel.ziswiler@toradex.com (Marcel Ziswiler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight
Date: Fri, 16 Sep 2016 13:38:54 +0000	[thread overview]
Message-ID: <1474033134.3103.27.camel@toradex.com> (raw)
In-Reply-To: <dff8d58c4021719184af2c83773e86f175ad910e.1473833908.git.maitysanchayan@gmail.com>

On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> Use enable-gpios property of PWM backlight driver for backlight
> control. While at it also fix the use of brightness levels required
> by EDT displays which require inverted PWM's.

That part I am missing below. Did you forget to include it?

> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> ?arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> ?1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 8c67dd8..9100bde 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -49,7 +49,10 @@
> ?
> ?	backlight: backlight {
> ?		compatible = "pwm-backlight";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_bl_on>;
> ?		pwms = <&pwm4 0 5000000>;
> +		enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> ?		status = "disabled";
> ?	};
> ?
> @@ -614,6 +617,12 @@
> ?		>;
> ?	};
> ?
> +	pinctrl_gpio_bl_on: gpioblon {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> +		>;
> +	};
> +
> ?	pinctrl_gpio_keys: gpio1io04grp {
> ?		fsl,pins = <
> ?			/* Power button */

  reply	other threads:[~2016-09-16 17:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14  6:35 [PATCH v1 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Sanchayan Maity
2016-09-14  6:35 ` Sanchayan Maity
2016-09-14  6:35 ` Sanchayan Maity
2016-09-14  6:35 ` [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds Sanchayan Maity
2016-09-14  6:35   ` Sanchayan Maity
2016-09-14 15:58   ` Stefan Agner
2016-09-14 15:58     ` Stefan Agner
2016-09-14 15:58     ` Stefan Agner
2016-09-14 18:28     ` Marcel Ziswiler
2016-09-14 18:28       ` Marcel Ziswiler
2016-09-14 18:28       ` Marcel Ziswiler
2016-09-16 13:38   ` Marcel Ziswiler
2016-09-16 13:38     ` Marcel Ziswiler
2016-09-16 13:38     ` Marcel Ziswiler
2016-09-14  6:35 ` [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Sanchayan Maity
2016-09-14  6:35   ` Sanchayan Maity
2016-09-16 13:38   ` Marcel Ziswiler [this message]
2016-09-16 13:38     ` Marcel Ziswiler
2016-09-16 13:38     ` Marcel Ziswiler
2016-09-17  4:45     ` maitysanchayan
2016-09-17  4:45       ` maitysanchayan at gmail.com
2016-09-17  4:45       ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w
2016-09-16 13:38 ` [PATCH v1 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Marcel Ziswiler
2016-09-16 13:38   ` Marcel Ziswiler
2016-09-16 13:38   ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474033134.3103.27.camel@toradex.com \
    --to=marcel.ziswiler@toradex.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.