All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: Lyude <cpaul@redhat.com>, intel-gfx@lists.freedesktop.org
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"David Airlie" <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] drm/i915/gen9: Don't wrap strings in verify_wm_state()
Date: Thu, 13 Oct 2016 18:18:38 -0300	[thread overview]
Message-ID: <1476393518.2478.50.camel@intel.com> (raw)
In-Reply-To: <1475885497-6094-11-git-send-email-cpaul@redhat.com>

Em Sex, 2016-10-07 às 20:11 -0400, Lyude escreveu:

Bikesheding: it would be nice to write a commit message explaining why,
even if the message just tells the user to read
Documentation/CodingStyle.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> Signed-off-by: Lyude <cpaul@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 2c682bc..6191baf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13498,8 +13498,7 @@ static void verify_wm_state(struct drm_crtc
> *crtc,
>  		sw_ddb_entry = &sw_ddb->plane[pipe][plane];
>  
>  		if (!skl_ddb_entry_equal(hw_ddb_entry,
> sw_ddb_entry)) {
> -			DRM_ERROR("mismatch in DDB state pipe %c
> plane %d "
> -				  "(expected (%u,%u), found
> (%u,%u))\n",
> +			DRM_ERROR("mismatch in DDB state pipe %c
> plane %d (expected (%u,%u), found (%u,%u))\n",
>  				  pipe_name(pipe), plane + 1,
>  				  sw_ddb_entry->start, sw_ddb_entry-
> >end,
>  				  hw_ddb_entry->start, hw_ddb_entry-
> >end);
> @@ -13549,8 +13548,7 @@ static void verify_wm_state(struct drm_crtc
> *crtc,
>  		sw_ddb_entry = &sw_ddb->plane[pipe][PLANE_CURSOR];
>  
>  		if (!skl_ddb_entry_equal(hw_ddb_entry,
> sw_ddb_entry)) {
> -			DRM_ERROR("mismatch in DDB state pipe %c
> cursor "
> -				  "(expected (%u,%u), found
> (%u,%u))\n",
> +			DRM_ERROR("mismatch in DDB state pipe %c
> cursor (expected (%u,%u), found (%u,%u))\n",
>  				  pipe_name(pipe),
>  				  sw_ddb_entry->start, sw_ddb_entry-
> >end,
>  				  hw_ddb_entry->start, hw_ddb_entry-
> >end);

WARNING: multiple messages have this Message-ID (diff)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: Lyude <cpaul@redhat.com>, intel-gfx@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 10/10] drm/i915/gen9: Don't wrap strings in verify_wm_state()
Date: Thu, 13 Oct 2016 18:18:38 -0300	[thread overview]
Message-ID: <1476393518.2478.50.camel@intel.com> (raw)
In-Reply-To: <1475885497-6094-11-git-send-email-cpaul@redhat.com>

Em Sex, 2016-10-07 às 20:11 -0400, Lyude escreveu:

Bikesheding: it would be nice to write a commit message explaining why,
even if the message just tells the user to read
Documentation/CodingStyle.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> Signed-off-by: Lyude <cpaul@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 2c682bc..6191baf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13498,8 +13498,7 @@ static void verify_wm_state(struct drm_crtc
> *crtc,
>  		sw_ddb_entry = &sw_ddb->plane[pipe][plane];
>  
>  		if (!skl_ddb_entry_equal(hw_ddb_entry,
> sw_ddb_entry)) {
> -			DRM_ERROR("mismatch in DDB state pipe %c
> plane %d "
> -				  "(expected (%u,%u), found
> (%u,%u))\n",
> +			DRM_ERROR("mismatch in DDB state pipe %c
> plane %d (expected (%u,%u), found (%u,%u))\n",
>  				  pipe_name(pipe), plane + 1,
>  				  sw_ddb_entry->start, sw_ddb_entry-
> >end,
>  				  hw_ddb_entry->start, hw_ddb_entry-
> >end);
> @@ -13549,8 +13548,7 @@ static void verify_wm_state(struct drm_crtc
> *crtc,
>  		sw_ddb_entry = &sw_ddb->plane[pipe][PLANE_CURSOR];
>  
>  		if (!skl_ddb_entry_equal(hw_ddb_entry,
> sw_ddb_entry)) {
> -			DRM_ERROR("mismatch in DDB state pipe %c
> cursor "
> -				  "(expected (%u,%u), found
> (%u,%u))\n",
> +			DRM_ERROR("mismatch in DDB state pipe %c
> cursor (expected (%u,%u), found (%u,%u))\n",
>  				  pipe_name(pipe),
>  				  sw_ddb_entry->start, sw_ddb_entry-
> >end,
>  				  hw_ddb_entry->start, hw_ddb_entry-
> >end);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-13 21:22 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-08  0:11 [PATCH v2 00/10] Start of skl watermark cleanup Lyude
2016-10-08  0:11 ` Lyude
2016-10-08  0:11 ` [PATCH v2 01/10] drm/i915/skl: Move per-pipe ddb allocations into crtc states Lyude
2016-10-08  0:11   ` Lyude
2016-10-11 19:36   ` [Intel-gfx] " Paulo Zanoni
2016-10-11 19:36     ` Paulo Zanoni
2016-10-08  0:11 ` [PATCH v2 02/10] drm/i915/skl: Remove linetime from skl_wm_values Lyude
2016-10-08  0:11   ` Lyude
2016-10-08  0:11 ` [PATCH v2 03/10] drm/i915/gen9: Make skl_wm_level per-plane Lyude
2016-10-08  0:11   ` Lyude
2016-10-11 19:36   ` Paulo Zanoni
2016-10-11 19:36     ` Paulo Zanoni
2016-10-08  0:11 ` [PATCH 04/10] drm/i915/gen9: Cleanup skl_pipe_wm_active_state Lyude
2016-10-11 19:40   ` [Intel-gfx] " Paulo Zanoni
2016-10-11 19:40     ` Paulo Zanoni
2016-10-08  0:11 ` [PATCH v2 05/10] drm/i915/gen9: Get rid of redundant watermark values Lyude
2016-10-08  0:11   ` Lyude
2016-10-13 13:39   ` [Intel-gfx] " Maarten Lankhorst
2016-10-13 20:04     ` Paulo Zanoni
2016-10-13 20:04       ` Paulo Zanoni
2016-10-13 20:07       ` [Intel-gfx] " Paulo Zanoni
2016-10-13 20:07         ` Paulo Zanoni
2016-10-13 21:25         ` [Intel-gfx] " Lyude Paul
2016-10-13 21:25           ` Lyude Paul
2016-10-17  6:05       ` Daniel Vetter
2016-10-17  6:05         ` Daniel Vetter
2016-10-17  8:07         ` [Intel-gfx] " Maarten Lankhorst
2016-10-17  8:07           ` Maarten Lankhorst
2016-10-08  0:11 ` [PATCH v2 06/10] drm/i915/gen9: Add ddb changes to atomic debug output Lyude
2016-10-08  0:11   ` Lyude
2016-10-13 20:17   ` Paulo Zanoni
2016-10-13 20:17     ` Paulo Zanoni
2016-10-08  0:11 ` [PATCH 07/10] drm/i915/gen9: Make skl_pipe_wm_get_hw_state() reusable Lyude
2016-10-08  0:11   ` Lyude
2016-10-13 20:36   ` Paulo Zanoni
2016-10-13 20:36     ` Paulo Zanoni
2016-10-08  0:11 ` [PATCH 08/10] drm/i915/gen9: Add skl_wm_level_equals() Lyude
2016-10-08  0:11   ` Lyude
2016-10-13 20:40   ` Paulo Zanoni
2016-10-13 20:40     ` Paulo Zanoni
2016-10-08  0:11 ` [PATCH 09/10] drm/i915/gen9: Actually verify WM levels in verify_wm_state() Lyude
2016-10-08  0:11   ` Lyude
2016-10-13 21:15   ` Paulo Zanoni
2016-10-13 21:15     ` Paulo Zanoni
2016-10-13 21:20     ` [Intel-gfx] " Paulo Zanoni
2016-10-13 21:20       ` Paulo Zanoni
2016-10-08  0:11 ` [PATCH 10/10] drm/i915/gen9: Don't wrap strings " Lyude
2016-10-08  0:11   ` Lyude
2016-10-13 21:18   ` Paulo Zanoni [this message]
2016-10-13 21:18     ` Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476393518.2478.50.camel@intel.com \
    --to=paulo.r.zanoni@intel.com \
    --cc=airlied@linux.ie \
    --cc=cpaul@redhat.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.