* [PATCH] Staging: speakup: synth: Fix checkpatch warning
@ 2017-02-23 15:35 Man Choy
0 siblings, 0 replies; 4+ messages in thread
From: Man Choy @ 2017-02-23 15:35 UTC (permalink / raw)
To: gregkh
Cc: Man Choy, William Hubbs, Chris Brannon, Kirk Reiser,
Samuel Thibault, Walt Feasel, Katie Dunne, Amitoj Kaur Chawla,
Colin Ian King, speakup, devel, linux-kernel
Fix following warning:
WARNING: line over 80 characters
+ &synth->attributes) < 0)
Signed-off-by: Man Choy <manchoyy@gmail.com>
---
drivers/staging/speakup/synth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index a61c02b..968d8b6 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -406,8 +406,8 @@ static int do_synth_init(struct spk_synth *in_synth)
speakup_register_var(var);
if (!spk_quiet_boot)
synth_printf("%s found\n", synth->long_name);
- if (synth->attributes.name && sysfs_create_group(speakup_kobj,
- &synth->attributes) < 0)
+ if (synth->attributes.name &&
+ sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
return -ENOMEM;
synth_flags = synth->flags;
wake_up_interruptible_all(&speakup_event);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: speakup: synth: Fix checkpatch warning
2017-02-23 13:34 ` Joe Perches
@ 2017-02-23 14:28 ` Man Choy
0 siblings, 0 replies; 4+ messages in thread
From: Man Choy @ 2017-02-23 14:28 UTC (permalink / raw)
To: Joe Perches
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, Walt Feasel, Amitoj Kaur Chawla,
Colin Ian King, Katie Dunne, speakup, devel, linux-kernel
On Thu, Feb 23, 2017 at 9:34 PM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
> []
>> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> []
>> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
>> if (!spk_quiet_boot)
>> synth_printf("%s found\n", synth->long_name);
>> if (synth->attributes.name && sysfs_create_group(speakup_kobj,
>> - &synth->attributes) < 0)
>> + &synth->attributes) < 0)
>
> Better would be
>
> if (synth->attributes.name &&
> sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
>
Thanks for pointing out. Fixed and sent off PATCH v2.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: speakup: synth: Fix checkpatch warning
2017-02-23 13:15 [PATCH] staging: " Man Choy
@ 2017-02-23 13:34 ` Joe Perches
2017-02-23 14:28 ` Man Choy
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2017-02-23 13:34 UTC (permalink / raw)
To: Man Choy
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, Walt Feasel, Amitoj Kaur Chawla,
Colin Ian King, Katie Dunne, speakup, devel, linux-kernel
On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
[]
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
[]
> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
> if (!spk_quiet_boot)
> synth_printf("%s found\n", synth->long_name);
> if (synth->attributes.name && sysfs_create_group(speakup_kobj,
> - &synth->attributes) < 0)
> + &synth->attributes) < 0)
Better would be
if (synth->attributes.name &&
sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: speakup: synth: Fix checkpatch warning
@ 2017-02-23 13:15 Man Choy
2017-02-23 13:34 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Man Choy @ 2017-02-23 13:15 UTC (permalink / raw)
To: manchoyy
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, Walt Feasel, Amitoj Kaur Chawla,
Colin Ian King, Katie Dunne, speakup, devel, linux-kernel
Signed-off-by: Man Choy <manchoyy@gmail.com>
---
drivers/staging/speakup/synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index a61c02b..1cd38e7 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
if (!spk_quiet_boot)
synth_printf("%s found\n", synth->long_name);
if (synth->attributes.name && sysfs_create_group(speakup_kobj,
- &synth->attributes) < 0)
+ &synth->attributes) < 0)
return -ENOMEM;
synth_flags = synth->flags;
wake_up_interruptible_all(&speakup_event);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-23 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-23 15:35 [PATCH] Staging: speakup: synth: Fix checkpatch warning Man Choy
-- strict thread matches above, loose matches on Subject: below --
2017-02-23 13:15 [PATCH] staging: " Man Choy
2017-02-23 13:34 ` Joe Perches
2017-02-23 14:28 ` Man Choy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.