Patch "USB: serial: safe_serial: fix information leak in completion handler" has been added to the 4.10-stable tree

Patch "USB: serial: safe_serial: fix information leak in completion handler" has been added to the 4.10-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    USB: serial: safe_serial: fix information leak in completion handler

to the 4.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 8c76d7cd520ebffc1ea9ea0850d87a224a50c7f2 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 6 Mar 2017 17:36:41 +0100
Subject: USB: serial: safe_serial: fix information leak in completion handler

From: Johan Hovold <johan@kernel.org>

commit 8c76d7cd520ebffc1ea9ea0850d87a224a50c7f2 upstream.

Add missing sanity check to the bulk-in completion handler to avoid an
integer underflow that could be triggered by a malicious device.

This avoids leaking up to 56 bytes from after the URB transfer buffer to
user space.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/serial/safe_serial.c |    5 +++++
 1 file changed, 5 insertions(+)

--- a/drivers/usb/serial/safe_serial.c
+++ b/drivers/usb/serial/safe_serial.c
@@ -200,6 +200,11 @@ static void safe_process_read_urb(struct
 	if (!safe)
 		goto out;
 
+	if (length < 2) {
+		dev_err(&port->dev, "malformed packet\n");
+		return;
+	}
+
 	fcs = fcs_compute10(data, length, CRC10_INITFCS);
 	if (fcs) {
 		dev_err(&port->dev, "%s - bad CRC %x\n", __func__, fcs);


Patches currently in stable-queue which might be from johan@kernel.org are

queue-4.10/usb-serial-digi_acceleport-fix-oob-event-processing.patch
queue-4.10/usb-serial-omninet-fix-reference-leaks-at-open.patch
queue-4.10/usb-serial-digi_acceleport-fix-oob-data-sanity-check.patch
queue-4.10/usb-iowarrior-fix-null-deref-in-write.patch
queue-4.10/usb-iowarrior-fix-null-deref-at-probe.patch
queue-4.10/usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch
queue-4.10/usb-serial-io_ti-fix-information-leak-in-completion-handler.patch
queue-4.10/usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch