Patch "USB: serial: io_ti: fix NULL-deref in interrupt callback" has been added to the 4.4-stable tree

Patch "USB: serial: io_ti: fix NULL-deref in interrupt callback" has been added to the 4.4-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    USB: serial: io_ti: fix NULL-deref in interrupt callback

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 0b1d250afb8eb9d65afb568bac9b9f9253a82b49 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 6 Mar 2017 17:36:37 +0100
Subject: USB: serial: io_ti: fix NULL-deref in interrupt callback

From: Johan Hovold <johan@kernel.org>

commit 0b1d250afb8eb9d65afb568bac9b9f9253a82b49 upstream.

Fix a NULL-pointer dereference in the interrupt callback should a
malicious device send data containing a bad port number by adding the
missing sanity check.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/serial/io_ti.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -1674,6 +1674,12 @@ static void edge_interrupt_callback(stru
 	function    = TIUMP_GET_FUNC_FROM_CODE(data[0]);
 	dev_dbg(dev, "%s - port_number %d, function %d, info 0x%x\n", __func__,
 		port_number, function, data[1]);
+
+	if (port_number >= edge_serial->serial->num_ports) {
+		dev_err(dev, "bad port number %d\n", port_number);
+		goto exit;
+	}
+
 	port = edge_serial->serial->port[port_number];
 	edge_port = usb_get_serial_port_data(port);
 	if (!edge_port) {


Patches currently in stable-queue which might be from johan@kernel.org are

queue-4.4/usb-serial-digi_acceleport-fix-oob-event-processing.patch
queue-4.4/usb-serial-omninet-fix-reference-leaks-at-open.patch
queue-4.4/usb-serial-digi_acceleport-fix-oob-data-sanity-check.patch
queue-4.4/usb-iowarrior-fix-null-deref-in-write.patch
queue-4.4/usb-iowarrior-fix-null-deref-at-probe.patch
queue-4.4/usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch
queue-4.4/usb-serial-io_ti-fix-information-leak-in-completion-handler.patch
queue-4.4/usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch