From: "Jérôme Glisse" <jglisse@redhat.com> To: akpm@linux-foundation.org, <linux-kernel@vger.kernel.org>, linux-mm@kvack.org Cc: "John Hubbard" <jhubbard@nvidia.com>, "Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>, "David Nellans" <dnellans@nvidia.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Evgeny Baskakov" <ebaskakov@nvidia.com>, "Mark Hairgrove" <mhairgrove@nvidia.com>, "Sherry Cheung" <SCheung@nvidia.com>, "Subhash Gutti" <sgutti@nvidia.com> Subject: [HMM 16/16] mm/hmm/devmem: dummy HMM device for ZONE_DEVICE memory v2 Date: Thu, 16 Mar 2017 12:05:35 -0400 [thread overview] Message-ID: <1489680335-6594-17-git-send-email-jglisse@redhat.com> (raw) In-Reply-To: <1489680335-6594-1-git-send-email-jglisse@redhat.com> This introduce a dummy HMM device class so device driver can use it to create hmm_device for the sole purpose of registering device memory. It is usefull to device driver that want to manage multiple physical device memory under same struct device umbrella. Changed since v1: - Improve commit message - Add drvdata parameter to set on struct device Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Signed-off-by: Evgeny Baskakov <ebaskakov@nvidia.com> Signed-off-by: John Hubbard <jhubbard@nvidia.com> Signed-off-by: Mark Hairgrove <mhairgrove@nvidia.com> Signed-off-by: Sherry Cheung <SCheung@nvidia.com> Signed-off-by: Subhash Gutti <sgutti@nvidia.com> --- include/linux/hmm.h | 22 +++++++++++- mm/hmm.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 117 insertions(+), 1 deletion(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 3054ce7..e4e6b36 100644 --- a/include/linux/hmm.h +++ b/include/linux/hmm.h @@ -79,11 +79,11 @@ #if IS_ENABLED(CONFIG_HMM) +#include <linux/device.h> #include <linux/migrate.h> #include <linux/memremap.h> #include <linux/completion.h> - struct hmm; /* @@ -433,6 +433,26 @@ static inline unsigned long hmm_devmem_page_get_drvdata(struct page *page) return drvdata[1]; } + + +/* + * struct hmm_device - fake device to hang device memory onto + * + * @device: device struct + * @minor: device minor number + */ +struct hmm_device { + struct device device; + unsigned minor; +}; + +/* + * Device driver that wants to handle multiple devices memory through a single + * fake device can use hmm_device to do so. This is purely a helper and it + * is not needed to make use of any HMM functionality. + */ +struct hmm_device *hmm_device_new(void *drvdata); +void hmm_device_put(struct hmm_device *hmm_device); #endif /* IS_ENABLED(CONFIG_HMM_DEVMEM) */ diff --git a/mm/hmm.c b/mm/hmm.c index 019f379..c477bd1 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -24,6 +24,7 @@ #include <linux/slab.h> #include <linux/sched.h> #include <linux/mmzone.h> +#include <linux/module.h> #include <linux/pagemap.h> #include <linux/swapops.h> #include <linux/hugetlb.h> @@ -1132,4 +1133,99 @@ int hmm_devmem_fault_range(struct hmm_devmem *devmem, return 0; } EXPORT_SYMBOL(hmm_devmem_fault_range); + +/* + * A device driver that wants to handle multiple devices memory through a + * single fake device can use hmm_device to do so. This is purely a helper + * and it is not needed to make use of any HMM functionality. + */ +#define HMM_DEVICE_MAX 256 + +static DECLARE_BITMAP(hmm_device_mask, HMM_DEVICE_MAX); +static DEFINE_SPINLOCK(hmm_device_lock); +static struct class *hmm_device_class; +static dev_t hmm_device_devt; + +static void hmm_device_release(struct device *device) +{ + struct hmm_device *hmm_device; + + hmm_device = container_of(device, struct hmm_device, device); + spin_lock(&hmm_device_lock); + clear_bit(hmm_device->minor, hmm_device_mask); + spin_unlock(&hmm_device_lock); + + kfree(hmm_device); +} + +struct hmm_device *hmm_device_new(void *drvdata) +{ + struct hmm_device *hmm_device; + int ret; + + hmm_device = kzalloc(sizeof(*hmm_device), GFP_KERNEL); + if (!hmm_device) + return ERR_PTR(-ENOMEM); + + ret = alloc_chrdev_region(&hmm_device->device.devt,0,1,"hmm_device"); + if (ret < 0) { + kfree(hmm_device); + return NULL; + } + + spin_lock(&hmm_device_lock); + hmm_device->minor=find_first_zero_bit(hmm_device_mask,HMM_DEVICE_MAX); + if (hmm_device->minor >= HMM_DEVICE_MAX) { + spin_unlock(&hmm_device_lock); + kfree(hmm_device); + return NULL; + } + set_bit(hmm_device->minor, hmm_device_mask); + spin_unlock(&hmm_device_lock); + + dev_set_name(&hmm_device->device, "hmm_device%d", hmm_device->minor); + hmm_device->device.devt = MKDEV(MAJOR(hmm_device_devt), + hmm_device->minor); + hmm_device->device.release = hmm_device_release; + dev_set_drvdata(&hmm_device->device, drvdata); + hmm_device->device.class = hmm_device_class; + device_initialize(&hmm_device->device); + + return hmm_device; +} +EXPORT_SYMBOL(hmm_device_new); + +void hmm_device_put(struct hmm_device *hmm_device) +{ + put_device(&hmm_device->device); +} +EXPORT_SYMBOL(hmm_device_put); + +static int __init hmm_init(void) +{ + int ret; + + ret = alloc_chrdev_region(&hmm_device_devt, 0, + HMM_DEVICE_MAX, + "hmm_device"); + if (ret) + return ret; + + hmm_device_class = class_create(THIS_MODULE, "hmm_device"); + if (IS_ERR(hmm_device_class)) { + unregister_chrdev_region(hmm_device_devt, HMM_DEVICE_MAX); + return PTR_ERR(hmm_device_class); + } + return 0; +} + +static void __exit hmm_exit(void) +{ + unregister_chrdev_region(hmm_device_devt, HMM_DEVICE_MAX); + class_destroy(hmm_device_class); +} + +module_init(hmm_init); +module_exit(hmm_exit); +MODULE_LICENSE("GPL"); #endif /* IS_ENABLED(CONFIG_HMM_DEVMEM) */ -- 2.4.11
WARNING: multiple messages have this Message-ID (diff)
From: "Jérôme Glisse" <jglisse@redhat.com> To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "John Hubbard" <jhubbard@nvidia.com>, "Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>, "David Nellans" <dnellans@nvidia.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Evgeny Baskakov" <ebaskakov@nvidia.com>, "Mark Hairgrove" <mhairgrove@nvidia.com>, "Sherry Cheung" <SCheung@nvidia.com>, "Subhash Gutti" <sgutti@nvidia.com> Subject: [HMM 16/16] mm/hmm/devmem: dummy HMM device for ZONE_DEVICE memory v2 Date: Thu, 16 Mar 2017 12:05:35 -0400 [thread overview] Message-ID: <1489680335-6594-17-git-send-email-jglisse@redhat.com> (raw) In-Reply-To: <1489680335-6594-1-git-send-email-jglisse@redhat.com> This introduce a dummy HMM device class so device driver can use it to create hmm_device for the sole purpose of registering device memory. It is usefull to device driver that want to manage multiple physical device memory under same struct device umbrella. Changed since v1: - Improve commit message - Add drvdata parameter to set on struct device Signed-off-by: JA(C)rA'me Glisse <jglisse@redhat.com> Signed-off-by: Evgeny Baskakov <ebaskakov@nvidia.com> Signed-off-by: John Hubbard <jhubbard@nvidia.com> Signed-off-by: Mark Hairgrove <mhairgrove@nvidia.com> Signed-off-by: Sherry Cheung <SCheung@nvidia.com> Signed-off-by: Subhash Gutti <sgutti@nvidia.com> --- include/linux/hmm.h | 22 +++++++++++- mm/hmm.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 117 insertions(+), 1 deletion(-) diff --git a/include/linux/hmm.h b/include/linux/hmm.h index 3054ce7..e4e6b36 100644 --- a/include/linux/hmm.h +++ b/include/linux/hmm.h @@ -79,11 +79,11 @@ #if IS_ENABLED(CONFIG_HMM) +#include <linux/device.h> #include <linux/migrate.h> #include <linux/memremap.h> #include <linux/completion.h> - struct hmm; /* @@ -433,6 +433,26 @@ static inline unsigned long hmm_devmem_page_get_drvdata(struct page *page) return drvdata[1]; } + + +/* + * struct hmm_device - fake device to hang device memory onto + * + * @device: device struct + * @minor: device minor number + */ +struct hmm_device { + struct device device; + unsigned minor; +}; + +/* + * Device driver that wants to handle multiple devices memory through a single + * fake device can use hmm_device to do so. This is purely a helper and it + * is not needed to make use of any HMM functionality. + */ +struct hmm_device *hmm_device_new(void *drvdata); +void hmm_device_put(struct hmm_device *hmm_device); #endif /* IS_ENABLED(CONFIG_HMM_DEVMEM) */ diff --git a/mm/hmm.c b/mm/hmm.c index 019f379..c477bd1 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -24,6 +24,7 @@ #include <linux/slab.h> #include <linux/sched.h> #include <linux/mmzone.h> +#include <linux/module.h> #include <linux/pagemap.h> #include <linux/swapops.h> #include <linux/hugetlb.h> @@ -1132,4 +1133,99 @@ int hmm_devmem_fault_range(struct hmm_devmem *devmem, return 0; } EXPORT_SYMBOL(hmm_devmem_fault_range); + +/* + * A device driver that wants to handle multiple devices memory through a + * single fake device can use hmm_device to do so. This is purely a helper + * and it is not needed to make use of any HMM functionality. + */ +#define HMM_DEVICE_MAX 256 + +static DECLARE_BITMAP(hmm_device_mask, HMM_DEVICE_MAX); +static DEFINE_SPINLOCK(hmm_device_lock); +static struct class *hmm_device_class; +static dev_t hmm_device_devt; + +static void hmm_device_release(struct device *device) +{ + struct hmm_device *hmm_device; + + hmm_device = container_of(device, struct hmm_device, device); + spin_lock(&hmm_device_lock); + clear_bit(hmm_device->minor, hmm_device_mask); + spin_unlock(&hmm_device_lock); + + kfree(hmm_device); +} + +struct hmm_device *hmm_device_new(void *drvdata) +{ + struct hmm_device *hmm_device; + int ret; + + hmm_device = kzalloc(sizeof(*hmm_device), GFP_KERNEL); + if (!hmm_device) + return ERR_PTR(-ENOMEM); + + ret = alloc_chrdev_region(&hmm_device->device.devt,0,1,"hmm_device"); + if (ret < 0) { + kfree(hmm_device); + return NULL; + } + + spin_lock(&hmm_device_lock); + hmm_device->minor=find_first_zero_bit(hmm_device_mask,HMM_DEVICE_MAX); + if (hmm_device->minor >= HMM_DEVICE_MAX) { + spin_unlock(&hmm_device_lock); + kfree(hmm_device); + return NULL; + } + set_bit(hmm_device->minor, hmm_device_mask); + spin_unlock(&hmm_device_lock); + + dev_set_name(&hmm_device->device, "hmm_device%d", hmm_device->minor); + hmm_device->device.devt = MKDEV(MAJOR(hmm_device_devt), + hmm_device->minor); + hmm_device->device.release = hmm_device_release; + dev_set_drvdata(&hmm_device->device, drvdata); + hmm_device->device.class = hmm_device_class; + device_initialize(&hmm_device->device); + + return hmm_device; +} +EXPORT_SYMBOL(hmm_device_new); + +void hmm_device_put(struct hmm_device *hmm_device) +{ + put_device(&hmm_device->device); +} +EXPORT_SYMBOL(hmm_device_put); + +static int __init hmm_init(void) +{ + int ret; + + ret = alloc_chrdev_region(&hmm_device_devt, 0, + HMM_DEVICE_MAX, + "hmm_device"); + if (ret) + return ret; + + hmm_device_class = class_create(THIS_MODULE, "hmm_device"); + if (IS_ERR(hmm_device_class)) { + unregister_chrdev_region(hmm_device_devt, HMM_DEVICE_MAX); + return PTR_ERR(hmm_device_class); + } + return 0; +} + +static void __exit hmm_exit(void) +{ + unregister_chrdev_region(hmm_device_devt, HMM_DEVICE_MAX); + class_destroy(hmm_device_class); +} + +module_init(hmm_init); +module_exit(hmm_exit); +MODULE_LICENSE("GPL"); #endif /* IS_ENABLED(CONFIG_HMM_DEVMEM) */ -- 2.4.11 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-16 15:13 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-16 16:05 [HMM 00/16] HMM (Heterogeneous Memory Management) v18 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 01/16] mm/memory/hotplug: convert device bool to int to allow for more flags v3 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:08 ` Mel Gorman 2017-03-19 20:08 ` Mel Gorman 2017-03-16 16:05 ` [HMM 02/16] mm/put_page: move ref decrement to put_zone_device_page() Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:08 ` Mel Gorman 2017-03-19 20:08 ` Mel Gorman 2017-03-16 16:05 ` [HMM 03/16] mm/ZONE_DEVICE/free-page: callback when page is freed v3 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:08 ` Mel Gorman 2017-03-19 20:08 ` Mel Gorman 2017-03-16 16:05 ` [HMM 04/16] mm/ZONE_DEVICE/unaddressable: add support for un-addressable device memory v3 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 05/16] mm/ZONE_DEVICE/x86: add support for un-addressable device memory Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 06/16] mm/migrate: add new boolean copy flag to migratepage() callback Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 07/16] mm/migrate: new memory migration helper for use with device memory v4 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:24 ` Reza Arbab 2017-03-16 16:24 ` Reza Arbab 2017-03-16 20:58 ` Balbir Singh 2017-03-16 20:58 ` Balbir Singh 2017-03-16 23:05 ` Andrew Morton 2017-03-16 23:05 ` Andrew Morton 2017-03-17 0:22 ` John Hubbard 2017-03-17 0:22 ` John Hubbard 2017-03-17 0:45 ` Balbir Singh 2017-03-17 0:45 ` Balbir Singh 2017-03-17 0:57 ` John Hubbard 2017-03-17 0:57 ` John Hubbard 2017-03-17 1:52 ` Jerome Glisse 2017-03-17 1:52 ` Jerome Glisse 2017-03-17 3:32 ` Andrew Morton 2017-03-17 3:32 ` Andrew Morton 2017-03-17 3:42 ` Balbir Singh 2017-03-17 3:42 ` Balbir Singh 2017-03-17 4:51 ` Balbir Singh 2017-03-17 4:51 ` Balbir Singh 2017-03-17 7:17 ` John Hubbard 2017-03-17 7:17 ` John Hubbard 2017-03-16 16:05 ` [HMM 08/16] mm/migrate: migrate_vma() unmap page from vma while collecting pages Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 09/16] mm/hmm: heterogeneous memory management (HMM for short) Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 10/16] mm/hmm/mirror: mirror process address space on device with HMM helpers Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 11/16] mm/hmm/mirror: helper to snapshot CPU page table v2 Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman 2017-03-16 16:05 ` [HMM 12/16] mm/hmm/mirror: device page fault handler Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 13/16] mm/hmm/migrate: support un-addressable ZONE_DEVICE page in migration Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 14/16] mm/migrate: allow migrate_vma() to alloc new page on empty entry Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` [HMM 15/16] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse 2017-03-16 16:05 ` Jérôme Glisse [this message] 2017-03-16 16:05 ` [HMM 16/16] mm/hmm/devmem: dummy HMM device for ZONE_DEVICE memory v2 Jérôme Glisse 2017-03-17 6:55 ` Bob Liu 2017-03-17 6:55 ` Bob Liu 2017-03-17 16:53 ` Jerome Glisse 2017-03-17 16:53 ` Jerome Glisse 2017-03-16 20:43 ` [HMM 00/16] HMM (Heterogeneous Memory Management) v18 Andrew Morton 2017-03-16 20:43 ` Andrew Morton 2017-03-16 23:49 ` Jerome Glisse 2017-03-16 23:49 ` Jerome Glisse 2017-03-17 8:29 ` Bob Liu 2017-03-17 8:29 ` Bob Liu 2017-03-17 15:57 ` Jerome Glisse 2017-03-17 15:57 ` Jerome Glisse 2017-03-17 8:39 ` Bob Liu 2017-03-17 8:39 ` Bob Liu 2017-03-17 15:52 ` Jerome Glisse 2017-03-17 15:52 ` Jerome Glisse 2017-03-19 20:09 ` Mel Gorman 2017-03-19 20:09 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1489680335-6594-17-git-send-email-jglisse@redhat.com \ --to=jglisse@redhat.com \ --cc=SCheung@nvidia.com \ --cc=akpm@linux-foundation.org \ --cc=dnellans@nvidia.com \ --cc=ebaskakov@nvidia.com \ --cc=jhubbard@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhairgrove@nvidia.com \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=sgutti@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.