[Intel-wired-lan] [net-next PATCH v2] i40e: fix for queue timing delays

[Intel-wired-lan] [net-next PATCH v2] i40e: fix for queue timing delays

[Carolyn Wyborny]

This patch adds a delay to rx queue disables to accommodate hw needs.

v2: Added missing check for disable only, additional details on the
need for the ugly delay and fixed spacing on comment.

Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Change-ID: I2864ca667ce5dcc2cc44f8718113b719742a46a1
---
internal v2: fixed length of commit message and end comment

 drivers/net/ethernet/intel/i40e/i40e_main.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 4b32b47..3082c7f 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -4181,6 +4181,12 @@ static int i40e_vsi_control_rx(struct i40e_vsi *vsi, bool enable)
 		}
 	}
 
+	/* Due to HW errata, on Rx disable only, the register can indicate done
+	 * before it really is. Needs 50ms to be sure
+	 */
+	if (!enable)
+		mdelay(50);
+
 	return ret;
 }
 

[Intel-wired-lan] [net-next PATCH v2] i40e: fix for queue timing delays

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Carolyn Wyborny
> Sent: Tuesday, March 28, 2017 8:01 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [net-next PATCH v2] i40e: fix for queue timing
> delays
> 
> This patch adds a delay to rx queue disables to accommodate hw needs.
> 
> v2: Added missing check for disable only, additional details on the need for
> the ugly delay and fixed spacing on comment.
> 
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
> Change-ID: I2864ca667ce5dcc2cc44f8718113b719742a46a1
> ---
> internal v2: fixed length of commit message and end comment
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c |    6 ++++++
>  1 file changed, 6 insertions(+)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

[Intel-wired-lan] [net-next PATCH v2] i40e: fix for queue timing delays

[Carolyn Wyborny]

This patch adds a delay to rx queue disables to accommodate hw needs.

v2: Added missing check for disable only, additional details on the need for
the ugly delay and fixed spacing on comment.

Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Change-ID: I2864ca667ce5dcc2cc44f8718113b719742a46a1
---
 drivers/net/ethernet/intel/i40e/i40e_main.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 4b32b47..6ae779b 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -4181,6 +4181,11 @@ static int i40e_vsi_control_rx(struct i40e_vsi *vsi, bool enable)
 		}
 	}
 
+	/* Due to HW errata, on Rx disable only, the register can indicate done
+	 * before it really is. Needs 50ms to be sure */
+	if (!enable)
+		mdelay(50);
+
 	return ret;
 }