[PATCH] tinfoil.py: validate argument in parse_recipe_file

[PATCH] tinfoil.py: validate argument in parse_recipe_file

[Juro Bystricky]

Check for an empty file name to avoid an exception.

[YOCTO#11210]

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
---
 bitbake/lib/bb/tinfoil.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/bitbake/lib/bb/tinfoil.py b/bitbake/lib/bb/tinfoil.py
index 928333a..620f409 100644
--- a/bitbake/lib/bb/tinfoil.py
+++ b/bitbake/lib/bb/tinfoil.py
@@ -399,6 +399,8 @@ class Tinfoil:
                          specify config_data then you cannot use a virtual
                          specification for fn.
         """
+        if not fn:
+            return None
         if appends and appendlist == []:
             appends = False
         if config_data:
-- 
2.7.4

Re: [PATCH] tinfoil.py: validate argument in parse_recipe_file

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

On Wed, Apr 5, 2017 at 2:33 PM, Juro Bystricky <juro.bystricky@intel.com>
wrote:

> Check for an empty file name to avoid an exception.
>
> [YOCTO#11210]
>
> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
>

IMO this is pointless. If you’re calling parse_recipe_file with an empty
string, it’s programmer error, which means raising an exception is a
completely reasonable thing to do.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1118 bytes --]

Re: [PATCH] tinfoil.py: validate argument in parse_recipe_file

[Bystricky, Juro]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

parse_recipe can be called from parse_recipe_file as well. If parse_recipe_file is called with a non-existing recipe, you end up with the exception as well. IMHO for a  non-existent recipe parse_recipe should return None (instead of an exception)


________________________________
From: Christopher Larson [kergoth@gmail.com]
Sent: Wednesday, April 05, 2017 6:32 PM
To: Bystricky, Juro
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH] tinfoil.py: validate argument in parse_recipe_file


On Wed, Apr 5, 2017 at 2:33 PM, Juro Bystricky <juro.bystricky@intel.com<mailto:juro.bystricky@intel.com>> wrote:
Check for an empty file name to avoid an exception.

[YOCTO#11210]

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com<mailto:juro.bystricky@intel.com>>

IMO this is pointless. If you’re calling parse_recipe_file with an empty string, it’s programmer error, which means raising an exception is a completely reasonable thing to do.
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2284 bytes --]

Re: [PATCH] tinfoil.py: validate argument in parse_recipe_file

[Paul Eggleton]

On Friday, 7 April 2017 3:15:21 AM NZST Bystricky, Juro wrote:
> parse_recipe can be called from parse_recipe_file as well. If
> parse_recipe_file is called with a non-existing recipe, you end up with the
> exception as well. IMHO for a  non-existent recipe parse_recipe should
> return None (instead of an exception)

I'm not sure I agree - an exception under these circumstances seems completely 
reasonable to me as well.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre