* [PATCH 0/8] Avoid CamelCases in ks7010 driver
@ 2017-04-29 20:58 Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
` (9 more replies)
0 siblings, 10 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
Janusz Lisiecki (8):
staging: ks7010: avoid CamelCase in fields of struct local_gain_t
staging: ks7010: avoid CamelCase: receiveDTIMs
staging: ks7010: avoid CamelCase: FhParms_t fields
staging: ks7010: avoid CamelCase: link_ap_info_t fields
staging: ks7010: avoid CamelCase: CfParms_t fields
staging: ks7010: avoid CamelCase: atimWindow
staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size
staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
drivers/staging/ks7010/ks_hostif.c | 65 ++++++++++++++++++------------------
drivers/staging/ks7010/ks_hostif.h | 42 +++++++++++------------
drivers/staging/ks7010/ks_wlan.h | 8 ++---
drivers/staging/ks7010/ks_wlan_net.c | 20 +++++------
4 files changed, 68 insertions(+), 67 deletions(-)
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-05-07 3:37 ` Greg Kroah-Hartman
2017-05-07 7:03 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 2/8] " Janusz Lisiecki
` (8 subsequent siblings)
9 siblings, 2 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.c | 6 +++---
drivers/staging/ks7010/ks_wlan.h | 8 ++++----
drivers/staging/ks7010/ks_wlan_net.c | 20 ++++++++++----------
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 7151f16..1f8405e 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -566,9 +566,9 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
break;
case LOCAL_GAIN:
memcpy(&priv->gain, priv->rxp, sizeof(priv->gain));
- DPRINTK(3, "TxMode=%d, RxMode=%d, TxGain=%d, RxGain=%d\n",
- priv->gain.TxMode, priv->gain.RxMode, priv->gain.TxGain,
- priv->gain.RxGain);
+ DPRINTK(3, "tx_mode=%d, rx_mode=%d, tx_gain=%d, rx_gain=%d\n",
+ priv->gain.tx_mode, priv->gain.rx_mode,
+ priv->gain.tx_gain, priv->gain.rx_gain);
break;
case LOCAL_EEPROM_SUM:
memcpy(&priv->eeprom_sum, priv->rxp, sizeof(priv->eeprom_sum));
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index eb15db9..9a3b806 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -264,10 +264,10 @@ struct local_aplist_t {
};
struct local_gain_t {
- u8 TxMode;
- u8 RxMode;
- u8 TxGain;
- u8 RxGain;
+ u8 tx_mode;
+ u8 rx_mode;
+ u8 tx_gain;
+ u8 rx_gain;
};
struct local_eeprom_sum_t {
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 0ef52c8..8c86d94 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -2428,14 +2428,14 @@ static int ks_wlan_set_tx_gain(struct net_device *dev,
return -EPERM;
/* for SLEEP MODE */
if (*uwrq >= 0 && *uwrq <= 0xFF) /* 0-255 */
- priv->gain.TxGain = (uint8_t)*uwrq;
+ priv->gain.tx_gain = (uint8_t)*uwrq;
else
return -EINVAL;
- if (priv->gain.TxGain < 0xFF)
- priv->gain.TxMode = 1;
+ if (priv->gain.tx_gain < 0xFF)
+ priv->gain.tx_mode = 1;
else
- priv->gain.TxMode = 0;
+ priv->gain.tx_mode = 0;
hostif_sme_enqueue(priv, SME_SET_GAIN);
return 0;
@@ -2451,7 +2451,7 @@ static int ks_wlan_get_tx_gain(struct net_device *dev,
if (priv->sleep_mode == SLP_SLEEP)
return -EPERM;
/* for SLEEP MODE */
- *uwrq = priv->gain.TxGain;
+ *uwrq = priv->gain.tx_gain;
hostif_sme_enqueue(priv, SME_GET_GAIN);
return 0;
}
@@ -2467,14 +2467,14 @@ static int ks_wlan_set_rx_gain(struct net_device *dev,
return -EPERM;
/* for SLEEP MODE */
if (*uwrq >= 0 && *uwrq <= 0xFF) /* 0-255 */
- priv->gain.RxGain = (uint8_t)*uwrq;
+ priv->gain.rx_gain = (uint8_t)*uwrq;
else
return -EINVAL;
- if (priv->gain.RxGain < 0xFF)
- priv->gain.RxMode = 1;
+ if (priv->gain.rx_gain < 0xFF)
+ priv->gain.rx_mode = 1;
else
- priv->gain.RxMode = 0;
+ priv->gain.rx_mode = 0;
hostif_sme_enqueue(priv, SME_SET_GAIN);
return 0;
@@ -2490,7 +2490,7 @@ static int ks_wlan_get_rx_gain(struct net_device *dev,
if (priv->sleep_mode == SLP_SLEEP)
return -EPERM;
/* for SLEEP MODE */
- *uwrq = priv->gain.RxGain;
+ *uwrq = priv->gain.rx_gain;
hostif_sme_enqueue(priv, SME_GET_GAIN);
return 0;
}
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
` (7 subsequent siblings)
9 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.c | 24 ++++++++++++------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 1f8405e..856f714 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1696,12 +1696,12 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
static
void hostif_power_mngmt_request(struct ks_wlan_private *priv,
unsigned long mode, unsigned long wake_up,
- unsigned long receiveDTIMs)
+ unsigned long receive_dtims)
{
struct hostif_power_mngmt_request_t *pp;
- DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
- receiveDTIMs);
+ DPRINTK(3, "mode=%lu wake_up=%lu receive_dtims=%lu\n", mode, wake_up,
+ receive_dtims);
/* make primitive */
pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
@@ -1713,7 +1713,7 @@ void hostif_power_mngmt_request(struct ks_wlan_private *priv,
pp->header.event = cpu_to_le16((uint16_t)HIF_POWERMGT_REQ);
pp->mode = cpu_to_le32((uint32_t)mode);
pp->wake_up = cpu_to_le32((uint32_t)wake_up);
- pp->receiveDTIMs = cpu_to_le32((uint32_t)receiveDTIMs);
+ pp->receive_dtims = cpu_to_le32((uint32_t)receive_dtims);
/* send to device request */
ps_confirm_wait_inc(priv);
@@ -2270,44 +2270,44 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv)
static
void hostif_sme_powermgt_set(struct ks_wlan_private *priv)
{
- unsigned long mode, wake_up, receiveDTIMs;
+ unsigned long mode, wake_up, receive_dtims;
DPRINTK(3, "\n");
switch (priv->reg.powermgt) {
case POWMGT_ACTIVE_MODE:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
case POWMGT_SAVE1_MODE:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
case POWMGT_SAVE2_MODE:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 1;
+ receive_dtims = 1;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
default:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
}
- hostif_power_mngmt_request(priv, mode, wake_up, receiveDTIMs);
+ hostif_power_mngmt_request(priv, mode, wake_up, receive_dtims);
}
static
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index d773432..3e53a90 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -188,7 +188,7 @@ struct hostif_power_mngmt_request_t {
u32 wake_up;
#define SLEEP_FALSE 0
#define SLEEP_TRUE 1 /* not used */
- u32 receiveDTIMs;
+ u32 receive_dtims;
#define DTIM_FALSE 0
#define DTIM_TRUE 1
} __packed;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 2/8] " Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
` (6 subsequent siblings)
9 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- dwellTime
- hopSet
- hopPattern
- hopIndex
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 3e53a90..ba0bd92 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -240,10 +240,10 @@ struct rate_set8_t {
} __packed;
struct FhParms_t {
- u16 dwellTime;
- u8 hopSet;
- u8 hopPattern;
- u8 hopIndex;
+ u16 dwell_time;
+ u8 hop_set;
+ u8 hop_pattern;
+ u8 hop_index;
} __packed;
struct DsParms_t {
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
` (2 preceding siblings ...)
2017-04-29 20:58 ` [PATCH 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-04-30 8:59 ` Tobin C. Harding
2017-04-29 20:58 ` [PATCH 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
` (5 subsequent siblings)
9 siblings, 1 reply; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- FhParms_t
- DsParms_t
- CfParms_t
- IbssParms_t
- ErpParams_t
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index ba0bd92..769dbe8 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -239,25 +239,25 @@ struct rate_set8_t {
u8 rate_pad;
} __packed;
-struct FhParms_t {
+struct fh_parms_t {
u16 dwell_time;
u8 hop_set;
u8 hop_pattern;
u8 hop_index;
} __packed;
-struct DsParms_t {
+struct ds_parms_t {
u8 channel;
} __packed;
-struct CfParms_t {
+struct cf_parms_t {
u8 count;
u8 period;
u16 maxDuration;
u16 durRemaining;
} __packed;
-struct IbssParms_t {
+struct ibss_parms_t {
u16 atimWindow;
} __packed;
@@ -267,7 +267,7 @@ struct rsn_t {
u8 body[RSN_BODY_SIZE];
} __packed;
-struct ErpParams_t {
+struct erp_params_t {
u8 erp_info;
} __packed;
@@ -313,11 +313,11 @@ struct link_ap_info_t {
u16 beacon_period; /* +10 */
u16 capability; /* +12 */
struct rate_set8_t rate_set; /* +14 */
- struct FhParms_t fh_parameter; /* +24 */
- struct DsParms_t ds_parameter; /* +29 */
- struct CfParms_t cf_parameter; /* +30 */
- struct IbssParms_t ibss_parameter; /* +36 */
- struct ErpParams_t erp_parameter; /* +38 */
+ struct fh_parms_t fh_parameter; /* +24 */
+ struct ds_parms_t ds_parameter; /* +29 */
+ struct cf_parms_t cf_parameter; /* +30 */
+ struct ibss_parms_t ibss_parameter; /* +36 */
+ struct erp_params_t erp_parameter; /* +38 */
u8 pad1; /* +39 */
struct rate_set8_t ext_rate_set; /* +40 */
u8 DTIM_period; /* +50 */
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
` (3 preceding siblings ...)
2017-04-29 20:58 ` [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
` (4 subsequent siblings)
9 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- maxDuration
- durRemaining
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 769dbe8..19a1489 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -253,8 +253,8 @@ struct ds_parms_t {
struct cf_parms_t {
u8 count;
u8 period;
- u16 maxDuration;
- u16 durRemaining;
+ u16 max_duration;
+ u16 dur_remaining;
} __packed;
struct ibss_parms_t {
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 6/8] staging: ks7010: avoid CamelCase: atimWindow
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
` (4 preceding siblings ...)
2017-04-29 20:58 ` [PATCH 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
` (3 subsequent siblings)
9 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 19a1489..27274d4 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -258,7 +258,7 @@ struct cf_parms_t {
} __packed;
struct ibss_parms_t {
- u16 atimWindow;
+ u16 atim_window;
} __packed;
struct rsn_t {
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
` (5 preceding siblings ...)
2017-04-29 20:58 ` [PATCH 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
` (2 subsequent siblings)
9 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase association_request_t and association_response_t
struct field names with underscores to comply with the standard kernel
coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.c | 10 +++++-----
drivers/staging/ks7010/ks_hostif.h | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 856f714..05436bb 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -947,18 +947,18 @@ void hostif_associate_indication(struct ks_wlan_private *priv)
wrqu.data.length += sizeof(associnfo_leader0) - 1;
pbuf += sizeof(associnfo_leader0) - 1;
- for (i = 0; i < assoc_req->reqIEs_size; i++)
+ for (i = 0; i < assoc_req->req_ies_size; i++)
pbuf += sprintf(pbuf, "%02x", *(pb + i));
- wrqu.data.length += (assoc_req->reqIEs_size) * 2;
+ wrqu.data.length += (assoc_req->req_ies_size) * 2;
memcpy(pbuf, associnfo_leader1, sizeof(associnfo_leader1) - 1);
wrqu.data.length += sizeof(associnfo_leader1) - 1;
pbuf += sizeof(associnfo_leader1) - 1;
- pb += assoc_req->reqIEs_size;
- for (i = 0; i < assoc_resp->respIEs_size; i++)
+ pb += assoc_req->req_ies_size;
+ for (i = 0; i < assoc_resp->resp_ies_size; i++)
pbuf += sprintf(pbuf, "%02x", *(pb + i));
- wrqu.data.length += (assoc_resp->respIEs_size) * 2;
+ wrqu.data.length += (assoc_resp->resp_ies_size) * 2;
pbuf += sprintf(pbuf, ")");
wrqu.data.length += 1;
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 27274d4..0e3a956 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -482,7 +482,7 @@ struct association_request_t {
u16 capability;
u16 listen_interval;
u8 ap_address[6];
- u16 reqIEs_size;
+ u16 req_ies_size;
} __packed;
struct association_response_t {
@@ -493,14 +493,14 @@ struct association_response_t {
u16 capability;
u16 status;
u16 association_id;
- u16 respIEs_size;
+ u16 resp_ies_size;
} __packed;
struct hostif_associate_indication_t {
struct hostif_hdr header;
struct association_request_t assoc_req;
struct association_response_t assoc_resp;
- /* followed by (reqIEs_size + respIEs_size) octets of data */
+ /* followed by (req_ies_size + resp_ies_size) octets of data */
/* reqIEs data *//* respIEs data */
} __packed;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
` (6 preceding siblings ...)
2017-04-29 20:58 ` [PATCH 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
@ 2017-04-29 20:58 ` Janusz Lisiecki
2017-05-07 7:07 ` [PATCH v2 " Janusz Lisiecki
2017-04-30 9:01 ` [PATCH 0/8] Avoid CamelCases in ks7010 driver Tobin C. Harding
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
9 siblings, 1 reply; 34+ messages in thread
From: Janusz Lisiecki @ 2017-04-29 20:58 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase local variables' name with underscores to comply
with the standard kernel coding style.
Changed:
- LinkSpeed
- TransmittedFrameCount
- ReceivedFragmentCount
- FailedCount
- FCSErrorCount
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
drivers/staging/ks7010/ks_hostif.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 05436bb..8dec8ba 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -993,30 +993,31 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv)
{
struct iw_statistics *wstats = &priv->wstats;
unsigned char rssi, signal, noise;
- unsigned char LinkSpeed;
- unsigned int TransmittedFrameCount, ReceivedFragmentCount;
- unsigned int FailedCount, FCSErrorCount;
+ unsigned char link_speed;
+ unsigned int transmitted_frame_count, received_fragment_count;
+ unsigned int failed_count, fcs_error_count;
DPRINTK(3, "\n");
rssi = get_BYTE(priv);
signal = get_BYTE(priv);
noise = get_BYTE(priv);
- LinkSpeed = get_BYTE(priv);
- TransmittedFrameCount = get_DWORD(priv);
- ReceivedFragmentCount = get_DWORD(priv);
- FailedCount = get_DWORD(priv);
- FCSErrorCount = get_DWORD(priv);
+ link_speed = get_BYTE(priv);
+ transmitted_frame_count = get_DWORD(priv);
+ received_fragment_count = get_DWORD(priv);
+ failed_count = get_DWORD(priv);
+ fcs_error_count = get_DWORD(priv);
DPRINTK(4, "phyinfo confirm rssi=%d signal=%d\n", rssi, signal);
- priv->current_rate = (LinkSpeed & RATE_MASK);
+ priv->current_rate = (link_speed & RATE_MASK);
wstats->qual.qual = signal;
wstats->qual.level = 256 - rssi;
wstats->qual.noise = 0; /* invalid noise value */
wstats->qual.updated = IW_QUAL_ALL_UPDATED | IW_QUAL_DBM;
- DPRINTK(3, "\n rssi=%u\n signal=%u\n LinkSpeed=%ux500Kbps\n \
- TransmittedFrameCount=%u\n ReceivedFragmentCount=%u\n FailedCount=%u\n \
- FCSErrorCount=%u\n", rssi, signal, LinkSpeed, TransmittedFrameCount, ReceivedFragmentCount, FailedCount, FCSErrorCount);
+ DPRINTK(3, "\n rssi=%u\n signal=%u\n link_speed=%ux500Kbps\n \
+ transmitted_frame_count=%u\n received_fragment_count=%u\n failed_count=%u\n \
+ fcs_error_count=%u\n", rssi, signal, link_speed, transmitted_frame_count,
+ received_fragment_count, failed_count, fcs_error_count);
/* wake_up_interruptible_all(&priv->confirm_wait); */
complete(&priv->confirm_wait);
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields
2017-04-29 20:58 ` [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
@ 2017-04-30 8:59 ` Tobin C. Harding
0 siblings, 0 replies; 34+ messages in thread
From: Tobin C. Harding @ 2017-04-30 8:59 UTC (permalink / raw)
To: Janusz Lisiecki
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Wolfram Sang
On Sat, Apr 29, 2017 at 10:58:44PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase struct field names with underscores to comply
> with the standard kernel coding style.
> Changed:
> - FhParms_t
> - DsParms_t
> - CfParms_t
> - IbssParms_t
> - ErpParams_t
>
> Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
> ---
> drivers/staging/ks7010/ks_hostif.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
> index ba0bd92..769dbe8 100644
> --- a/drivers/staging/ks7010/ks_hostif.h
> +++ b/drivers/staging/ks7010/ks_hostif.h
> @@ -239,25 +239,25 @@ struct rate_set8_t {
> u8 rate_pad;
> } __packed;
>
> -struct FhParms_t {
> +struct fh_parms_t {
> u16 dwell_time;
> u8 hop_set;
> u8 hop_pattern;
> u8 hop_index;
> } __packed;
>
> -struct DsParms_t {
> +struct ds_parms_t {
> u8 channel;
> } __packed;
>
> -struct CfParms_t {
> +struct cf_parms_t {
> u8 count;
> u8 period;
> u16 maxDuration;
> u16 durRemaining;
> } __packed;
>
> -struct IbssParms_t {
> +struct ibss_parms_t {
> u16 atimWindow;
> } __packed;
>
> @@ -267,7 +267,7 @@ struct rsn_t {
> u8 body[RSN_BODY_SIZE];
> } __packed;
>
> -struct ErpParams_t {
> +struct erp_params_t {
> u8 erp_info;
> } __packed;
>
> @@ -313,11 +313,11 @@ struct link_ap_info_t {
> u16 beacon_period; /* +10 */
> u16 capability; /* +12 */
> struct rate_set8_t rate_set; /* +14 */
> - struct FhParms_t fh_parameter; /* +24 */
> - struct DsParms_t ds_parameter; /* +29 */
> - struct CfParms_t cf_parameter; /* +30 */
> - struct IbssParms_t ibss_parameter; /* +36 */
> - struct ErpParams_t erp_parameter; /* +38 */
> + struct fh_parms_t fh_parameter; /* +24 */
> + struct ds_parms_t ds_parameter; /* +29 */
> + struct cf_parms_t cf_parameter; /* +30 */
> + struct ibss_parms_t ibss_parameter; /* +36 */
> + struct erp_params_t erp_parameter; /* +38 */
4 out of 5 of these struct members appear to be unused in the
driver. I think the patch is good as it is though because I don't
think we should be chopping up struct descriptions until we are
testing on hardware.
Only my opinion, based more on a hunch than on any real experience.
thanks,
Tobin.
> u8 pad1; /* +39 */
> struct rate_set8_t ext_rate_set; /* +40 */
> u8 DTIM_period; /* +50 */
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 0/8] Avoid CamelCases in ks7010 driver
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
` (7 preceding siblings ...)
2017-04-29 20:58 ` [PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
@ 2017-04-30 9:01 ` Tobin C. Harding
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
9 siblings, 0 replies; 34+ messages in thread
From: Tobin C. Harding @ 2017-04-30 9:01 UTC (permalink / raw)
To: Janusz Lisiecki
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Wolfram Sang
On Sat, Apr 29, 2017 at 10:58:40PM +0200, Janusz Lisiecki wrote:
> This patchset fix CamelCases in ks7010 driver except michael_mic
> which will be replaced by kernel implementation in the future.
Series looks good to me. For what its worth;
Reviewed-by: Tobin C. Harding <me@tobin.cc>
> Janusz Lisiecki (8):
> staging: ks7010: avoid CamelCase in fields of struct local_gain_t
> staging: ks7010: avoid CamelCase: receiveDTIMs
> staging: ks7010: avoid CamelCase: FhParms_t fields
> staging: ks7010: avoid CamelCase: link_ap_info_t fields
> staging: ks7010: avoid CamelCase: CfParms_t fields
> staging: ks7010: avoid CamelCase: atimWindow
> staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size
> staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
>
> drivers/staging/ks7010/ks_hostif.c | 65 ++++++++++++++++++------------------
> drivers/staging/ks7010/ks_hostif.h | 42 +++++++++++------------
> drivers/staging/ks7010/ks_wlan.h | 8 ++---
> drivers/staging/ks7010/ks_wlan_net.c | 20 +++++------
> 4 files changed, 68 insertions(+), 67 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t
2017-04-29 20:58 ` [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
@ 2017-05-07 3:37 ` Greg Kroah-Hartman
2017-05-12 13:46 ` Janusz Lisiecki
2017-05-07 7:03 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
1 sibling, 1 reply; 34+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-07 3:37 UTC (permalink / raw)
To: Janusz Lisiecki; +Cc: Wolfram Sang, Linux Driver Project Developer List
On Sat, Apr 29, 2017 at 10:58:41PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase fields of struct with underscores to comply
> with the standard kernel coding style
>
> Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
> Reviewed-by: Tobin C. Harding <me@tobin.cc>
Not all of the patches in this series applied to my tree. Please fix up
the ones I didn't apply and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-04-29 20:58 ` [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
2017-05-07 3:37 ` Greg Kroah-Hartman
@ 2017-05-07 7:03 ` Janusz Lisiecki
2017-05-12 9:10 ` Greg Kroah-Hartman
1 sibling, 1 reply; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-07 7:03 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 49e9542..5cdbc8a 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1660,13 +1660,13 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
static
void hostif_power_mgmt_request(struct ks_wlan_private *priv,
- unsigned long mode, unsigned long wake_up,
- unsigned long receiveDTIMs)
+ unsigned long mode, unsigned long wake_up,
+ unsigned long receive_dtims)
{
struct hostif_power_mgmt_request_t *pp;
- DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
- receiveDTIMs);
+ DPRINTK(3, "mode=%lu wake_up=%lu receive_dtims=%lu\n", mode, wake_up,
+ receive_dtims);
pp = hostif_generic_request(sizeof(*pp), HIF_POWER_MGMT_REQ);
if (!pp)
@@ -1674,7 +1674,7 @@ void hostif_power_mgmt_request(struct ks_wlan_private *priv,
pp->mode = cpu_to_le32((uint32_t)mode);
pp->wake_up = cpu_to_le32((uint32_t)wake_up);
- pp->receiveDTIMs = cpu_to_le32((uint32_t)receiveDTIMs);
+ pp->receive_dtims = cpu_to_le32((uint32_t)receive_dtims);
/* send to device request */
ps_confirm_wait_inc(priv);
@@ -2218,44 +2218,44 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv)
static
void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
{
- unsigned long mode, wake_up, receiveDTIMs;
+ unsigned long mode, wake_up, receive_dtims;
DPRINTK(3, "\n");
switch (priv->reg.power_mgmt) {
case POWER_MGMT_ACTIVE:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
case POWER_MGMT_SAVE1:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
case POWER_MGMT_SAVE2:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 1;
+ receive_dtims = 1;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
default:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
}
- hostif_power_mgmt_request(priv, mode, wake_up, receiveDTIMs);
+ hostif_power_mgmt_request(priv, mode, wake_up, receive_dtims);
}
static
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index d758076..5c8e455 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -188,7 +188,7 @@ struct hostif_power_mgmt_request_t {
u32 wake_up;
#define SLEEP_FALSE 0
#define SLEEP_TRUE 1 /* not used */
- u32 receiveDTIMs;
+ u32 receive_dtims;
#define DTIM_FALSE 0
#define DTIM_TRUE 1
} __packed;
--
1.9.1
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
2017-04-29 20:58 ` [PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
@ 2017-05-07 7:07 ` Janusz Lisiecki
0 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-07 7:07 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase local variables' name with underscores to comply
with the standard kernel coding style.
Changed:
- LinkSpeed
- TransmittedFrameCount
- ReceivedFragmentCount
- FailedCount
- FCSErrorCount
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 33 ++++++++++++++++-----------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 5cdbc8a..1d6bda1 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -994,22 +994,22 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv)
{
struct iw_statistics *wstats = &priv->wstats;
unsigned char rssi, signal, noise;
- unsigned char LinkSpeed;
- unsigned int TransmittedFrameCount, ReceivedFragmentCount;
- unsigned int FailedCount, FCSErrorCount;
+ unsigned char link_speed;
+ unsigned int transmitted_frame_count, received_fragment_count;
+ unsigned int failed_count, fcs_error_count;
DPRINTK(3, "\n");
rssi = get_BYTE(priv);
signal = get_BYTE(priv);
noise = get_BYTE(priv);
- LinkSpeed = get_BYTE(priv);
- TransmittedFrameCount = get_DWORD(priv);
- ReceivedFragmentCount = get_DWORD(priv);
- FailedCount = get_DWORD(priv);
- FCSErrorCount = get_DWORD(priv);
+ link_speed = get_BYTE(priv);
+ transmitted_frame_count = get_DWORD(priv);
+ received_fragment_count = get_DWORD(priv);
+ failed_count = get_DWORD(priv);
+ fcs_error_count = get_DWORD(priv);
DPRINTK(4, "phyinfo confirm rssi=%d signal=%d\n", rssi, signal);
- priv->current_rate = (LinkSpeed & RATE_MASK);
+ priv->current_rate = (link_speed & RATE_MASK);
wstats->qual.qual = signal;
wstats->qual.level = 256 - rssi;
wstats->qual.noise = 0; /* invalid noise value */
@@ -1017,14 +1017,13 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv)
DPRINTK(3, "\n rssi=%u\n"
" signal=%u\n"
- " LinkSpeed=%ux500Kbps\n"
- " TransmittedFrameCount=%u\n"
- " ReceivedFragmentCount=%u\n"
- " FailedCount=%u\n"
- " FCSErrorCount=%u\n",
- rssi, signal, LinkSpeed, TransmittedFrameCount,
- ReceivedFragmentCount, FailedCount, FCSErrorCount);
-
+ " link_speed=%ux500Kbps\n"
+ " transmitted_frame_count=%u\n"
+ " received_fragment_count=%u\n"
+ " failed_count=%u\n"
+ " fcs_error_count=%u\n",
+ rssi, signal, link_speed, transmitted_frame_count,
+ received_fragment_count, failed_count, fcs_error_count);
/* wake_up_interruptible_all(&priv->confirm_wait); */
complete(&priv->confirm_wait);
}
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-05-07 7:03 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
@ 2017-05-12 9:10 ` Greg Kroah-Hartman
0 siblings, 0 replies; 34+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-12 9:10 UTC (permalink / raw)
To: Janusz Lisiecki; +Cc: Linux Driver Project Developer List, Wolfram Sang
On Sun, May 07, 2017 at 09:03:19AM +0200, Janusz Lisiecki wrote:
> Replace CamelCase variable name with underscores to comply
> with the standard kernel coding style.
>
> Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
> ---
> drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
> drivers/staging/ks7010/ks_hostif.h | 2 +-
> 2 files changed, 14 insertions(+), 14 deletions(-)
I only have patch 1/8 and 8/8 here, where are the rest of these?
Always resend a whole patch series, and properly thread them. Please
fix up and resend them all.
Also, you need to say what changed in v2 below the --- line.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v2 0/8] Avoid CamelCases in ks7010 driver
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
` (8 preceding siblings ...)
2017-04-30 9:01 ` [PATCH 0/8] Avoid CamelCases in ks7010 driver Tobin C. Harding
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
` (8 more replies)
9 siblings, 9 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
---
v2:
- Rebased all patches to next-20170512. 2 and 8 should apply cleanly now
Janusz Lisiecki (8):
staging: ks7010: avoid CamelCase in fields of struct local_gain_t
staging: ks7010: avoid CamelCase: receiveDTIMs
staging: ks7010: avoid CamelCase: FhParms_t fields
staging: ks7010: avoid CamelCase: link_ap_info_t fields
staging: ks7010: avoid CamelCase: CfParms_t fields
staging: ks7010: avoid CamelCase: atimWindow
staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size
staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
drivers/staging/ks7010/ks_hostif.c | 75 ++++++++++++++++++------------------
drivers/staging/ks7010/ks_hostif.h | 42 ++++++++++----------
drivers/staging/ks7010/ks_wlan.h | 8 ++--
drivers/staging/ks7010/ks_wlan_net.c | 20 +++++-----
4 files changed, 72 insertions(+), 73 deletions(-)
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-15 10:03 ` Greg Kroah-Hartman
2017-05-12 13:42 ` [PATCH v2 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
` (7 subsequent siblings)
8 siblings, 1 reply; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 6 +++---
drivers/staging/ks7010/ks_wlan.h | 8 ++++----
drivers/staging/ks7010/ks_wlan_net.c | 20 ++++++++++----------
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 49e9542..6d6cbe1 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -567,9 +567,9 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
break;
case LOCAL_GAIN:
memcpy(&priv->gain, priv->rxp, sizeof(priv->gain));
- DPRINTK(3, "TxMode=%d, RxMode=%d, TxGain=%d, RxGain=%d\n",
- priv->gain.TxMode, priv->gain.RxMode, priv->gain.TxGain,
- priv->gain.RxGain);
+ DPRINTK(3, "tx_mode=%d, rx_mode=%d, tx_gain=%d, rx_gain=%d\n",
+ priv->gain.tx_mode, priv->gain.rx_mode,
+ priv->gain.tx_gain, priv->gain.rx_gain);
break;
case LOCAL_EEPROM_SUM:
memcpy(&priv->eeprom_sum, priv->rxp, sizeof(priv->eeprom_sum));
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index cd4f56d..3767079 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -264,10 +264,10 @@ struct local_aplist_t {
};
struct local_gain_t {
- u8 TxMode;
- u8 RxMode;
- u8 TxGain;
- u8 RxGain;
+ u8 tx_mode;
+ u8 rx_mode;
+ u8 tx_gain;
+ u8 rx_gain;
};
struct local_eeprom_sum_t {
diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index 5a43f19..0c778aa 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -2378,14 +2378,14 @@ static int ks_wlan_set_tx_gain(struct net_device *dev,
return -EPERM;
/* for SLEEP MODE */
if (*uwrq >= 0 && *uwrq <= 0xFF) /* 0-255 */
- priv->gain.TxGain = (uint8_t)*uwrq;
+ priv->gain.tx_gain = (uint8_t)*uwrq;
else
return -EINVAL;
- if (priv->gain.TxGain < 0xFF)
- priv->gain.TxMode = 1;
+ if (priv->gain.tx_gain < 0xFF)
+ priv->gain.tx_mode = 1;
else
- priv->gain.TxMode = 0;
+ priv->gain.tx_mode = 0;
hostif_sme_enqueue(priv, SME_SET_GAIN);
return 0;
@@ -2400,7 +2400,7 @@ static int ks_wlan_get_tx_gain(struct net_device *dev,
if (priv->sleep_mode == SLP_SLEEP)
return -EPERM;
/* for SLEEP MODE */
- *uwrq = priv->gain.TxGain;
+ *uwrq = priv->gain.tx_gain;
hostif_sme_enqueue(priv, SME_GET_GAIN);
return 0;
}
@@ -2415,14 +2415,14 @@ static int ks_wlan_set_rx_gain(struct net_device *dev,
return -EPERM;
/* for SLEEP MODE */
if (*uwrq >= 0 && *uwrq <= 0xFF) /* 0-255 */
- priv->gain.RxGain = (uint8_t)*uwrq;
+ priv->gain.rx_gain = (uint8_t)*uwrq;
else
return -EINVAL;
- if (priv->gain.RxGain < 0xFF)
- priv->gain.RxMode = 1;
+ if (priv->gain.rx_gain < 0xFF)
+ priv->gain.rx_mode = 1;
else
- priv->gain.RxMode = 0;
+ priv->gain.rx_mode = 0;
hostif_sme_enqueue(priv, SME_SET_GAIN);
return 0;
@@ -2437,7 +2437,7 @@ static int ks_wlan_get_rx_gain(struct net_device *dev,
if (priv->sleep_mode == SLP_SLEEP)
return -EPERM;
/* for SLEEP MODE */
- *uwrq = priv->gain.RxGain;
+ *uwrq = priv->gain.rx_gain;
hostif_sme_enqueue(priv, SME_GET_GAIN);
return 0;
}
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
` (6 subsequent siblings)
8 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 6d6cbe1..6a55814 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1660,13 +1660,13 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
static
void hostif_power_mgmt_request(struct ks_wlan_private *priv,
- unsigned long mode, unsigned long wake_up,
- unsigned long receiveDTIMs)
+ unsigned long mode, unsigned long wake_up,
+ unsigned long receive_dtims)
{
struct hostif_power_mgmt_request_t *pp;
- DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
- receiveDTIMs);
+ DPRINTK(3, "mode=%lu wake_up=%lu receive_dtims=%lu\n", mode, wake_up,
+ receive_dtims);
pp = hostif_generic_request(sizeof(*pp), HIF_POWER_MGMT_REQ);
if (!pp)
@@ -1674,7 +1674,7 @@ void hostif_power_mgmt_request(struct ks_wlan_private *priv,
pp->mode = cpu_to_le32((uint32_t)mode);
pp->wake_up = cpu_to_le32((uint32_t)wake_up);
- pp->receiveDTIMs = cpu_to_le32((uint32_t)receiveDTIMs);
+ pp->receive_dtims = cpu_to_le32((uint32_t)receive_dtims);
/* send to device request */
ps_confirm_wait_inc(priv);
@@ -2218,44 +2218,44 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv)
static
void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
{
- unsigned long mode, wake_up, receiveDTIMs;
+ unsigned long mode, wake_up, receive_dtims;
DPRINTK(3, "\n");
switch (priv->reg.power_mgmt) {
case POWER_MGMT_ACTIVE:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
case POWER_MGMT_SAVE1:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
case POWER_MGMT_SAVE2:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 1;
+ receive_dtims = 1;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
default:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
}
- hostif_power_mgmt_request(priv, mode, wake_up, receiveDTIMs);
+ hostif_power_mgmt_request(priv, mode, wake_up, receive_dtims);
}
static
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index d758076..5c8e455 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -188,7 +188,7 @@ struct hostif_power_mgmt_request_t {
u32 wake_up;
#define SLEEP_FALSE 0
#define SLEEP_TRUE 1 /* not used */
- u32 receiveDTIMs;
+ u32 receive_dtims;
#define DTIM_FALSE 0
#define DTIM_TRUE 1
} __packed;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
` (5 subsequent siblings)
8 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- dwellTime
- hopSet
- hopPattern
- hopIndex
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 5c8e455..4d77ea8 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -239,10 +239,10 @@ struct rate_set8_t {
} __packed;
struct FhParms_t {
- u16 dwellTime;
- u8 hopSet;
- u8 hopPattern;
- u8 hopIndex;
+ u16 dwell_time;
+ u8 hop_set;
+ u8 hop_pattern;
+ u8 hop_index;
} __packed;
struct DsParms_t {
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
` (2 preceding siblings ...)
2017-05-12 13:42 ` [PATCH v2 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
` (4 subsequent siblings)
8 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- FhParms_t
- DsParms_t
- CfParms_t
- IbssParms_t
- ErpParams_t
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 4d77ea8..42ae077 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -238,25 +238,25 @@ struct rate_set8_t {
u8 rate_pad;
} __packed;
-struct FhParms_t {
+struct fh_parms_t {
u16 dwell_time;
u8 hop_set;
u8 hop_pattern;
u8 hop_index;
} __packed;
-struct DsParms_t {
+struct ds_parms_t {
u8 channel;
} __packed;
-struct CfParms_t {
+struct cf_parms_t {
u8 count;
u8 period;
u16 maxDuration;
u16 durRemaining;
} __packed;
-struct IbssParms_t {
+struct ibss_parms_t {
u16 atimWindow;
} __packed;
@@ -266,7 +266,7 @@ struct rsn_t {
u8 body[RSN_BODY_SIZE];
} __packed;
-struct ErpParams_t {
+struct erp_params_t {
u8 erp_info;
} __packed;
@@ -312,11 +312,11 @@ struct link_ap_info_t {
u16 beacon_period; /* +10 */
u16 capability; /* +12 */
struct rate_set8_t rate_set; /* +14 */
- struct FhParms_t fh_parameter; /* +24 */
- struct DsParms_t ds_parameter; /* +29 */
- struct CfParms_t cf_parameter; /* +30 */
- struct IbssParms_t ibss_parameter; /* +36 */
- struct ErpParams_t erp_parameter; /* +38 */
+ struct fh_parms_t fh_parameter; /* +24 */
+ struct ds_parms_t ds_parameter; /* +29 */
+ struct cf_parms_t cf_parameter; /* +30 */
+ struct ibss_parms_t ibss_parameter; /* +36 */
+ struct erp_params_t erp_parameter; /* +38 */
u8 pad1; /* +39 */
struct rate_set8_t ext_rate_set; /* +40 */
u8 DTIM_period; /* +50 */
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
` (3 preceding siblings ...)
2017-05-12 13:42 ` [PATCH v2 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
` (3 subsequent siblings)
8 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- maxDuration
- durRemaining
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 42ae077..77d8346 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -252,8 +252,8 @@ struct ds_parms_t {
struct cf_parms_t {
u8 count;
u8 period;
- u16 maxDuration;
- u16 durRemaining;
+ u16 max_duration;
+ u16 dur_remaining;
} __packed;
struct ibss_parms_t {
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 6/8] staging: ks7010: avoid CamelCase: atimWindow
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
` (4 preceding siblings ...)
2017-05-12 13:42 ` [PATCH v2 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
` (2 subsequent siblings)
8 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 77d8346..72f36db 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -257,7 +257,7 @@ struct cf_parms_t {
} __packed;
struct ibss_parms_t {
- u16 atimWindow;
+ u16 atim_window;
} __packed;
struct rsn_t {
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
` (5 preceding siblings ...)
2017-05-12 13:42 ` [PATCH v2 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 0/2] Avoid CamelCases in ks7010 driver Janusz Lisiecki
8 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase association_request_t and association_response_t
struct field names with underscores to comply with the standard kernel
coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 10 +++++-----
drivers/staging/ks7010/ks_hostif.h | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 6a55814..0f9a798 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -948,18 +948,18 @@ void hostif_associate_indication(struct ks_wlan_private *priv)
wrqu.data.length += sizeof(associnfo_leader0) - 1;
pbuf += sizeof(associnfo_leader0) - 1;
- for (i = 0; i < assoc_req->reqIEs_size; i++)
+ for (i = 0; i < assoc_req->req_ies_size; i++)
pbuf += sprintf(pbuf, "%02x", *(pb + i));
- wrqu.data.length += (assoc_req->reqIEs_size) * 2;
+ wrqu.data.length += (assoc_req->req_ies_size) * 2;
memcpy(pbuf, associnfo_leader1, sizeof(associnfo_leader1) - 1);
wrqu.data.length += sizeof(associnfo_leader1) - 1;
pbuf += sizeof(associnfo_leader1) - 1;
- pb += assoc_req->reqIEs_size;
- for (i = 0; i < assoc_resp->respIEs_size; i++)
+ pb += assoc_req->req_ies_size;
+ for (i = 0; i < assoc_resp->resp_ies_size; i++)
pbuf += sprintf(pbuf, "%02x", *(pb + i));
- wrqu.data.length += (assoc_resp->respIEs_size) * 2;
+ wrqu.data.length += (assoc_resp->resp_ies_size) * 2;
pbuf += sprintf(pbuf, ")");
wrqu.data.length += 1;
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 72f36db..d93fff6 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -481,7 +481,7 @@ struct association_request_t {
u16 capability;
u16 listen_interval;
u8 ap_address[6];
- u16 reqIEs_size;
+ u16 req_ies_size;
} __packed;
struct association_response_t {
@@ -492,14 +492,14 @@ struct association_response_t {
u16 capability;
u16 status;
u16 association_id;
- u16 respIEs_size;
+ u16 resp_ies_size;
} __packed;
struct hostif_associate_indication_t {
struct hostif_hdr header;
struct association_request_t assoc_req;
struct association_response_t assoc_resp;
- /* followed by (reqIEs_size + respIEs_size) octets of data */
+ /* followed by (req_ies_size + resp_ies_size) octets of data */
/* reqIEs data *//* respIEs data */
} __packed;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
` (6 preceding siblings ...)
2017-05-12 13:42 ` [PATCH v2 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
@ 2017-05-12 13:42 ` Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 0/2] Avoid CamelCases in ks7010 driver Janusz Lisiecki
8 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase local variables' name with underscores to comply
with the standard kernel coding style.
Changed:
- LinkSpeed
- TransmittedFrameCount
- ReceivedFragmentCount
- FailedCount
- FCSErrorCount
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 33 ++++++++++++++++-----------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 0f9a798..92ed175 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -994,22 +994,22 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv)
{
struct iw_statistics *wstats = &priv->wstats;
unsigned char rssi, signal, noise;
- unsigned char LinkSpeed;
- unsigned int TransmittedFrameCount, ReceivedFragmentCount;
- unsigned int FailedCount, FCSErrorCount;
+ unsigned char link_speed;
+ unsigned int transmitted_frame_count, received_fragment_count;
+ unsigned int failed_count, fcs_error_count;
DPRINTK(3, "\n");
rssi = get_BYTE(priv);
signal = get_BYTE(priv);
noise = get_BYTE(priv);
- LinkSpeed = get_BYTE(priv);
- TransmittedFrameCount = get_DWORD(priv);
- ReceivedFragmentCount = get_DWORD(priv);
- FailedCount = get_DWORD(priv);
- FCSErrorCount = get_DWORD(priv);
+ link_speed = get_BYTE(priv);
+ transmitted_frame_count = get_DWORD(priv);
+ received_fragment_count = get_DWORD(priv);
+ failed_count = get_DWORD(priv);
+ fcs_error_count = get_DWORD(priv);
DPRINTK(4, "phyinfo confirm rssi=%d signal=%d\n", rssi, signal);
- priv->current_rate = (LinkSpeed & RATE_MASK);
+ priv->current_rate = (link_speed & RATE_MASK);
wstats->qual.qual = signal;
wstats->qual.level = 256 - rssi;
wstats->qual.noise = 0; /* invalid noise value */
@@ -1017,14 +1017,13 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv)
DPRINTK(3, "\n rssi=%u\n"
" signal=%u\n"
- " LinkSpeed=%ux500Kbps\n"
- " TransmittedFrameCount=%u\n"
- " ReceivedFragmentCount=%u\n"
- " FailedCount=%u\n"
- " FCSErrorCount=%u\n",
- rssi, signal, LinkSpeed, TransmittedFrameCount,
- ReceivedFragmentCount, FailedCount, FCSErrorCount);
-
+ " link_speed=%ux500Kbps\n"
+ " transmitted_frame_count=%u\n"
+ " received_fragment_count=%u\n"
+ " failed_count=%u\n"
+ " fcs_error_count=%u\n",
+ rssi, signal, link_speed, transmitted_frame_count,
+ received_fragment_count, failed_count, fcs_error_count);
/* wake_up_interruptible_all(&priv->confirm_wait); */
complete(&priv->confirm_wait);
}
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t
2017-05-07 3:37 ` Greg Kroah-Hartman
@ 2017-05-12 13:46 ` Janusz Lisiecki
0 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-12 13:46 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Linux Driver Project Developer List, Wolfram Sang
W dniu 2017-05-07 o 05:37, Greg Kroah-Hartman pisze:
> On Sat, Apr 29, 2017 at 10:58:41PM +0200, Janusz Lisiecki wrote:
>> Replace CamelCase fields of struct with underscores to comply
>> with the standard kernel coding style
>>
>> Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
>> Reviewed-by: Tobin C. Harding <me@tobin.cc>
> Not all of the patches in this series applied to my tree. Please fix up
> the ones I didn't apply and resend.
>
> thanks,
>
> greg k-h
You asked me to resend patches which didn't apply cleanly and I was not
sure if I have to resent v2 of all of them or only selected one.
I hope this time I did it right (I just send full set of v2).
Br,
Janusz Lisiecki
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t
2017-05-12 13:42 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
@ 2017-05-15 10:03 ` Greg Kroah-Hartman
0 siblings, 0 replies; 34+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-15 10:03 UTC (permalink / raw)
To: Janusz Lisiecki; +Cc: Linux Driver Project Developer List, Wolfram Sang
On Fri, May 12, 2017 at 03:42:36PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase fields of struct with underscores to comply
> with the standard kernel coding style
>
> Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
This patch, and your others in this series, do not apply at all to my
staging-testing branch, can you please rebase them against that branch
and resend them?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v3 0/2] Avoid CamelCases in ks7010 driver
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
` (7 preceding siblings ...)
2017-05-12 13:42 ` [PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
@ 2017-05-15 18:55 ` Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
` (2 more replies)
8 siblings, 3 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-15 18:55 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
---
v2:
- Rebased all patches to next-20170512. 2 and 8 should apply cleanly now
v3:
- Rebased all not yet applied patched to staging-testing branch
of gregkh/staging git (others from v1 and v2 are already there)
Janusz Lisiecki (2):
staging: ks7010: avoid CamelCase: receiveDTIMs
staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
drivers/staging/ks7010/ks_hostif.c | 59 +++++++++++++++++++-------------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 30 insertions(+), 31 deletions(-)
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-05-15 18:55 ` [PATCH v3 0/2] Avoid CamelCases in ks7010 driver Janusz Lisiecki
@ 2017-05-15 18:55 ` Janusz Lisiecki
2017-05-16 11:53 ` Greg Kroah-Hartman
2017-05-15 18:55 ` [PATCH v3 2/2] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-16 15:29 ` [PATCH v4 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2 siblings, 1 reply; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-15 18:55 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index caf2551..0f9a798 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1660,13 +1660,13 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
static
void hostif_power_mgmt_request(struct ks_wlan_private *priv,
- unsigned long mode, unsigned long wake_up,
- unsigned long receiveDTIMs)
+ unsigned long mode, unsigned long wake_up,
+ unsigned long receive_dtims)
{
struct hostif_power_mgmt_request_t *pp;
- DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
- receiveDTIMs);
+ DPRINTK(3, "mode=%lu wake_up=%lu receive_dtims=%lu\n", mode, wake_up,
+ receive_dtims);
pp = hostif_generic_request(sizeof(*pp), HIF_POWER_MGMT_REQ);
if (!pp)
@@ -1674,7 +1674,7 @@ void hostif_power_mgmt_request(struct ks_wlan_private *priv,
pp->mode = cpu_to_le32((uint32_t)mode);
pp->wake_up = cpu_to_le32((uint32_t)wake_up);
- pp->receiveDTIMs = cpu_to_le32((uint32_t)receiveDTIMs);
+ pp->receive_dtims = cpu_to_le32((uint32_t)receive_dtims);
/* send to device request */
ps_confirm_wait_inc(priv);
@@ -2218,44 +2218,44 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv)
static
void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
{
- unsigned long mode, wake_up, receiveDTIMs;
+ unsigned long mode, wake_up, receive_dtims;
DPRINTK(3, "\n");
switch (priv->reg.power_mgmt) {
case POWER_MGMT_ACTIVE:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
case POWER_MGMT_SAVE1:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
case POWER_MGMT_SAVE2:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 1;
+ receive_dtims = 1;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
default:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
}
- hostif_power_mgmt_request(priv, mode, wake_up, receiveDTIMs);
+ hostif_power_mgmt_request(priv, mode, wake_up, receive_dtims);
}
static
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 538600f..a148714 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -188,7 +188,7 @@ struct hostif_power_mgmt_request_t {
u32 wake_up;
#define SLEEP_FALSE 0
#define SLEEP_TRUE 1 /* not used */
- u32 receiveDTIMs;
+ u32 receive_dtims;
#define DTIM_FALSE 0
#define DTIM_TRUE 1
} __packed;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v3 2/2] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c
2017-05-15 18:55 ` [PATCH v3 0/2] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
@ 2017-05-15 18:55 ` Janusz Lisiecki
2017-05-16 15:29 ` [PATCH v4 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-15 18:55 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase local variables' name with underscores to comply
with the standard kernel coding style.
Changed:
- LinkSpeed
- TransmittedFrameCount
- ReceivedFragmentCount
- FailedCount
- FCSErrorCount
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 33 ++++++++++++++++-----------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 0f9a798..92ed175 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -994,22 +994,22 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv)
{
struct iw_statistics *wstats = &priv->wstats;
unsigned char rssi, signal, noise;
- unsigned char LinkSpeed;
- unsigned int TransmittedFrameCount, ReceivedFragmentCount;
- unsigned int FailedCount, FCSErrorCount;
+ unsigned char link_speed;
+ unsigned int transmitted_frame_count, received_fragment_count;
+ unsigned int failed_count, fcs_error_count;
DPRINTK(3, "\n");
rssi = get_BYTE(priv);
signal = get_BYTE(priv);
noise = get_BYTE(priv);
- LinkSpeed = get_BYTE(priv);
- TransmittedFrameCount = get_DWORD(priv);
- ReceivedFragmentCount = get_DWORD(priv);
- FailedCount = get_DWORD(priv);
- FCSErrorCount = get_DWORD(priv);
+ link_speed = get_BYTE(priv);
+ transmitted_frame_count = get_DWORD(priv);
+ received_fragment_count = get_DWORD(priv);
+ failed_count = get_DWORD(priv);
+ fcs_error_count = get_DWORD(priv);
DPRINTK(4, "phyinfo confirm rssi=%d signal=%d\n", rssi, signal);
- priv->current_rate = (LinkSpeed & RATE_MASK);
+ priv->current_rate = (link_speed & RATE_MASK);
wstats->qual.qual = signal;
wstats->qual.level = 256 - rssi;
wstats->qual.noise = 0; /* invalid noise value */
@@ -1017,14 +1017,13 @@ void hostif_phy_information_confirm(struct ks_wlan_private *priv)
DPRINTK(3, "\n rssi=%u\n"
" signal=%u\n"
- " LinkSpeed=%ux500Kbps\n"
- " TransmittedFrameCount=%u\n"
- " ReceivedFragmentCount=%u\n"
- " FailedCount=%u\n"
- " FCSErrorCount=%u\n",
- rssi, signal, LinkSpeed, TransmittedFrameCount,
- ReceivedFragmentCount, FailedCount, FCSErrorCount);
-
+ " link_speed=%ux500Kbps\n"
+ " transmitted_frame_count=%u\n"
+ " received_fragment_count=%u\n"
+ " failed_count=%u\n"
+ " fcs_error_count=%u\n",
+ rssi, signal, link_speed, transmitted_frame_count,
+ received_fragment_count, failed_count, fcs_error_count);
/* wake_up_interruptible_all(&priv->confirm_wait); */
complete(&priv->confirm_wait);
}
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-05-15 18:55 ` [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
@ 2017-05-16 11:53 ` Greg Kroah-Hartman
0 siblings, 0 replies; 34+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-16 11:53 UTC (permalink / raw)
To: Janusz Lisiecki; +Cc: Linux Driver Project Developer List, Wolfram Sang
On Mon, May 15, 2017 at 08:55:45PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase variable name with underscores to comply
> with the standard kernel coding style.
>
> Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
> ---
> drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
> drivers/staging/ks7010/ks_hostif.h | 2 +-
> 2 files changed, 14 insertions(+), 14 deletions(-)
This doesn't apply to my tree at all :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v4 0/1] Avoid CamelCases in ks7010 driver
2017-05-15 18:55 ` [PATCH v3 0/2] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 2/2] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
@ 2017-05-16 15:29 ` Janusz Lisiecki
2017-05-16 15:29 ` [PATCH v4 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-16 15:34 ` [PATCH v5 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2 siblings, 2 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-16 15:29 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
---
v2:
- Rebased all patches to next-20170512. 2 and 8 should apply cleanly now
v3:
- Rebased all not yet applied patched to staging-testing branch
of gregkh/staging git (others from v1 and v2 are already there)
v4:
- Rebased remaing patch to staging-testing branch of gregkh/staging git
Janusz Lisiecki (1):
staging: ks7010: avoid CamelCase: receiveDTIMs
drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v4 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-05-16 15:29 ` [PATCH v4 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
@ 2017-05-16 15:29 ` Janusz Lisiecki
2017-05-16 15:34 ` [PATCH v5 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
1 sibling, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-16 15:29 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Conflicts:
drivers/staging/ks7010/ks_hostif.h
---
drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index d9161be..79634be 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1659,13 +1659,13 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
static
void hostif_power_mgmt_request(struct ks_wlan_private *priv,
- unsigned long mode, unsigned long wake_up,
- unsigned long receiveDTIMs)
+ unsigned long mode, unsigned long wake_up,
+ unsigned long receive_dtims)
{
struct hostif_power_mgmt_request_t *pp;
- DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
- receiveDTIMs);
+ DPRINTK(3, "mode=%lu wake_up=%lu receive_dtims=%lu\n", mode, wake_up,
+ receive_dtims);
pp = hostif_generic_request(sizeof(*pp), HIF_POWER_MGMT_REQ);
if (!pp)
@@ -1673,7 +1673,7 @@ void hostif_power_mgmt_request(struct ks_wlan_private *priv,
pp->mode = cpu_to_le32((uint32_t)mode);
pp->wake_up = cpu_to_le32((uint32_t)wake_up);
- pp->receiveDTIMs = cpu_to_le32((uint32_t)receiveDTIMs);
+ pp->receive_dtims = cpu_to_le32((uint32_t)receive_dtims);
/* send to device request */
ps_confirm_wait_inc(priv);
@@ -2217,44 +2217,44 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv)
static
void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
{
- unsigned long mode, wake_up, receiveDTIMs;
+ unsigned long mode, wake_up, receive_dtims;
DPRINTK(3, "\n");
switch (priv->reg.power_mgmt) {
case POWER_MGMT_ACTIVE:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
case POWER_MGMT_SAVE1:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
case POWER_MGMT_SAVE2:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 1;
+ receive_dtims = 1;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
default:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
}
- hostif_power_mgmt_request(priv, mode, wake_up, receiveDTIMs);
+ hostif_power_mgmt_request(priv, mode, wake_up, receive_dtims);
}
static
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 45e3a01..5bae8d4 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -188,7 +188,7 @@ struct hostif_power_mgmt_request_t {
__le32 wake_up;
#define SLEEP_FALSE 0
#define SLEEP_TRUE 1 /* not used */
- __le32 receiveDTIMs;
+ __le32 receive_dtims;
#define DTIM_FALSE 0
#define DTIM_TRUE 1
} __packed;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH v5 0/1] Avoid CamelCases in ks7010 driver
2017-05-16 15:29 ` [PATCH v4 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-16 15:29 ` [PATCH v4 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
@ 2017-05-16 15:34 ` Janusz Lisiecki
2017-05-16 15:34 ` [PATCH v5 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
1 sibling, 1 reply; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-16 15:34 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
---
v2:
- Rebased all patches to next-20170512. 2 and 8 should apply cleanly now
v3:
- Rebased all not yet applied patched to staging-testing branch
of gregkh/staging git (others from v1 and v2 are already there)
v4:
- Rebased remaing patch to staging-testing branch of gregkh/staging git
v5:
- Fixed commit message
Janusz Lisiecki (1):
staging: ks7010: avoid CamelCase: receiveDTIMs
drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH v5 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs
2017-05-16 15:34 ` [PATCH v5 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
@ 2017-05-16 15:34 ` Janusz Lisiecki
0 siblings, 0 replies; 34+ messages in thread
From: Janusz Lisiecki @ 2017-05-16 15:34 UTC (permalink / raw)
To: Wolfram Sang
Cc: Greg Kroah-Hartman, Linux Driver Project Developer List, Janusz Lisiecki
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 26 +++++++++++++-------------
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index d9161be..79634be 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1659,13 +1659,13 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
static
void hostif_power_mgmt_request(struct ks_wlan_private *priv,
- unsigned long mode, unsigned long wake_up,
- unsigned long receiveDTIMs)
+ unsigned long mode, unsigned long wake_up,
+ unsigned long receive_dtims)
{
struct hostif_power_mgmt_request_t *pp;
- DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
- receiveDTIMs);
+ DPRINTK(3, "mode=%lu wake_up=%lu receive_dtims=%lu\n", mode, wake_up,
+ receive_dtims);
pp = hostif_generic_request(sizeof(*pp), HIF_POWER_MGMT_REQ);
if (!pp)
@@ -1673,7 +1673,7 @@ void hostif_power_mgmt_request(struct ks_wlan_private *priv,
pp->mode = cpu_to_le32((uint32_t)mode);
pp->wake_up = cpu_to_le32((uint32_t)wake_up);
- pp->receiveDTIMs = cpu_to_le32((uint32_t)receiveDTIMs);
+ pp->receive_dtims = cpu_to_le32((uint32_t)receive_dtims);
/* send to device request */
ps_confirm_wait_inc(priv);
@@ -2217,44 +2217,44 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv)
static
void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)
{
- unsigned long mode, wake_up, receiveDTIMs;
+ unsigned long mode, wake_up, receive_dtims;
DPRINTK(3, "\n");
switch (priv->reg.power_mgmt) {
case POWER_MGMT_ACTIVE:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
case POWER_MGMT_SAVE1:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
case POWER_MGMT_SAVE2:
if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
mode = POWER_SAVE;
wake_up = 0;
- receiveDTIMs = 1;
+ receive_dtims = 1;
} else {
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
}
break;
default:
mode = POWER_ACTIVE;
wake_up = 0;
- receiveDTIMs = 0;
+ receive_dtims = 0;
break;
}
- hostif_power_mgmt_request(priv, mode, wake_up, receiveDTIMs);
+ hostif_power_mgmt_request(priv, mode, wake_up, receive_dtims);
}
static
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 45e3a01..5bae8d4 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -188,7 +188,7 @@ struct hostif_power_mgmt_request_t {
__le32 wake_up;
#define SLEEP_FALSE 0
#define SLEEP_TRUE 1 /* not used */
- __le32 receiveDTIMs;
+ __le32 receive_dtims;
#define DTIM_FALSE 0
#define DTIM_TRUE 1
} __packed;
--
1.9.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 34+ messages in thread
end of thread, other threads:[~2017-05-16 18:59 UTC | newest]
Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
2017-05-07 3:37 ` Greg Kroah-Hartman
2017-05-12 13:46 ` Janusz Lisiecki
2017-05-07 7:03 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-12 9:10 ` Greg Kroah-Hartman
2017-04-29 20:58 ` [PATCH 2/8] " Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
2017-04-30 8:59 ` Tobin C. Harding
2017-04-29 20:58 ` [PATCH 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-07 7:07 ` [PATCH v2 " Janusz Lisiecki
2017-04-30 9:01 ` [PATCH 0/8] Avoid CamelCases in ks7010 driver Tobin C. Harding
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
2017-05-15 10:03 ` Greg Kroah-Hartman
2017-05-12 13:42 ` [PATCH v2 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
2017-05-12 13:42 ` [PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 0/2] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-15 18:55 ` [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-16 11:53 ` Greg Kroah-Hartman
2017-05-15 18:55 ` [PATCH v3 2/2] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-16 15:29 ` [PATCH v4 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-16 15:29 ` [PATCH v4 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-16 15:34 ` [PATCH v5 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-16 15:34 ` [PATCH v5 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.