* [PATCH 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong
@ 2017-06-29 10:25 Jaya Durga
2017-06-29 12:31 ` Frans Klaver
0 siblings, 1 reply; 2+ messages in thread
From: Jaya Durga @ 2017-06-29 10:25 UTC (permalink / raw)
To: gregkh
Cc: sergio.paracuellos, juliana.orod, devel, linux-kernel,
Jaya Durga, Jaya Durga
Fix checkpatch.pl issue
WARNING: Use of volatile is usually wrong:
see Documentation/process/volatile-considered-harmful.rst
Signed-off-by: Jaya Durga <jayad@cdac.in>
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 310e2c4..015945f 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {
enum ctlx_state state; /* Tracks running state */
struct completion done;
- volatile int reapable; /* Food for the reaper task */
+ int reapable; /* Food for the reaper task */
ctlx_cmdcb_t cmdcb; /* Async command callback */
ctlx_usercb_t usercb; /* Async user callback, */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong
2017-06-29 10:25 [PATCH 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong Jaya Durga
@ 2017-06-29 12:31 ` Frans Klaver
0 siblings, 0 replies; 2+ messages in thread
From: Frans Klaver @ 2017-06-29 12:31 UTC (permalink / raw)
To: Jaya Durga
Cc: Greg KH, driverdevel, Jaya Durga, juliana.orod, linux-kernel,
sergio.paracuellos
On Thu, Jun 29, 2017 at 12:25 PM, Jaya Durga <rjdurga@gmail.com> wrote:
> Fix checkpatch.pl issue
> WARNING: Use of volatile is usually wrong:
> see Documentation/process/volatile-considered-harmful.rst
Now I've only had a very quick look at the code using this. Could you
elaborate on why just removing the volatile keyword is enough, and
that this isn't related to some smelly bit of code that should be
implemented differently?
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 310e2c4..015945f 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> - volatile int reapable; /* Food for the reaper task */
> + int reapable; /* Food for the reaper task */
>
> ctlx_cmdcb_t cmdcb; /* Async command callback */
> ctlx_usercb_t usercb; /* Async user callback, */
> --
> 1.9.1
Frans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-29 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 10:25 [PATCH 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong Jaya Durga
2017-06-29 12:31 ` Frans Klaver
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.