From: Sricharan R <sricharan@codeaurora.org> To: ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sricharan@codeaurora.org Subject: [PATCH v2 20/20] rpmsg: glink: Handle remote rx done command Date: Thu, 24 Aug 2017 12:51:42 +0530 [thread overview] Message-ID: <1503559302-3744-21-git-send-email-sricharan@codeaurora.org> (raw) In-Reply-To: <1503559302-3744-1-git-send-email-sricharan@codeaurora.org> Once the remote side sends a rx done ack, check for the intent reuse information from it and suitably discard or reuse the remote passed intent buffers. Signed-off-by: Sricharan R <sricharan@codeaurora.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/rpmsg/qcom_glink_native.c | 42 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 54ddb66..08953ca 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -657,6 +657,40 @@ static int qcom_glink_advertise_intent(struct qcom_glink *glink, return intent; } +static void qcom_glink_handle_rx_done(struct qcom_glink *glink, + u32 cid, uint32_t iid, + bool reuse) +{ + struct glink_core_rx_intent *intent; + struct glink_channel *channel; + unsigned long flags; + + spin_lock_irqsave(&glink->idr_lock, flags); + channel = idr_find(&glink->rcids, cid); + spin_unlock_irqrestore(&glink->idr_lock, flags); + if (!channel) { + dev_err(glink->dev, "invalid channel id received\n"); + return; + } + + spin_lock_irqsave(&channel->intent_lock, flags); + intent = idr_find(&channel->riids, iid); + + if (!intent) { + spin_unlock_irqrestore(&channel->intent_lock, flags); + dev_err(glink->dev, "invalid intent id received\n"); + return; + } + + intent->in_use = false; + + if (!reuse) { + idr_remove(&channel->riids, intent->id); + kfree(intent); + } + spin_unlock_irqrestore(&channel->intent_lock, flags); +} + /** * qcom_glink_handle_intent_req() - Receive a request for rx_intent * from remote side @@ -965,6 +999,14 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data) case RPM_CMD_INTENT: qcom_glink_handle_intent(glink, param1, param2, avail); break; + case RPM_CMD_RX_DONE: + qcom_glink_handle_rx_done(glink, param1, param2, false); + qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); + break; + case RPM_CMD_RX_DONE_W_REUSE: + qcom_glink_handle_rx_done(glink, param1, param2, true); + qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); + break; case RPM_CMD_RX_INTENT_REQ_ACK: qcom_glink_handle_intent_req_ack(glink, param1, param2); qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sricharan@codeaurora.org (Sricharan R) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 20/20] rpmsg: glink: Handle remote rx done command Date: Thu, 24 Aug 2017 12:51:42 +0530 [thread overview] Message-ID: <1503559302-3744-21-git-send-email-sricharan@codeaurora.org> (raw) In-Reply-To: <1503559302-3744-1-git-send-email-sricharan@codeaurora.org> Once the remote side sends a rx done ack, check for the intent reuse information from it and suitably discard or reuse the remote passed intent buffers. Signed-off-by: Sricharan R <sricharan@codeaurora.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/rpmsg/qcom_glink_native.c | 42 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 54ddb66..08953ca 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -657,6 +657,40 @@ static int qcom_glink_advertise_intent(struct qcom_glink *glink, return intent; } +static void qcom_glink_handle_rx_done(struct qcom_glink *glink, + u32 cid, uint32_t iid, + bool reuse) +{ + struct glink_core_rx_intent *intent; + struct glink_channel *channel; + unsigned long flags; + + spin_lock_irqsave(&glink->idr_lock, flags); + channel = idr_find(&glink->rcids, cid); + spin_unlock_irqrestore(&glink->idr_lock, flags); + if (!channel) { + dev_err(glink->dev, "invalid channel id received\n"); + return; + } + + spin_lock_irqsave(&channel->intent_lock, flags); + intent = idr_find(&channel->riids, iid); + + if (!intent) { + spin_unlock_irqrestore(&channel->intent_lock, flags); + dev_err(glink->dev, "invalid intent id received\n"); + return; + } + + intent->in_use = false; + + if (!reuse) { + idr_remove(&channel->riids, intent->id); + kfree(intent); + } + spin_unlock_irqrestore(&channel->intent_lock, flags); +} + /** * qcom_glink_handle_intent_req() - Receive a request for rx_intent * from remote side @@ -965,6 +999,14 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data) case RPM_CMD_INTENT: qcom_glink_handle_intent(glink, param1, param2, avail); break; + case RPM_CMD_RX_DONE: + qcom_glink_handle_rx_done(glink, param1, param2, false); + qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); + break; + case RPM_CMD_RX_DONE_W_REUSE: + qcom_glink_handle_rx_done(glink, param1, param2, true); + qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); + break; case RPM_CMD_RX_INTENT_REQ_ACK: qcom_glink_handle_intent_req_ack(glink, param1, param2); qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2017-08-24 7:21 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-24 7:21 [PATCH v2 00/20] rpmsg: glink: Add glink smem based transport Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-24 7:21 ` [PATCH v2 01/20] rpmsg: glink: Rename glink_rpm_xx functions to qcom_glink_xx Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:42 ` Arun Kumar Neelakantam 2017-08-28 11:42 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 02/20] rpmsg: glink: Associate indirections for pipe fifo accessor's Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:44 ` Arun Kumar Neelakantam 2017-08-28 11:44 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 03/20] rpmsg: glink: Split rpm_probe to reuse the common code Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:44 ` Arun Kumar Neelakantam 2017-08-28 11:44 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 04/20] rpmsg: glink: Move the common glink protocol implementation to glink_native.c Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:45 ` Arun Kumar Neelakantam 2017-08-28 11:45 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 05/20] rpmsg: glink: Allow unaligned data access Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:46 ` Arun Kumar Neelakantam 2017-08-28 11:46 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 06/20] rpmsg: glink: Return -EAGAIN when there is no FIFO space Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:47 ` Arun Kumar Neelakantam 2017-08-28 11:47 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 07/20] rpmsg: glink: Do a mbox_free_channel in remove Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:47 ` Arun Kumar Neelakantam 2017-08-28 11:47 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 08/20] rpmsg: glink: Introduce glink smem based transport Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:48 ` Arun Kumar Neelakantam 2017-08-28 11:48 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 09/20] rpmsg: glink: Fix default case while handling received commands Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:48 ` Arun Kumar Neelakantam 2017-08-28 11:48 ` Arun Kumar Neelakantam 2017-08-29 20:57 ` Bjorn Andersson 2017-08-29 20:57 ` Bjorn Andersson 2017-08-24 7:21 ` [PATCH v2 10/20] rpmsg: glink: Add support for transport version negotiation Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:48 ` Arun Kumar Neelakantam 2017-08-28 11:48 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 11/20] rpmsg: glink: Fix idr_lock from mutex to spinlock Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:49 ` Arun Kumar Neelakantam 2017-08-28 11:49 ` Arun Kumar Neelakantam 2017-08-28 21:51 ` Chris Lew 2017-08-28 21:51 ` Chris Lew 2017-08-28 23:13 ` Sricharan R 2017-08-28 23:13 ` Sricharan R 2017-08-24 7:21 ` [PATCH v2 12/20] rpmsg: glink: Add support for TX intents Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:49 ` Arun Kumar Neelakantam 2017-08-28 11:49 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 13/20] rpmsg: glink: Use the local intents when receiving data Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:49 ` Arun Kumar Neelakantam 2017-08-28 11:49 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 14/20] rpmsg: glink: Make RX FIFO peak accessor to take an offset Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:50 ` Arun Kumar Neelakantam 2017-08-28 11:50 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 15/20] rpmsg: glink: Add rx done command Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:50 ` Arun Kumar Neelakantam 2017-08-28 11:50 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 16/20] rpmsg: glink: Add announce_create ops and preallocate intents Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:50 ` Arun Kumar Neelakantam 2017-08-28 11:50 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 17/20] rpmsg: glink: Receive and store the remote intent buffers Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-28 11:51 ` Arun Kumar Neelakantam 2017-08-28 11:51 ` Arun Kumar Neelakantam 2017-08-24 7:21 ` [PATCH v2 18/20] rpmsg: glink: Use the intents passed by remote Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-24 7:21 ` [PATCH v2 19/20] rpmsg: glink: Request for intents when unavailable Sricharan R 2017-08-24 7:21 ` Sricharan R 2017-08-24 7:21 ` Sricharan R [this message] 2017-08-24 7:21 ` [PATCH v2 20/20] rpmsg: glink: Handle remote rx done command Sricharan R
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1503559302-3744-21-git-send-email-sricharan@codeaurora.org \ --to=sricharan@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=ohad@wizery.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.