* [PATCH] tests: report if a test is taking a long time
@ 2017-08-26 5:19 Andreas Dilger
2017-08-30 6:07 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Dilger @ 2017-08-26 5:19 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Andreas Dilger
Print out a message if a test takes longer than 60s, with a
reminder to potentially add is_slow_test to that test, so
that it is easier to find which tests are taking a long time,
especially if running with "make -j check" or similar.
Add an exclusion for r_expand_full on MacOS since HFS+ does
not support sparse devices and doesn't like large test images.
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
---
tests/r_expand_full/script | 6 ++++++
tests/test_one.in | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/tests/r_expand_full/script b/tests/r_expand_full/script
index a2c09db..2fd4461 100644
--- a/tests/r_expand_full/script
+++ b/tests/r_expand_full/script
@@ -23,6 +23,12 @@ cat > $CONF << ENDL
}
ENDL
+if [ $(uname -s) = "Darwin" ]; then
+ # creates a 786MB filesystem
+ echo "$test_name: $DESCRIPTION: skipped for HFS+ (no sparse files)"
+ return 0
+fi
+
echo "resize2fs test" > $OUT
MKE2FS_CONFIG=$CONF $MKE2FS -F -T ext4h $TMPFILE 786432 >> $OUT 2>&1
diff --git a/tests/test_one.in b/tests/test_one.in
index 35465b6..d046380 100644
--- a/tests/test_one.in
+++ b/tests/test_one.in
@@ -61,6 +61,7 @@ fi
rm -f $test_name.ok $test_name.failed
#echo -e -n "$test_name: $test_description:\r"
+start=$SECONDS
if [ -f $test_dir/script ]; then
. $test_dir/script
else
@@ -72,6 +73,11 @@ else
echo "$test_name: Missing test script $default_script!"
fi
fi
+elapsed=$((SECONDS - start))
+if [ $elapsed -gt 60 -a ! -f $test_dir/is_slow_test ]; then
+ echo "$test_name: *** took $elapsed seconds to finish ***"
+ echo "$test_name: consider adding $test_dir/is_slow_test"
+fi
if [ "$SKIP_UNLINK" != "true" ] ; then
rm -f $TMPFILE
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: tests: report if a test is taking a long time
2017-08-26 5:19 [PATCH] tests: report if a test is taking a long time Andreas Dilger
@ 2017-08-30 6:07 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-08-30 6:07 UTC (permalink / raw)
To: Andreas Dilger; +Cc: linux-ext4
On Fri, Aug 25, 2017 at 11:19:48PM -0600, Andreas Dilger wrote:
> Print out a message if a test takes longer than 60s, with a
> reminder to potentially add is_slow_test to that test, so
> that it is easier to find which tests are taking a long time,
> especially if running with "make -j check" or similar.
>
> Add an exclusion for r_expand_full on MacOS since HFS+ does
> not support sparse devices and doesn't like large test images.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-30 6:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-26 5:19 [PATCH] tests: report if a test is taking a long time Andreas Dilger
2017-08-30 6:07 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.