[PATCH] simutil: Made UMTS/GSM authenticate more consitent

[PATCH] simutil: Made UMTS/GSM authenticate more consitent

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

The Le parameter in the AUTHENTICATE command was not being
set for GSM authentication. This did work, but explicitly
setting it to 0 as UMTS does was more consitent.
---
 src/simutil.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/simutil.c b/src/simutil.c
index 2f49500..c25b3a8 100644
--- a/src/simutil.c
+++ b/src/simutil.c
@@ -1628,9 +1628,10 @@ static int build_authenticate(unsigned char *buffer, const unsigned char *rand,
 		buffer[pos++] = 0x10;
 		memcpy(buffer + pos, autn, 16);
 		pos += 16;
-		buffer[pos++] = 0x00;
 	}
 
+	buffer[pos++] = 0x00;
+
 	return pos;
 }
 
-- 
2.7.4

Re: [PATCH] simutil: Made UMTS/GSM authenticate more consitent

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi James,

On 11/01/2017 12:32 PM, James Prestwood wrote:
> The Le parameter in the AUTHENTICATE command was not being
> set for GSM authentication. This did work, but explicitly
> setting it to 0 as UMTS does was more consitent.
> ---
>   src/simutil.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis