From: <Mario.Limonciello@dell.com>
To: <luto@amacapital.net>
Cc: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>,
<linux-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <luto@kernel.org>
Subject: Re: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device
Date: Sat, 9 Dec 2017 03:41:00 +0000 [thread overview]
Message-ID: <1512790860266.96149@Dell.com> (raw)
In-Reply-To: <DDE9D9EA-D55D-41CC-94ED-EB2A590B7BCF@amacapital.net>
>> On Dec 8, 2017, at 6:34 PM, Mario Limonciello <mario.limonciello@dell.com> wrote:
>>
>> It's possible for the same GUID to show up on as system twice.
>> This means using solely the GUID for identify the file will not
>> be sufficient.
>
>Isn't the file already in a per-bus directory?
Yep, but the symlink created in /sys/bus/wmi/devices isn't.
That's where the kernel complains about duplicate sysfs
attributes.
It's not exactly a pretty path I submitted, but it does avoid
those collisions.
Example (with this in place from /sys/bus/wmi/devices):
lrwxrwxrwx 1 root root 0 Dec 8 21:39 PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A -> ../../../devices/platform/PNP0C14:04/wmi_bus/wmi_bus-PNP0C14:04/PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A
WARNING: multiple messages have this Message-ID (diff)
From: <Mario.Limonciello@dell.com>
To: luto@amacapital.net
Cc: dvhart@infradead.org, andy.shevchenko@gmail.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, luto@kernel.org
Subject: Re: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device
Date: Sat, 9 Dec 2017 03:41:00 +0000 [thread overview]
Message-ID: <1512790860266.96149@Dell.com> (raw)
In-Reply-To: <DDE9D9EA-D55D-41CC-94ED-EB2A590B7BCF@amacapital.net>
>> On Dec 8, 2017, at 6:34 PM, Mario Limonciello <mario.limonciello@dell.com> wrote:
>>
>> It's possible for the same GUID to show up on as system twice.
>> This means using solely the GUID for identify the file will not
>> be sufficient.
>
>Isn't the file already in a per-bus directory?
Yep, but the symlink created in /sys/bus/wmi/devices isn't.
That's where the kernel complains about duplicate sysfs
attributes.
It's not exactly a pretty path I submitted, but it does avoid
those collisions.
Example (with this in place from /sys/bus/wmi/devices):
lrwxrwxrwx 1 root root 0 Dec 8 21:39 PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A -> ../../../devices/platform/PNP0C14:04/wmi_bus/wmi_bus-PNP0C14:04/PNP0C14:04-70FE8229-D03B-4214-A1C6-1F884B1A892A
next prev parent reply other threads:[~2017-12-09 3:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 2:34 [PATCH 0/2] Parse multiple duplicate WMI GUIDs Mario Limonciello
2017-12-09 2:34 ` [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device Mario Limonciello
2017-12-09 2:52 ` Andy Lutomirski
2017-12-09 3:41 ` Mario.Limonciello [this message]
2017-12-09 3:41 ` Mario.Limonciello
2017-12-09 21:32 ` Andy Lutomirski
2018-07-06 23:00 ` Darren Hart
2018-11-29 0:22 ` Darren Hart
2017-12-09 2:34 ` [PATCH 2/2] platform/x86: wmi: Allow creating WMI devices with the same GUID Mario Limonciello
2017-12-09 20:43 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512790860266.96149@Dell.com \
--to=mario.limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.