All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jia He <hejianet@gmail.com>
To: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Jianbo Liu <jianbo.liu@arm.com>,
	Jan Viktorin <viktorin@rehivetech.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	konstantin.ananyev@intel.com, hemant.agrawal@nxp.com,
	Jia He <hejianet@gmail.com>, Jia He <jia.he@hxt-semitech.com>
Subject: [PATCH v8 1/3] eal/arm64: remove the braces {} for dmb() and dsb()
Date: Tue, 16 Jan 2018 20:03:49 -0800	[thread overview]
Message-ID: <1516161831-28719-2-git-send-email-hejianet@gmail.com> (raw)
In-Reply-To: <1516161831-28719-1-git-send-email-hejianet@gmail.com>

for the code as follows:
if (condition)
	rte_smp_rmb();
else
	rte_smp_wmb();
Without this patch, compiler will report this error:
error: 'else' without a previous 'if'

Fixes: 84733fd0d75e ("eal/arm64: fix memory barrier definition")
Signed-off-by: Jia He <jia.he@hxt-semitech.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
index b6bbd0b..10ccf14 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h
@@ -15,8 +15,8 @@ extern "C" {
 
 #include "generic/rte_atomic.h"
 
-#define dsb(opt)  { asm volatile("dsb " #opt : : : "memory"); }
-#define dmb(opt)  { asm volatile("dmb " #opt : : : "memory"); }
+#define dsb(opt) asm volatile("dsb " #opt : : : "memory")
+#define dmb(opt) asm volatile("dmb " #opt : : : "memory")
 
 #define rte_mb() dsb(sy)
 
-- 
2.7.4

  reply	other threads:[~2018-01-17  4:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17  4:03 [PATCH v8 0/3] support c11 memory model barrier in librte_ring Jia He
2018-01-17  4:03 ` Jia He [this message]
2018-01-17  4:03 ` [PATCH v8 2/3] ring: introduce new header file to include common functions Jia He
2018-01-19 14:15   ` Hemant Agrawal
2018-01-19 16:38     ` Olivier Matz
2018-01-19 16:47       ` Hemant Agrawal
2018-01-22  1:53         ` Jia He
     [not found]           ` <60d7010d-caf8-8ade-a34c-7e284842cded@nxp.com>
2018-01-22  6:18             ` Jia He
2018-01-22 16:54         ` Stephen Hemminger
2018-01-17  4:03 ` [PATCH v8 3/3] ring: introduce new header file to support C11 memory model Jia He
2018-01-17  8:24   ` Thomas Monjalon
2018-01-17  8:47     ` Jia He
2018-01-17  9:09       ` Thomas Monjalon
2018-01-18 23:52         ` Thomas Monjalon
2018-01-19  2:22           ` Jia He
2018-01-19 15:04           ` Hemant Agrawal
2018-01-19 14:25       ` Hemant Agrawal
2018-01-22  4:41 ` [PATCH v9 0/3] support c11 memory model barrier in librte_ring Jia He
2018-01-22  4:41   ` [PATCH v9 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2018-01-22  4:41   ` [PATCH v9 2/3] ring: introduce new header file to include common functions Jia He
2018-01-22  4:41   ` [PATCH v9 3/3] ring: introduce new header file to support C11 memory model Jia He
2018-01-22  7:53   ` [PATCH v9 0/3] support c11 memory model barrier in librte_ring Thomas Monjalon
2018-01-22  8:26     ` Olivier Matz
2018-01-22  8:29       ` Olivier Matz
2018-01-22  8:40     ` Hemant Agrawal
2018-01-29 15:11   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516161831-28719-2-git-send-email-hejianet@gmail.com \
    --to=hejianet@gmail.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jia.he@hxt-semitech.com \
    --cc=jianbo.liu@arm.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.