All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	Jia He <hejianet@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"Thomas Monjalon" <thomas@monjalon.net>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Jianbo Liu <jianbo.liu@arm.com>,
	Jan Viktorin <viktorin@rehivetech.com>,
	"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	Jia He <jia.he@hxt-semitech.com>
Subject: Re: [PATCH v8 2/3] ring: introduce new header file to include common functions
Date: Mon, 22 Jan 2018 08:54:03 -0800	[thread overview]
Message-ID: <20180122085403.4de6d399@xeon-e3> (raw)
In-Reply-To: <AM2PR04MB0753DC7A507FE7A967EE515689EF0@AM2PR04MB0753.eurprd04.prod.outlook.com>

On Fri, 19 Jan 2018 16:47:36 +0000
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> Hi Olivier,
> 
> > On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote:  
> > > Hi Jia,
> > >
> > > On 1/17/2018 9:33 AM, Jia He wrote:  
> > > > Move the common part of rte_ring.h into rte_ring_generic.h.
> > > > Move the memory barrier part into update_tail().
> > > >
> > > > No functional changes here.
> > > >
> > > > Signed-off-by: Jia He <jia.he@hxt-semitech.com>
> > > > Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > Suggested-by: Ananyev Konstantin <konstantin.ananyev@intel.com>
> > > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> > > > ---
> > > > diff --git a/lib/librte_ring/rte_ring_generic.h
> > > > b/lib/librte_ring/rte_ring_generic.h
> > > > new file mode 100644
> > > > index 0000000..01f2cae
> > > > --- /dev/null
> > > > +++ b/lib/librte_ring/rte_ring_generic.h
> > > > @@ -0,0 +1,202 @@
> > > > +/*-
> > > > + *   Copyright(c) 2017 Intel Corporation. All rights reserved.
> > > > + *   All rights reserved.
> > > > + *
> > > > + *   SPDX-License-Identifier: BSD-3-Clause  
> > >
> > > The SPDX should be first line. See other files for Intel or NXP.  
> 
> [Hemant] Don't add SPDX to this file. 
>  This file is not BSD-3 licensed.  Please keep the full text as in the original file.


If it can't be BSD-3 licensed, then it needs to be removed. Mixing licenses is a real problem

  parent reply	other threads:[~2018-01-22 16:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17  4:03 [PATCH v8 0/3] support c11 memory model barrier in librte_ring Jia He
2018-01-17  4:03 ` [PATCH v8 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2018-01-17  4:03 ` [PATCH v8 2/3] ring: introduce new header file to include common functions Jia He
2018-01-19 14:15   ` Hemant Agrawal
2018-01-19 16:38     ` Olivier Matz
2018-01-19 16:47       ` Hemant Agrawal
2018-01-22  1:53         ` Jia He
     [not found]           ` <60d7010d-caf8-8ade-a34c-7e284842cded@nxp.com>
2018-01-22  6:18             ` Jia He
2018-01-22 16:54         ` Stephen Hemminger [this message]
2018-01-17  4:03 ` [PATCH v8 3/3] ring: introduce new header file to support C11 memory model Jia He
2018-01-17  8:24   ` Thomas Monjalon
2018-01-17  8:47     ` Jia He
2018-01-17  9:09       ` Thomas Monjalon
2018-01-18 23:52         ` Thomas Monjalon
2018-01-19  2:22           ` Jia He
2018-01-19 15:04           ` Hemant Agrawal
2018-01-19 14:25       ` Hemant Agrawal
2018-01-22  4:41 ` [PATCH v9 0/3] support c11 memory model barrier in librte_ring Jia He
2018-01-22  4:41   ` [PATCH v9 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2018-01-22  4:41   ` [PATCH v9 2/3] ring: introduce new header file to include common functions Jia He
2018-01-22  4:41   ` [PATCH v9 3/3] ring: introduce new header file to support C11 memory model Jia He
2018-01-22  7:53   ` [PATCH v9 0/3] support c11 memory model barrier in librte_ring Thomas Monjalon
2018-01-22  8:26     ` Olivier Matz
2018-01-22  8:29       ` Olivier Matz
2018-01-22  8:40     ` Hemant Agrawal
2018-01-29 15:11   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122085403.4de6d399@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=hejianet@gmail.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jia.he@hxt-semitech.com \
    --cc=jianbo.liu@arm.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.