All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: peter enderborg <peter.enderborg@sony.com>,
	selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2 1/5] selinux:Remove direct references to policydb.
Date: Thu, 01 Feb 2018 10:28:41 -0500	[thread overview]
Message-ID: <1517498921.1750.27.camel@tycho.nsa.gov> (raw)
In-Reply-To: <4c41ad02-5370-95bc-51e4-992767768559@sony.com>

On Thu, 2018-02-01 at 16:17 +0100, peter enderborg wrote:
> On 01/30/2018 02:46 PM, Stephen Smalley wrote:
> > On Fri, 2018-01-26 at 15:32 +0100, peter.enderborg@sony.com wrote:
> > > From: Peter Enderborg <peter.enderborg@sony.com>
> > > 
> > > To be able to use rcu locks we seed to address the policydb
> > > though a pointer. This preparation removes the export of the
> > > policydb and send pointers to it through parameter agruments.
> > 
> > Just for reference, I have a patch series that does this not only
> > for
> > the policydb, sidtab, and class/perm mapping, but for all of the
> > SELinux global state, see:
> > https://github.com/stephensmalley/selinux-kernel/tree/selinuxns
> > and in particular
> > https://github.com/stephensmalley/selinux-kernel/commit/c10d90b43cd
> > 720c8f8aab51007e805bf7c4f10d2
> > https://github.com/stephensmalley/selinux-kernel/commit/ec038a64173
> > d56a331423b6d1564b801f0915afc
> > https://github.com/stephensmalley/selinux-kernel/commit/97aa5d7a05e
> > 4458bc4562c47d8f7bc4f56fbfefd
> > 
> > Those first three patches should have no effect on SELinux
> > behavior.
> > They need to be re-based to latest selinux next branch (some minor
> > conflict resolution required) but I was waiting for that to advance
> > to
> > something 4.15-rcX based.  I could however re-base it now if
> > desired.
> 
> I read that as that you want me to rebase the patches on that tree?
> Seems to
> be partly prepared but lot of changes.  Is it a moving target?

No, I wouldn't re-base on that tree.  If/when Paul updates the selinux
next branch (which should be what your patches are relative to), then I
will re-base my patches on his branch and re-submit the first few
patches to see if we can get those merged now since they don't change
SELinux behavior or interfaces.  That will take care of removing direct
references to the policydb, sidtab, and class/perm mapping among other
things.

WARNING: multiple messages have this Message-ID (diff)
From: sds@tycho.nsa.gov (Stephen Smalley)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 1/5] selinux:Remove direct references to policydb.
Date: Thu, 01 Feb 2018 10:28:41 -0500	[thread overview]
Message-ID: <1517498921.1750.27.camel@tycho.nsa.gov> (raw)
In-Reply-To: <4c41ad02-5370-95bc-51e4-992767768559@sony.com>

On Thu, 2018-02-01 at 16:17 +0100, peter enderborg wrote:
> On 01/30/2018 02:46 PM, Stephen Smalley wrote:
> > On Fri, 2018-01-26 at 15:32 +0100, peter.enderborg at sony.com wrote:
> > > From: Peter Enderborg <peter.enderborg@sony.com>
> > > 
> > > To be able to use rcu locks we seed to address the policydb
> > > though a pointer. This preparation removes the export of the
> > > policydb and send pointers to it through parameter agruments.
> > 
> > Just for reference, I have a patch series that does this not only
> > for
> > the policydb, sidtab, and class/perm mapping, but for all of the
> > SELinux global state, see:
> > https://github.com/stephensmalley/selinux-kernel/tree/selinuxns
> > and in particular
> > https://github.com/stephensmalley/selinux-kernel/commit/c10d90b43cd
> > 720c8f8aab51007e805bf7c4f10d2
> > https://github.com/stephensmalley/selinux-kernel/commit/ec038a64173
> > d56a331423b6d1564b801f0915afc
> > https://github.com/stephensmalley/selinux-kernel/commit/97aa5d7a05e
> > 4458bc4562c47d8f7bc4f56fbfefd
> > 
> > Those first three patches should have no effect on SELinux
> > behavior.
> > They need to be re-based to latest selinux next branch (some minor
> > conflict resolution required) but I was waiting for that to advance
> > to
> > something 4.15-rcX based.  I could however re-base it now if
> > desired.
> 
> I read that as that you want me to rebase the patches on that tree?
> Seems to
> be partly prepared but lot of changes.  Is it a moving target?

No, I wouldn't re-base on that tree.  If/when Paul updates the selinux
next branch (which should be what your patches are relative to), then I
will re-base my patches on his branch and re-submit the first few
patches to see if we can get those merged now since they don't change
SELinux behavior or interfaces.  That will take care of removing direct
references to the policydb, sidtab, and class/perm mapping among other
things.


--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-02-01 15:28 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26 14:32 [PATCH v2 0/5] selinux:Significant reduce of preempt_disable holds peter.enderborg
2018-01-26 14:32 ` peter.enderborg
2018-01-26 14:32 ` peter.enderborg at sony.com
2018-01-26 14:32 ` [PATCH v2 1/5] selinux:Remove direct references to policydb peter.enderborg
2018-01-26 14:32   ` peter.enderborg
2018-01-26 14:32   ` peter.enderborg at sony.com
2018-01-30 13:46   ` Stephen Smalley
2018-01-30 13:46     ` Stephen Smalley
2018-02-01 15:17     ` peter enderborg
2018-02-01 15:17       ` peter enderborg
2018-02-01 15:28       ` Stephen Smalley [this message]
2018-02-01 15:28         ` Stephen Smalley
2018-02-01 15:55       ` Paul Moore
2018-02-01 15:55         ` Paul Moore
2018-04-03 11:41         ` peter enderborg
2018-04-03 11:41           ` peter enderborg
2018-04-03 11:56           ` Paul Moore
2018-04-03 11:56             ` Paul Moore
2018-01-26 14:32 ` [PATCH v2 2/5] selinux: Move policydb to pointer structure peter.enderborg
2018-01-26 14:32   ` peter.enderborg
2018-01-26 14:32   ` peter.enderborg at sony.com
2018-01-26 14:32 ` [PATCH v2 3/5] selinux: Move sidtab " peter.enderborg
2018-01-26 14:32   ` peter.enderborg
2018-01-26 14:32   ` peter.enderborg at sony.com
2018-01-26 14:32 ` [PATCH v2 4/5] selinux: Use pointer to switch policydb and sidtab peter.enderborg
2018-01-26 14:32   ` peter.enderborg
2018-01-26 14:32   ` peter.enderborg at sony.com
2018-01-30 14:37   ` Stephen Smalley
2018-01-30 14:37     ` Stephen Smalley
2018-02-08  7:16     ` peter enderborg
2018-02-08  7:16       ` peter enderborg
2018-02-08 15:10       ` Stephen Smalley
2018-02-08 15:10         ` Stephen Smalley
2018-01-26 14:32 ` [PATCH v2 5/5] selinux: Switch locking to RCU peter.enderborg
2018-01-26 14:32   ` peter.enderborg
2018-01-26 14:32   ` peter.enderborg at sony.com
2018-01-30 13:37 ` [PATCH v2 0/5] selinux:Significant reduce of preempt_disable holds Stephen Smalley
2018-01-30 13:37   ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517498921.1750.27.camel@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=linux-security-module@vger.kernel.org \
    --cc=peter.enderborg@sony.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.