All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Redfearn <matt.redfearn@mips.com>
To: <kvalo@codeaurora.org>
Cc: <zajec5@gmail.com>, <linux-wireless@vger.kernel.org>,
	<linux-mips@linux-mips.org>, <jhogan@kernel.org>,
	Matt Redfearn <matt.redfearn@mips.com>
Subject: [PATCH v2] bcma: Prevent build of PCI host features in module
Date: Thu, 1 Mar 2018 09:58:12 +0000	[thread overview]
Message-ID: <1519898292-12155-1-git-send-email-matt.redfearn@mips.com> (raw)

Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in
a build error due to use of symbols not exported from vmlinux:

ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined!
ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1

To prevent this, don't allow the host mode feature to be built if
CONFIG_BCMA=m

Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>

---

Changes in v2:
Rebase on v4.16-rc1

 drivers/bcma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index ba8acca036df..cb0f1aad20b7 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI
 
 config BCMA_DRIVER_PCI_HOSTMODE
 	bool "Driver for PCI core working in hostmode"
-	depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
+	depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y
 	help
 	  PCI core hostmode operation (external PCI bus).
 
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Matt Redfearn <matt.redfearn@mips.com>
To: kvalo@codeaurora.org
Cc: zajec5@gmail.com, linux-wireless@vger.kernel.org,
	linux-mips@linux-mips.org, jhogan@kernel.org,
	Matt Redfearn <matt.redfearn@mips.com>
Subject: [PATCH v2] bcma: Prevent build of PCI host features in module
Date: Thu, 1 Mar 2018 09:58:12 +0000	[thread overview]
Message-ID: <1519898292-12155-1-git-send-email-matt.redfearn@mips.com> (raw)
Message-ID: <20180301095812.oDexUAtVByQNggvgkGOnBWxOlZmqbK3aSVgLbhWhyvk@z> (raw)

Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in
a build error due to use of symbols not exported from vmlinux:

ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined!
ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1

To prevent this, don't allow the host mode feature to be built if
CONFIG_BCMA=m

Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>

---

Changes in v2:
Rebase on v4.16-rc1

 drivers/bcma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index ba8acca036df..cb0f1aad20b7 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI
 
 config BCMA_DRIVER_PCI_HOSTMODE
 	bool "Driver for PCI core working in hostmode"
-	depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
+	depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y
 	help
 	  PCI core hostmode operation (external PCI bus).
 
-- 
2.7.4

             reply	other threads:[~2018-03-01 10:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01  9:58 Matt Redfearn [this message]
2018-03-01  9:58 ` [PATCH v2] bcma: Prevent build of PCI host features in module Matt Redfearn
2018-03-01 10:45 ` Kalle Valo
2018-03-01 10:45   ` Kalle Valo
2018-03-02 17:56   ` Larry Finger
2018-03-08 12:00     ` Matt Redfearn
2018-03-08 12:00       ` Matt Redfearn
2018-03-10 11:35       ` Jonas Gorski
2018-03-13 16:48 ` [v2] " Kalle Valo
2018-03-13 16:48   ` Kalle Valo
2018-03-13 16:48 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519898292-12155-1-git-send-email-matt.redfearn@mips.com \
    --to=matt.redfearn@mips.com \
    --cc=jhogan@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.