From: Wei Wang <wei.w.wang@intel.com> To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com Cc: pbonzini@redhat.com, wei.w.wang@intel.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com Subject: [Qemu-devel] [PATCH v7 2/5] migration: use bitmap_mutex in migration_bitmap_clear_dirty Date: Tue, 24 Apr 2018 14:13:45 +0800 [thread overview] Message-ID: <1524550428-27173-3-git-send-email-wei.w.wang@intel.com> (raw) In-Reply-To: <1524550428-27173-1-git-send-email-wei.w.wang@intel.com> The bitmap mutex is used to synchronize threads to update the dirty bitmap and the migration_dirty_pages counter. This patch makes migration_bitmap_clear_dirty update the bitmap and counter under the mutex. Signed-off-by: Wei Wang <wei.w.wang@intel.com> CC: Dr. David Alan Gilbert <dgilbert@redhat.com> CC: Juan Quintela <quintela@redhat.com> CC: Michael S. Tsirkin <mst@redhat.com> --- migration/ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 0e90efa..9a72b1a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -795,11 +795,14 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs, { bool ret; + qemu_mutex_lock(&rs->bitmap_mutex); ret = test_and_clear_bit(page, rb->bmap); if (ret) { rs->migration_dirty_pages--; } + qemu_mutex_unlock(&rs->bitmap_mutex); + return ret; } -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com> To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com Cc: pbonzini@redhat.com, wei.w.wang@intel.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com Subject: [virtio-dev] [PATCH v7 2/5] migration: use bitmap_mutex in migration_bitmap_clear_dirty Date: Tue, 24 Apr 2018 14:13:45 +0800 [thread overview] Message-ID: <1524550428-27173-3-git-send-email-wei.w.wang@intel.com> (raw) In-Reply-To: <1524550428-27173-1-git-send-email-wei.w.wang@intel.com> The bitmap mutex is used to synchronize threads to update the dirty bitmap and the migration_dirty_pages counter. This patch makes migration_bitmap_clear_dirty update the bitmap and counter under the mutex. Signed-off-by: Wei Wang <wei.w.wang@intel.com> CC: Dr. David Alan Gilbert <dgilbert@redhat.com> CC: Juan Quintela <quintela@redhat.com> CC: Michael S. Tsirkin <mst@redhat.com> --- migration/ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 0e90efa..9a72b1a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -795,11 +795,14 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs, { bool ret; + qemu_mutex_lock(&rs->bitmap_mutex); ret = test_and_clear_bit(page, rb->bmap); if (ret) { rs->migration_dirty_pages--; } + qemu_mutex_unlock(&rs->bitmap_mutex); + return ret; } -- 1.8.3.1 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-04-24 6:32 UTC|newest] Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-24 6:13 [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support Wei Wang 2018-04-24 6:13 ` [virtio-dev] " Wei Wang 2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 1/5] bitmap: bitmap_count_one_with_offset Wei Wang 2018-04-24 6:13 ` [virtio-dev] " Wei Wang 2018-04-24 6:13 ` Wei Wang [this message] 2018-04-24 6:13 ` [virtio-dev] [PATCH v7 2/5] migration: use bitmap_mutex in migration_bitmap_clear_dirty Wei Wang 2018-06-01 3:37 ` [Qemu-devel] " Peter Xu 2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 3/5] migration: API to clear bits of guest free pages from the dirty bitmap Wei Wang 2018-04-24 6:13 ` [virtio-dev] " Wei Wang 2018-06-01 4:00 ` [Qemu-devel] " Peter Xu 2018-06-01 7:36 ` Wei Wang 2018-06-01 7:36 ` [virtio-dev] " Wei Wang 2018-06-01 10:06 ` Peter Xu 2018-06-01 12:32 ` Wei Wang 2018-06-01 12:32 ` [virtio-dev] " Wei Wang 2018-06-04 2:49 ` Peter Xu 2018-06-04 7:43 ` Wei Wang 2018-06-04 7:43 ` [virtio-dev] " Wei Wang 2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang 2018-04-24 6:13 ` [virtio-dev] " Wei Wang 2018-05-29 15:24 ` [Qemu-devel] " Michael S. Tsirkin 2018-05-29 15:24 ` [virtio-dev] " Michael S. Tsirkin 2018-05-30 9:12 ` [Qemu-devel] " Wei Wang 2018-05-30 9:12 ` [virtio-dev] " Wei Wang 2018-05-30 12:47 ` [Qemu-devel] " Michael S. Tsirkin 2018-05-30 12:47 ` [virtio-dev] " Michael S. Tsirkin 2018-05-31 2:27 ` [Qemu-devel] " Wei Wang 2018-05-31 2:27 ` [virtio-dev] " Wei Wang 2018-05-31 17:42 ` [Qemu-devel] " Michael S. Tsirkin 2018-05-31 17:42 ` [virtio-dev] " Michael S. Tsirkin 2018-06-01 3:18 ` [Qemu-devel] " Wei Wang 2018-06-01 3:18 ` [virtio-dev] " Wei Wang 2018-06-04 8:04 ` [Qemu-devel] " Wei Wang 2018-06-04 8:04 ` [virtio-dev] " Wei Wang 2018-06-05 6:58 ` [Qemu-devel] " Peter Xu 2018-06-05 13:22 ` Wei Wang 2018-06-05 13:22 ` [virtio-dev] " Wei Wang 2018-06-06 5:42 ` [Qemu-devel] " Peter Xu 2018-06-06 10:04 ` Wei Wang 2018-06-06 10:04 ` [virtio-dev] " Wei Wang 2018-06-06 11:02 ` [Qemu-devel] " Peter Xu 2018-06-07 5:24 ` Wei Wang 2018-06-07 5:24 ` [virtio-dev] " Wei Wang 2018-06-07 6:32 ` [Qemu-devel] " Peter Xu 2018-06-07 11:59 ` Wei Wang 2018-06-07 11:59 ` [virtio-dev] " Wei Wang 2018-06-08 2:17 ` [Qemu-devel] " Peter Xu 2018-06-08 7:14 ` Wei Wang 2018-06-08 7:14 ` [virtio-dev] " Wei Wang 2018-06-08 7:31 ` [Qemu-devel] " Wei Wang 2018-06-08 7:31 ` [virtio-dev] " Wei Wang 2018-06-06 6:43 ` [Qemu-devel] " Peter Xu 2018-06-06 10:11 ` Wei Wang 2018-06-06 10:11 ` [virtio-dev] " Wei Wang 2018-06-07 3:17 ` Peter Xu 2018-06-07 5:29 ` Wei Wang 2018-06-07 5:29 ` [virtio-dev] " Wei Wang 2018-06-07 6:58 ` Peter Xu 2018-06-07 12:01 ` Wei Wang 2018-06-07 12:01 ` [virtio-dev] " Wei Wang 2018-06-08 1:37 ` Peter Xu 2018-06-08 1:58 ` Peter Xu 2018-06-08 1:58 ` Michael S. Tsirkin 2018-06-08 1:58 ` [virtio-dev] " Michael S. Tsirkin 2018-06-08 2:34 ` Peter Xu 2018-06-08 2:49 ` Michael S. Tsirkin 2018-06-08 2:49 ` [virtio-dev] " Michael S. Tsirkin 2018-06-08 3:34 ` Peter Xu 2018-04-24 6:13 ` [Qemu-devel] [PATCH v7 5/5] migration: use the free page hint feature from balloon Wei Wang 2018-04-24 6:13 ` [virtio-dev] " Wei Wang 2018-04-24 6:42 ` [Qemu-devel] [PATCH v7 0/5] virtio-balloon: free page hint reporting support Wei Wang 2018-04-24 6:42 ` [virtio-dev] " Wei Wang 2018-05-14 1:22 ` [Qemu-devel] " Wei Wang 2018-05-14 1:22 ` [virtio-dev] " Wei Wang 2018-05-29 15:00 ` [Qemu-devel] " Hailiang Zhang 2018-05-29 15:24 ` Michael S. Tsirkin 2018-05-29 15:24 ` [virtio-dev] " Michael S. Tsirkin 2018-06-01 4:58 ` Peter Xu 2018-06-01 5:07 ` Peter Xu 2018-06-01 7:29 ` Wei Wang 2018-06-01 7:29 ` [virtio-dev] " Wei Wang 2018-06-01 10:02 ` Peter Xu 2018-06-01 12:31 ` Wei Wang 2018-06-01 12:31 ` [virtio-dev] " Wei Wang 2018-06-01 7:21 ` Wei Wang 2018-06-01 7:21 ` [virtio-dev] " Wei Wang 2018-06-01 10:40 ` Peter Xu 2018-06-01 15:33 ` Dr. David Alan Gilbert 2018-06-05 6:42 ` Peter Xu 2018-06-05 14:40 ` Michael S. Tsirkin 2018-06-05 14:40 ` [virtio-dev] " Michael S. Tsirkin 2018-06-05 14:39 ` Michael S. Tsirkin 2018-06-05 14:39 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1524550428-27173-3-git-send-email-wei.w.wang@intel.com \ --to=wei.w.wang@intel.com \ --cc=dgilbert@redhat.com \ --cc=liliang.opensource@gmail.com \ --cc=mst@redhat.com \ --cc=nilal@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=quan.xu0@gmail.com \ --cc=quintela@redhat.com \ --cc=riel@redhat.com \ --cc=virtio-dev@lists.oasis-open.org \ --cc=yang.zhang.wz@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.