From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm/i915: Combine set-wedged protection and tasklet kicking
Date: Mon, 07 May 2018 13:16:31 +0100 [thread overview]
Message-ID: <152569539103.9723.5449314493870522143@mail.alporthouse.com> (raw)
In-Reply-To: <878t8vy8en.fsf@gaia.fi.intel.com>
Quoting Mika Kuoppala (2018-05-07 13:09:20)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Around request submission, we protect the call to schedule with a
> > premption disable loop to prevent set-wedge chaning function pointers
>
> s/premption/preemption
> s/chaning/changing
>
> Also RCU read critical sections can be preempted if CONFIG_PREEMPT_RCU
> so it looks like we should have had explicit preempt_disable()
> before the rcu_read_lock(), if it is the preempt disable we rely on?
No, my mistake in not knowing about PREEMPT_RCU. So we need both. Sigh.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-07 12:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 9:25 [PATCH 1/7] drm/i915: Flush submission tasklet after bumping priority Chris Wilson
2018-05-07 9:25 ` [PATCH 2/7] drm/i915: Combine set-wedged protection and tasklet kicking Chris Wilson
2018-05-07 12:09 ` Mika Kuoppala
2018-05-07 12:16 ` Chris Wilson [this message]
2018-05-07 9:25 ` [PATCH 3/7] drm/i915/execlists: Make submission tasklet hardirq safe Chris Wilson
2018-05-07 9:25 ` [PATCH 4/7] drm/i915/guc: " Chris Wilson
2018-05-07 9:25 ` [PATCH 5/7] drm/i915/execlists: Direct submit onto idle engines Chris Wilson
2018-05-07 9:25 ` [PATCH 6/7] drm/i915/execlists: Direct submission from irq handler Chris Wilson
2018-05-07 9:25 ` [PATCH 7/7] drm/i915: Speed up idle detection by kicking the tasklets Chris Wilson
2018-05-07 9:35 ` [PATCH v3] " Chris Wilson
2018-05-07 14:08 ` kbuild test robot
2018-05-07 9:33 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Flush submission tasklet after bumping priority Patchwork
2018-05-07 9:35 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-07 9:52 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-05-07 9:57 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Flush submission tasklet after bumping priority (rev2) Patchwork
2018-05-07 9:59 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-07 10:14 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-05-07 11:15 ` [PATCH 1/7] drm/i915: Flush submission tasklet after bumping priority Mika Kuoppala
2018-05-07 11:19 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152569539103.9723.5449314493870522143@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.