From: kbuild test robot <lkp@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [PATCH v3] drm/i915: Speed up idle detection by kicking the tasklets
Date: Mon, 7 May 2018 22:08:23 +0800 [thread overview]
Message-ID: <201805071916.3WEiefNI%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180507093548.30487-1-chris@chris-wilson.co.uk>
[-- Attachment #1: Type: text/plain, Size: 2965 bytes --]
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.17-rc4 next-20180504]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Speed-up-idle-detection-by-kicking-the-tasklets/20180507-184057
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x0-05071422 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/gpu//drm/i915/intel_engine_cs.c: In function 'intel_engine_is_idle':
>> drivers/gpu//drm/i915/intel_engine_cs.c:954:3: error: implicit declaration of function 'execlists_tasklet' [-Werror=implicit-function-declaration]
execlists_tasklet(&engine->execlists);
^
cc1: some warnings being treated as errors
vim +/execlists_tasklet +954 drivers/gpu//drm/i915/intel_engine_cs.c
923
924 /**
925 * intel_engine_is_idle() - Report if the engine has finished process all work
926 * @engine: the intel_engine_cs
927 *
928 * Return true if there are no requests pending, nothing left to be submitted
929 * to hardware, and that the engine is idle.
930 */
931 bool intel_engine_is_idle(struct intel_engine_cs *engine)
932 {
933 struct drm_i915_private *dev_priv = engine->i915;
934
935 /* More white lies, if wedged, hw state is inconsistent */
936 if (i915_terminally_wedged(&dev_priv->gpu_error))
937 return true;
938
939 /* Any inflight/incomplete requests? */
940 if (!i915_seqno_passed(intel_engine_get_seqno(engine),
941 intel_engine_last_submit(engine)))
942 return false;
943
944 if (I915_SELFTEST_ONLY(engine->breadcrumbs.mock))
945 return true;
946
947 /*
948 * ksoftirqd has notorious latency that may cause us to
949 * timeout while waiting for the engine to idle as we wait for
950 * ksoftirqd to run the execlists tasklet to drain the ELSP.
951 * If we are expecting a context switch from the GPU, check now.
952 */
953 if (test_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted))
> 954 execlists_tasklet(&engine->execlists);
955
956 /* Waiting to drain ELSP? */
957 if (READ_ONCE(engine->execlists.active))
958 return false;
959
960 /* ELSP is empty, but there are ready requests? E.g. after reset */
961 if (READ_ONCE(engine->execlists.first))
962 return false;
963
964 /* Ring stopped? */
965 if (!ring_is_idle(engine))
966 return false;
967
968 return true;
969 }
970
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30195 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-07 14:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 9:25 [PATCH 1/7] drm/i915: Flush submission tasklet after bumping priority Chris Wilson
2018-05-07 9:25 ` [PATCH 2/7] drm/i915: Combine set-wedged protection and tasklet kicking Chris Wilson
2018-05-07 12:09 ` Mika Kuoppala
2018-05-07 12:16 ` Chris Wilson
2018-05-07 9:25 ` [PATCH 3/7] drm/i915/execlists: Make submission tasklet hardirq safe Chris Wilson
2018-05-07 9:25 ` [PATCH 4/7] drm/i915/guc: " Chris Wilson
2018-05-07 9:25 ` [PATCH 5/7] drm/i915/execlists: Direct submit onto idle engines Chris Wilson
2018-05-07 9:25 ` [PATCH 6/7] drm/i915/execlists: Direct submission from irq handler Chris Wilson
2018-05-07 9:25 ` [PATCH 7/7] drm/i915: Speed up idle detection by kicking the tasklets Chris Wilson
2018-05-07 9:35 ` [PATCH v3] " Chris Wilson
2018-05-07 14:08 ` kbuild test robot [this message]
2018-05-07 9:33 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Flush submission tasklet after bumping priority Patchwork
2018-05-07 9:35 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-07 9:52 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-05-07 9:57 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Flush submission tasklet after bumping priority (rev2) Patchwork
2018-05-07 9:59 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-07 10:14 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-05-07 11:15 ` [PATCH 1/7] drm/i915: Flush submission tasklet after bumping priority Mika Kuoppala
2018-05-07 11:19 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201805071916.3WEiefNI%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.