[Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

[Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

[Peter Maydell]

The guest-agent-core.h header was missing the usual guards
against multiple inclusion; add them.

(Spotted by lgtm.com's static analyzer.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 qga/guest-agent-core.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
index 6f4d214cb9f..60eae16f27a 100644
--- a/qga/guest-agent-core.h
+++ b/qga/guest-agent-core.h
@@ -10,6 +10,9 @@
  * This work is licensed under the terms of the GNU GPL, version 2 or later.
  * See the COPYING file in the top-level directory.
  */
+#ifndef GUEST_AGENT_CORE_H
+#define GUEST_AGENT_CORE_H
+
 #include "qapi/qmp/dispatch.h"
 #include "qemu-common.h"
 #include "qga-qapi-types.h"
@@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
 #ifndef _WIN32
 void reopen_fd_to_null(int fd);
 #endif
+
+#endif /* GUEST_AGENT_CORE_H */
-- 
2.19.1

Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

[Marc-André Lureau]

Hi

On Thu, Nov 8, 2018 at 4:52 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
>
> (Spotted by lgtm.com's static analyzer.)

neat,
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  qga/guest-agent-core.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
>   * This work is licensed under the terms of the GNU GPL, version 2 or later.
>   * See the COPYING file in the top-level directory.
>   */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
>  #include "qapi/qmp/dispatch.h"
>  #include "qemu-common.h"
>  #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
>  #ifndef _WIN32
>  void reopen_fd_to_null(int fd);
>  #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */
> --
> 2.19.1
>
>


-- 
Marc-André Lureau

Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

[Philippe Mathieu-Daudé]

On 8/11/18 13:52, Peter Maydell wrote:
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
> 
> (Spotted by lgtm.com's static analyzer.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   qga/guest-agent-core.h | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
>    * This work is licensed under the terms of the GNU GPL, version 2 or later.
>    * See the COPYING file in the top-level directory.
>    */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
>   #include "qapi/qmp/dispatch.h"
>   #include "qemu-common.h"
>   #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
>   #ifndef _WIN32
>   void reopen_fd_to_null(int fd);
>   #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */
> 

Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

[Michael Roth]

Quoting Peter Maydell (2018-11-08 06:52:23)
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
> 
> (Spotted by lgtm.com's static analyzer.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Thanks, applied to qga tree:
  https://github.com/mdroth/qemu/commits/qga

> ---
>  qga/guest-agent-core.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
>   * This work is licensed under the terms of the GNU GPL, version 2 or later.
>   * See the COPYING file in the top-level directory.
>   */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
>  #include "qapi/qmp/dispatch.h"
>  #include "qemu-common.h"
>  #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
>  #ifndef _WIN32
>  void reopen_fd_to_null(int fd);
>  #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */
> -- 
> 2.19.1
>