From: Nicholas Mc Guire <hofrat@osadl.org> To: Linus Walleij <linus.walleij@linaro.org> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>, Matthias Brugger <matthias.bgg@gmail.com>, Sergio Paracuellos <sergio.paracuellos@gmail.com>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Nicholas Mc Guire <hofrat@osadl.org> Subject: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack Date: Wed, 21 Nov 2018 19:06:13 +0100 [thread overview] Message-ID: <1542823573-20228-2-git-send-email-hofrat@osadl.org> (raw) In-Reply-To: <1542823573-20228-1-git-send-email-hofrat@osadl.org> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except for the dev_err() messages). The probe function should return an error if one of the banks failed to initialize properly. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") --- Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y, GPIOLIB=y, GPIO_MT7621=y Patch is against 4.20-rc3 (localversion-next is next-20181121) drivers/gpio/gpio-mt7621.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c index 1ec95bc..68fca8b 100644 --- a/drivers/gpio/gpio-mt7621.c +++ b/drivers/gpio/gpio-mt7621.c @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev) struct device_node *np = dev->of_node; struct mtk *mtk; int i; + int ret; mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL); if (!mtk) @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev) platform_set_drvdata(pdev, mtk); mediatek_gpio_irq_chip.name = dev_name(dev); - for (i = 0; i < MTK_BANK_CNT; i++) - mediatek_gpio_bank_probe(dev, np, i); + for (i = 0; i < MTK_BANK_CNT; i++) { + ret = mediatek_gpio_bank_probe(dev, np, i); + if (!ret) + return ret; + } return 0; } -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: hofrat@osadl.org (Nicholas Mc Guire) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack Date: Wed, 21 Nov 2018 19:06:13 +0100 [thread overview] Message-ID: <1542823573-20228-2-git-send-email-hofrat@osadl.org> (raw) In-Reply-To: <1542823573-20228-1-git-send-email-hofrat@osadl.org> The error cases of mediatek_gpio_bank_probe() would go unnoticed (except for the dev_err() messages). The probe function should return an error if one of the banks failed to initialize properly. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") --- Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y, GPIOLIB=y, GPIO_MT7621=y Patch is against 4.20-rc3 (localversion-next is next-20181121) drivers/gpio/gpio-mt7621.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c index 1ec95bc..68fca8b 100644 --- a/drivers/gpio/gpio-mt7621.c +++ b/drivers/gpio/gpio-mt7621.c @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev) struct device_node *np = dev->of_node; struct mtk *mtk; int i; + int ret; mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL); if (!mtk) @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev) platform_set_drvdata(pdev, mtk); mediatek_gpio_irq_chip.name = dev_name(dev); - for (i = 0; i < MTK_BANK_CNT; i++) - mediatek_gpio_bank_probe(dev, np, i); + for (i = 0; i < MTK_BANK_CNT; i++) { + ret = mediatek_gpio_bank_probe(dev, np, i); + if (!ret) + return ret; + } return 0; } -- 2.1.4
next prev parent reply other threads:[~2018-11-21 18:06 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-21 18:06 [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf() Nicholas Mc Guire 2018-11-21 18:06 ` Nicholas Mc Guire 2018-11-21 18:06 ` Nicholas Mc Guire [this message] 2018-11-21 18:06 ` [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack Nicholas Mc Guire 2018-11-22 16:44 ` Bartosz Golaszewski 2018-11-22 16:44 ` Bartosz Golaszewski 2018-11-27 7:49 ` Sean Wang 2018-11-27 7:49 ` Sean Wang 2018-11-27 8:01 ` Nicholas Mc Guire 2018-11-27 8:01 ` Nicholas Mc Guire 2018-11-27 8:32 ` Sean Wang 2018-11-27 8:32 ` Sean Wang 2018-11-27 8:37 ` Nicholas Mc Guire 2018-11-27 8:37 ` Nicholas Mc Guire 2018-11-22 16:39 ` [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf() Bartosz Golaszewski 2018-11-22 16:39 ` Bartosz Golaszewski 2018-11-27 7:20 ` Sean Wang 2018-11-27 7:20 ` Sean Wang 2018-12-07 9:46 ` Linus Walleij 2018-12-07 9:46 ` Linus Walleij 2018-12-07 9:46 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1542823573-20228-2-git-send-email-hofrat@osadl.org \ --to=hofrat@osadl.org \ --cc=bgolaszewski@baylibre.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=sergio.paracuellos@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.