From: no-reply@patchew.org To: guangrong.xiao@gmail.com Cc: famz@redhat.com, kvm@vger.kernel.org, quintela@redhat.com, mtosatti@redhat.com, xiaoguangrong@tencent.com, qemu-devel@nongnu.org, peterx@redhat.com, dgilbert@redhat.com, wei.w.wang@intel.com, cota@braap.org, mst@redhat.com, jiang.biao2@zte.com.cn, pbonzini@redhat.com Subject: Re: [PATCH v3 0/5] migration: improve multithreads Date: Thu, 22 Nov 2018 13:35:52 -0800 (PST) [thread overview] Message-ID: <154292254994.3075.15325134887017277128@c26723477dc9> (raw) In-Reply-To: <20181122072028.22819-1-xiaoguangrong@tencent.com> Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181122072028.22819-1-xiaoguangrong@tencent.com Type: series Subject: [Qemu-devel] [PATCH v3 0/5] migration: improve multithreads === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1f40f88 tests: add threaded-workqueue-bench 0c560ac migration: use threaded workqueue for decompression effdcb4 migration: use threaded workqueue for compression eb91c63 util: introduce threaded workqueue 3bf8b44 bitops: introduce change_bit_atomic === OUTPUT BEGIN === Checking PATCH 1/5: bitops: introduce change_bit_atomic... Checking PATCH 2/5: util: introduce threaded workqueue... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 ERROR: externs should be avoided in .c files #233: FILE: util/threaded-workqueue.c:65: + uint64_t request_fill_bitmap QEMU_ALIGNED(SMP_CACHE_BYTES); ERROR: externs should be avoided in .c files #235: FILE: util/threaded-workqueue.c:67: + uint64_t request_done_bitmap QEMU_ALIGNED(SMP_CACHE_BYTES); ERROR: externs should be avoided in .c files #241: FILE: util/threaded-workqueue.c:73: + QemuEvent request_valid_ev QEMU_ALIGNED(SMP_CACHE_BYTES); ERROR: externs should be avoided in .c files #247: FILE: util/threaded-workqueue.c:79: + QemuEvent request_free_ev QEMU_ALIGNED(SMP_CACHE_BYTES); total: 4 errors, 1 warnings, 575 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/5: migration: use threaded workqueue for compression... Checking PATCH 4/5: migration: use threaded workqueue for decompression... Checking PATCH 5/5: tests: add threaded-workqueue-bench... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 WARNING: line over 80 characters #234: FILE: tests/threaded-workqueue-bench.c:194: + printf(" -r: the number of requests handled by each thread (default %d).\n", WARNING: line over 80 characters #236: FILE: tests/threaded-workqueue-bench.c:196: + printf(" -m: the size of the memory (G) used to test (default %dG).\n", ERROR: line over 90 characters #282: FILE: tests/threaded-workqueue-bench.c:242: + printf("Run the benchmark: threads %d requests-per-thread: %d memory %ldG repeat %d.\n", total: 1 errors, 3 warnings, 272 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: no-reply@patchew.org To: guangrong.xiao@gmail.com Cc: famz@redhat.com, pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org, quintela@redhat.com, xiaoguangrong@tencent.com, qemu-devel@nongnu.org, peterx@redhat.com, dgilbert@redhat.com, wei.w.wang@intel.com, cota@braap.org, jiang.biao2@zte.com.cn Subject: Re: [Qemu-devel] [PATCH v3 0/5] migration: improve multithreads Date: Thu, 22 Nov 2018 13:35:52 -0800 (PST) [thread overview] Message-ID: <154292254994.3075.15325134887017277128@c26723477dc9> (raw) In-Reply-To: <20181122072028.22819-1-xiaoguangrong@tencent.com> Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181122072028.22819-1-xiaoguangrong@tencent.com Type: series Subject: [Qemu-devel] [PATCH v3 0/5] migration: improve multithreads === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1f40f88 tests: add threaded-workqueue-bench 0c560ac migration: use threaded workqueue for decompression effdcb4 migration: use threaded workqueue for compression eb91c63 util: introduce threaded workqueue 3bf8b44 bitops: introduce change_bit_atomic === OUTPUT BEGIN === Checking PATCH 1/5: bitops: introduce change_bit_atomic... Checking PATCH 2/5: util: introduce threaded workqueue... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 ERROR: externs should be avoided in .c files #233: FILE: util/threaded-workqueue.c:65: + uint64_t request_fill_bitmap QEMU_ALIGNED(SMP_CACHE_BYTES); ERROR: externs should be avoided in .c files #235: FILE: util/threaded-workqueue.c:67: + uint64_t request_done_bitmap QEMU_ALIGNED(SMP_CACHE_BYTES); ERROR: externs should be avoided in .c files #241: FILE: util/threaded-workqueue.c:73: + QemuEvent request_valid_ev QEMU_ALIGNED(SMP_CACHE_BYTES); ERROR: externs should be avoided in .c files #247: FILE: util/threaded-workqueue.c:79: + QemuEvent request_free_ev QEMU_ALIGNED(SMP_CACHE_BYTES); total: 4 errors, 1 warnings, 575 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/5: migration: use threaded workqueue for compression... Checking PATCH 4/5: migration: use threaded workqueue for decompression... Checking PATCH 5/5: tests: add threaded-workqueue-bench... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 WARNING: line over 80 characters #234: FILE: tests/threaded-workqueue-bench.c:194: + printf(" -r: the number of requests handled by each thread (default %d).\n", WARNING: line over 80 characters #236: FILE: tests/threaded-workqueue-bench.c:196: + printf(" -m: the size of the memory (G) used to test (default %dG).\n", ERROR: line over 90 characters #282: FILE: tests/threaded-workqueue-bench.c:242: + printf("Run the benchmark: threads %d requests-per-thread: %d memory %ldG repeat %d.\n", total: 1 errors, 3 warnings, 272 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2018-11-22 21:35 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-22 7:20 [PATCH v3 0/5] migration: improve multithreads guangrong.xiao 2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao 2018-11-22 7:20 ` [PATCH v3 1/5] bitops: introduce change_bit_atomic guangrong.xiao 2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao 2018-11-23 10:23 ` Dr. David Alan Gilbert 2018-11-23 10:23 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-28 9:35 ` Juan Quintela 2018-11-28 9:35 ` [Qemu-devel] " Juan Quintela 2018-11-22 7:20 ` [PATCH v3 2/5] util: introduce threaded workqueue guangrong.xiao 2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao 2018-11-23 11:02 ` Dr. David Alan Gilbert 2018-11-23 11:02 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-26 7:57 ` Xiao Guangrong 2018-11-26 7:57 ` [Qemu-devel] " Xiao Guangrong 2018-11-26 10:56 ` Dr. David Alan Gilbert 2018-11-26 10:56 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-27 7:17 ` Xiao Guangrong 2018-11-27 7:17 ` [Qemu-devel] " Xiao Guangrong 2018-11-26 18:55 ` Emilio G. Cota 2018-11-26 18:55 ` [Qemu-devel] " Emilio G. Cota 2018-11-27 8:30 ` Xiao Guangrong 2018-11-27 8:30 ` [Qemu-devel] " Xiao Guangrong 2018-11-24 0:12 ` Emilio G. Cota 2018-11-24 0:12 ` [Qemu-devel] " Emilio G. Cota 2018-11-26 8:06 ` Xiao Guangrong 2018-11-26 8:06 ` [Qemu-devel] " Xiao Guangrong 2018-11-26 18:49 ` Emilio G. Cota 2018-11-26 18:49 ` [Qemu-devel] " Emilio G. Cota 2018-11-27 8:29 ` Xiao Guangrong 2018-11-27 8:29 ` [Qemu-devel] " Xiao Guangrong 2018-11-24 0:17 ` Emilio G. Cota 2018-11-24 0:17 ` [Qemu-devel] " Emilio G. Cota 2018-11-26 8:18 ` Xiao Guangrong 2018-11-26 8:18 ` [Qemu-devel] " Xiao Guangrong 2018-11-26 10:28 ` Paolo Bonzini 2018-11-26 10:28 ` [Qemu-devel] " Paolo Bonzini 2018-11-27 8:31 ` Xiao Guangrong 2018-11-27 8:31 ` [Qemu-devel] " Xiao Guangrong 2018-11-27 12:49 ` Christophe de Dinechin 2018-11-27 12:49 ` [Qemu-devel] " Christophe de Dinechin 2018-11-27 13:51 ` Paolo Bonzini 2018-11-27 13:51 ` [Qemu-devel] " Paolo Bonzini 2018-12-04 15:49 ` Christophe de Dinechin 2018-12-04 15:49 ` [Qemu-devel] " Christophe de Dinechin 2018-12-04 17:16 ` Paolo Bonzini 2018-12-04 17:16 ` [Qemu-devel] " Paolo Bonzini 2018-12-10 3:23 ` Xiao Guangrong 2018-12-10 3:23 ` [Qemu-devel] " Xiao Guangrong 2018-11-27 17:39 ` Emilio G. Cota 2018-11-27 17:39 ` [Qemu-devel] " Emilio G. Cota 2018-11-28 8:55 ` Xiao Guangrong 2018-11-28 8:55 ` [Qemu-devel] " Xiao Guangrong 2018-11-22 7:20 ` [PATCH v3 3/5] migration: use threaded workqueue for compression guangrong.xiao 2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao 2018-11-23 18:17 ` Dr. David Alan Gilbert 2018-11-23 18:17 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-23 18:22 ` Paolo Bonzini 2018-11-23 18:22 ` [Qemu-devel] " Paolo Bonzini 2018-11-23 18:29 ` Dr. David Alan Gilbert 2018-11-23 18:29 ` [Qemu-devel] " Dr. David Alan Gilbert 2018-11-26 8:00 ` Xiao Guangrong 2018-11-26 8:00 ` [Qemu-devel] " Xiao Guangrong 2018-11-22 7:20 ` [PATCH v3 4/5] migration: use threaded workqueue for decompression guangrong.xiao 2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao 2018-11-22 7:20 ` [PATCH v3 5/5] tests: add threaded-workqueue-bench guangrong.xiao 2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao 2018-11-22 21:25 ` [PATCH v3 0/5] migration: improve multithreads no-reply 2018-11-22 21:25 ` [Qemu-devel] " no-reply 2018-11-22 21:35 ` no-reply [this message] 2018-11-22 21:35 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=154292254994.3075.15325134887017277128@c26723477dc9 \ --to=no-reply@patchew.org \ --cc=cota@braap.org \ --cc=dgilbert@redhat.com \ --cc=famz@redhat.com \ --cc=guangrong.xiao@gmail.com \ --cc=jiang.biao2@zte.com.cn \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=quintela@redhat.com \ --cc=wei.w.wang@intel.com \ --cc=xiaoguangrong@tencent.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.