* [PATCH] dri2: reply to client for WaitMSC request in any case
@ 2019-05-29 6:36 Cui, Flora
[not found] ` <1559111780-32513-1-git-send-email-flora.cui-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Cui, Flora @ 2019-05-29 6:36 UTC (permalink / raw)
To: Daenzer, Michel, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Cui, Flora
otherwise client would wait for reply forever and desktop appears hang.
Signed-off-by: Flora Cui <flora.cui@amd.com>
---
src/amdgpu_dri2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
index 44316ac..34353a7 100644
--- a/src/amdgpu_dri2.c
+++ b/src/amdgpu_dri2.c
@@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw,
out_complete:
if (wait_info)
amdgpu_dri2_deferred_event(NULL, 0, wait_info);
+
+ DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
+
return TRUE;
}
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] dri2: reply to client for WaitMSC request in any case
[not found] ` <1559111780-32513-1-git-send-email-flora.cui-5C7GfCeVMHo@public.gmane.org>
@ 2019-06-03 7:26 ` Cui, Flora
[not found] ` <bc4571fc-6521-74d7-2d5c-1665396b50fc-5C7GfCeVMHo@public.gmane.org>
2019-06-03 7:56 ` [PATCH] " Michel Dänzer
1 sibling, 1 reply; 6+ messages in thread
From: Cui, Flora @ 2019-06-03 7:26 UTC (permalink / raw)
To: Cui, Flora, Daenzer, Michel, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
ping...
commit 47613e8e8f4a5e3b25830e3c015a4a217fcbe469
Author: Flora Cui <flora.cui@amd.com>
Date: Wed May 29 14:18:50 2019 +0800
dri2: reply to client for WaitMSC request in any case
otherwise client would wait for reply forever and desktop appears hang.
Signed-off-by: Flora Cui <flora.cui@amd.com>
diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
index 44316ac..bb3d9d0 100644
--- a/src/amdgpu_dri2.c
+++ b/src/amdgpu_dri2.c
@@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr
client, DrawablePtr draw,
out_complete:
if (wait_info)
amdgpu_dri2_deferred_event(NULL, 0, wait_info);
+ else
+ DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
+
return TRUE;
}
在 5/29/2019 2:36 PM, Cui, Flora 写道:
> otherwise client would wait for reply forever and desktop appears hang.
>
> Signed-off-by: Flora Cui <flora.cui@amd.com>
> ---
> src/amdgpu_dri2.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
> index 44316ac..34353a7 100644
> --- a/src/amdgpu_dri2.c
> +++ b/src/amdgpu_dri2.c
> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw,
> out_complete:
> if (wait_info)
> amdgpu_dri2_deferred_event(NULL, 0, wait_info);
> +
> + DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
> +
> return TRUE;
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v2] dri2: reply to client for WaitMSC request in any case
[not found] ` <bc4571fc-6521-74d7-2d5c-1665396b50fc-5C7GfCeVMHo@public.gmane.org>
@ 2019-06-03 7:27 ` Xu, Feifei
2019-06-03 7:59 ` Ernst Sjöstrand
1 sibling, 0 replies; 6+ messages in thread
From: Xu, Feifei @ 2019-06-03 7:27 UTC (permalink / raw)
To: Cui, Flora
Acked-by: Feifei Xu <Feifei.Xu@amd.com>
Regards,
Feifei
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Cui, Flora
Sent: 2019年6月3日 15:26
To: Cui, Flora <Flora.Cui@amd.com>; Daenzer, Michel <Michel.Daenzer@amd.com>; amd-gfx@lists.freedesktop.org
Subject: [PATCH v2] dri2: reply to client for WaitMSC request in any case
ping...
commit 47613e8e8f4a5e3b25830e3c015a4a217fcbe469
Author: Flora Cui <flora.cui@amd.com>
Date: Wed May 29 14:18:50 2019 +0800
dri2: reply to client for WaitMSC request in any case
otherwise client would wait for reply forever and desktop appears hang.
Signed-off-by: Flora Cui <flora.cui@amd.com>
diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c index 44316ac..bb3d9d0 100644
--- a/src/amdgpu_dri2.c
+++ b/src/amdgpu_dri2.c
@@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr
client, DrawablePtr draw,
out_complete:
if (wait_info)
amdgpu_dri2_deferred_event(NULL, 0, wait_info);
+ else
+ DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
+
return TRUE;
}
在 5/29/2019 2:36 PM, Cui, Flora 写道:
> otherwise client would wait for reply forever and desktop appears hang.
>
> Signed-off-by: Flora Cui <flora.cui@amd.com>
> ---
> src/amdgpu_dri2.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c index
> 44316ac..34353a7 100644
> --- a/src/amdgpu_dri2.c
> +++ b/src/amdgpu_dri2.c
> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw,
> out_complete:
> if (wait_info)
> amdgpu_dri2_deferred_event(NULL, 0, wait_info);
> +
> + DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
> +
> return TRUE;
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dri2: reply to client for WaitMSC request in any case
[not found] ` <1559111780-32513-1-git-send-email-flora.cui-5C7GfCeVMHo@public.gmane.org>
2019-06-03 7:26 ` [PATCH v2] " Cui, Flora
@ 2019-06-03 7:56 ` Michel Dänzer
1 sibling, 0 replies; 6+ messages in thread
From: Michel Dänzer @ 2019-06-03 7:56 UTC (permalink / raw)
To: Cui, Flora; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2019-05-29 8:36 a.m., Cui, Flora wrote:
> otherwise client would wait for reply forever and desktop appears hang.
>
> Signed-off-by: Flora Cui <flora.cui@amd.com>
> ---
> src/amdgpu_dri2.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
> index 44316ac..34353a7 100644
> --- a/src/amdgpu_dri2.c
> +++ b/src/amdgpu_dri2.c
> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw,
> out_complete:
> if (wait_info)
> amdgpu_dri2_deferred_event(NULL, 0, wait_info);
> +
> + DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
> +
> return TRUE;
> }
>
>
Please create a merge request:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/merge_requests/new
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dri2: reply to client for WaitMSC request in any case
[not found] ` <bc4571fc-6521-74d7-2d5c-1665396b50fc-5C7GfCeVMHo@public.gmane.org>
2019-06-03 7:27 ` Xu, Feifei
@ 2019-06-03 7:59 ` Ernst Sjöstrand
[not found] ` <CAD=4a=VXK_2yt1S-FFMucFGxjG7M3-cE6rxi7qP=2qe8p1WSkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
1 sibling, 1 reply; 6+ messages in thread
From: Ernst Sjöstrand @ 2019-06-03 7:59 UTC (permalink / raw)
To: Cui, Flora
Cc: Cui, Flora, Daenzer, Michel, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
This looks like a v2 with silightly different semantics?
Den mån 3 juni 2019 kl 09:26 skrev Cui, Flora <fcui@amd.com>:
>
> ping...
>
> commit 47613e8e8f4a5e3b25830e3c015a4a217fcbe469
> Author: Flora Cui <flora.cui@amd.com>
> Date: Wed May 29 14:18:50 2019 +0800
>
> dri2: reply to client for WaitMSC request in any case
>
> otherwise client would wait for reply forever and desktop appears hang.
>
> Signed-off-by: Flora Cui <flora.cui@amd.com>
>
> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
> index 44316ac..bb3d9d0 100644
> --- a/src/amdgpu_dri2.c
> +++ b/src/amdgpu_dri2.c
> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr
> client, DrawablePtr draw,
> out_complete:
> if (wait_info)
> amdgpu_dri2_deferred_event(NULL, 0, wait_info);
> + else
> + DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
> +
> return TRUE;
> }
>
> 在 5/29/2019 2:36 PM, Cui, Flora 写道:
> > otherwise client would wait for reply forever and desktop appears hang.
> >
> > Signed-off-by: Flora Cui <flora.cui@amd.com>
> > ---
> > src/amdgpu_dri2.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
> > index 44316ac..34353a7 100644
> > --- a/src/amdgpu_dri2.c
> > +++ b/src/amdgpu_dri2.c
> > @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw,
> > out_complete:
> > if (wait_info)
> > amdgpu_dri2_deferred_event(NULL, 0, wait_info);
> > +
> > + DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
> > +
> > return TRUE;
> > }
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dri2: reply to client for WaitMSC request in any case
[not found] ` <CAD=4a=VXK_2yt1S-FFMucFGxjG7M3-cE6rxi7qP=2qe8p1WSkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2019-06-03 8:07 ` Cui, Flora
0 siblings, 0 replies; 6+ messages in thread
From: Cui, Flora @ 2019-06-03 8:07 UTC (permalink / raw)
To: Ernst Sjöstrand
Cc: Cui, Flora, Daenzer, Michel, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Yes. It's v2 and change the behavior slightly.
It send reply to client with no wait_info for
amdgpu_dri2_deferred_event() would handle the reply differently.
在 6/3/2019 3:59 PM, Ernst Sjöstrand 写道:
> This looks like a v2 with silightly different semantics?
>
> Den mån 3 juni 2019 kl 09:26 skrev Cui, Flora <fcui@amd.com>:
>> ping...
>>
>> commit 47613e8e8f4a5e3b25830e3c015a4a217fcbe469
>> Author: Flora Cui <flora.cui@amd.com>
>> Date: Wed May 29 14:18:50 2019 +0800
>>
>> dri2: reply to client for WaitMSC request in any case
>>
>> otherwise client would wait for reply forever and desktop appears hang.
>>
>> Signed-off-by: Flora Cui <flora.cui@amd.com>
>>
>> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
>> index 44316ac..bb3d9d0 100644
>> --- a/src/amdgpu_dri2.c
>> +++ b/src/amdgpu_dri2.c
>> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr
>> client, DrawablePtr draw,
>> out_complete:
>> if (wait_info)
>> amdgpu_dri2_deferred_event(NULL, 0, wait_info);
>> + else
>> + DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
>> +
>> return TRUE;
>> }
>>
>> 在 5/29/2019 2:36 PM, Cui, Flora 写道:
>>> otherwise client would wait for reply forever and desktop appears hang.
>>>
>>> Signed-off-by: Flora Cui <flora.cui@amd.com>
>>> ---
>>> src/amdgpu_dri2.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
>>> index 44316ac..34353a7 100644
>>> --- a/src/amdgpu_dri2.c
>>> +++ b/src/amdgpu_dri2.c
>>> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw,
>>> out_complete:
>>> if (wait_info)
>>> amdgpu_dri2_deferred_event(NULL, 0, wait_info);
>>> +
>>> + DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
>>> +
>>> return TRUE;
>>> }
>>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-03 8:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 6:36 [PATCH] dri2: reply to client for WaitMSC request in any case Cui, Flora
[not found] ` <1559111780-32513-1-git-send-email-flora.cui-5C7GfCeVMHo@public.gmane.org>
2019-06-03 7:26 ` [PATCH v2] " Cui, Flora
[not found] ` <bc4571fc-6521-74d7-2d5c-1665396b50fc-5C7GfCeVMHo@public.gmane.org>
2019-06-03 7:27 ` Xu, Feifei
2019-06-03 7:59 ` Ernst Sjöstrand
[not found] ` <CAD=4a=VXK_2yt1S-FFMucFGxjG7M3-cE6rxi7qP=2qe8p1WSkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-03 8:07 ` Cui, Flora
2019-06-03 7:56 ` [PATCH] " Michel Dänzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.