All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [bug report] drm/i915: Move context management under GEM
Date: Wed, 06 Nov 2019 15:08:13 +0000	[thread overview]
Message-ID: <157305289377.26738.4641408741937503091@skylake-alporthouse-com> (raw)
In-Reply-To: <20191106134814.GA23187@mwanda>

Quoting Dan Carpenter (2019-11-06 13:48:14)
> Hello Chris Wilson,
> 
> The patch a4e7ccdac38e: "drm/i915: Move context management under GEM"
> from Oct 4, 2019, leads to the following static checker warning:
> 
>         drivers/gpu/drm/i915/gem/i915_gem_context.c:980 set_ppgtt()
>         warn: 'ctx->mutex' both locked and unlocked.
> 
> drivers/gpu/drm/i915/gem/i915_gem_context.c
>    940          rcu_read_unlock();
>    941          if (!vm)
>    942                  return -ENOENT;
>    943  
>    944          err = mutex_lock_interruptible(&ctx->mutex);
>    945          if (err)
>    946                  goto out;
>    947  
>    948          if (i915_gem_context_is_closed(ctx)) {
>    949                  err = -ENOENT;
>    950                  goto out;
>                         ^^^^^^^^
> This should be goto unlock?
 
Yes. Many thanks for the bug report.
https://patchwork.freedesktop.org/patch/339213/?series=69070&rev=1
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [bug report] drm/i915: Move context management under GEM
Date: Wed, 06 Nov 2019 15:08:13 +0000	[thread overview]
Message-ID: <157305289377.26738.4641408741937503091@skylake-alporthouse-com> (raw)
Message-ID: <20191106150813.jMorGsHiDaBKNu_o7ACHA_BHfRxdYvdKtNRzmiFwzd4@z> (raw)
In-Reply-To: <20191106134814.GA23187@mwanda>

Quoting Dan Carpenter (2019-11-06 13:48:14)
> Hello Chris Wilson,
> 
> The patch a4e7ccdac38e: "drm/i915: Move context management under GEM"
> from Oct 4, 2019, leads to the following static checker warning:
> 
>         drivers/gpu/drm/i915/gem/i915_gem_context.c:980 set_ppgtt()
>         warn: 'ctx->mutex' both locked and unlocked.
> 
> drivers/gpu/drm/i915/gem/i915_gem_context.c
>    940          rcu_read_unlock();
>    941          if (!vm)
>    942                  return -ENOENT;
>    943  
>    944          err = mutex_lock_interruptible(&ctx->mutex);
>    945          if (err)
>    946                  goto out;
>    947  
>    948          if (i915_gem_context_is_closed(ctx)) {
>    949                  err = -ENOENT;
>    950                  goto out;
>                         ^^^^^^^^
> This should be goto unlock?
 
Yes. Many thanks for the bug report.
https://patchwork.freedesktop.org/patch/339213/?series=69070&rev=1
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-11-06 15:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 13:48 [bug report] drm/i915: Move context management under GEM Dan Carpenter
2019-11-06 13:48 ` [Intel-gfx] " Dan Carpenter
2019-11-06 15:08 ` Chris Wilson [this message]
2019-11-06 15:08   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157305289377.26738.4641408741937503091@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=dan.carpenter@oracle.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.