From: no-reply@patchew.org To: vsementsov@virtuozzo.com Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, mdroth@linux.vnet.ibm.com, qemu-block@nongnu.org, paul@xen.org, philmd@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, sstabellini@kernel.org, kraxel@redhat.com, stefanha@redhat.com, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, mreitz@redhat.com, lersek@redhat.com, armbru@redhat.com, stefanb@linux.ibm.com Subject: Re: [Xen-devel] [PATCH v6 00/11] error: auto propagated local_err part I Date: Fri, 10 Jan 2020 12:22:31 -0800 (PST) [thread overview] Message-ID: <157868774947.15422.14658847667190512659@37313f22b938> (raw) In-Reply-To: <20200110194158.14190-1-vsementsov@virtuozzo.com> Patchew URL: https://patchew.org/QEMU/20200110194158.14190-1-vsementsov@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Xen-devel] [PATCH v6 00/11] error: auto propagated local_err part I Type: series Message-id: 20200110194158.14190-1-vsementsov@virtuozzo.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' fee0dd2 xen: introduce ERRP_AUTO_PROPAGATE 9074b45 nbd: introduce ERRP_AUTO_PROPAGATE 05632cb TPM: introduce ERRP_AUTO_PROPAGATE 2a019cd virtio-9p: introduce ERRP_AUTO_PROPAGATE b4e0525 fw_cfg: introduce ERRP_AUTO_PROPAGATE 3a69800 pflash: introduce ERRP_AUTO_PROPAGATE f4ac870 SD (Secure Card): introduce ERRP_AUTO_PROPAGATE 29fbc1d hw/sd/ssi-sd: fix error handling in ssi_sd_realize 6ebc57a scripts: add coccinelle script to use auto propagated errp 477b9ec error: auto propagated local_err 0c38914 qapi/error: add (Error **errp) cleaning APIs === OUTPUT BEGIN === 1/11 Checking commit 0c389147591a (qapi/error: add (Error **errp) cleaning APIs) 2/11 Checking commit 477b9ec03898 (error: auto propagated local_err) ERROR: Macros with multiple statements should be enclosed in a do - while loop #138: FILE: include/qapi/error.h:428: +#define ERRP_AUTO_PROPAGATE() \ + g_auto(ErrorPropagator) _auto_errp_prop = {.errp = errp}; \ + errp = ((errp == NULL || *errp == error_fatal) \ + ? &_auto_errp_prop.local_err : errp) total: 1 errors, 0 warnings, 102 lines checked Patch 2/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/11 Checking commit 6ebc57a94cf0 (scripts: add coccinelle script to use auto propagated errp) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 148 lines checked Patch 3/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/11 Checking commit 29fbc1d61eb1 (hw/sd/ssi-sd: fix error handling in ssi_sd_realize) 5/11 Checking commit f4ac87065f2c (SD (Secure Card): introduce ERRP_AUTO_PROPAGATE) 6/11 Checking commit 3a69800331a4 (pflash: introduce ERRP_AUTO_PROPAGATE) 7/11 Checking commit b4e0525d3dcf (fw_cfg: introduce ERRP_AUTO_PROPAGATE) 8/11 Checking commit 2a019cd1f992 (virtio-9p: introduce ERRP_AUTO_PROPAGATE) 9/11 Checking commit 05632cbe2d39 (TPM: introduce ERRP_AUTO_PROPAGATE) 10/11 Checking commit 9074b450cb34 (nbd: introduce ERRP_AUTO_PROPAGATE) 11/11 Checking commit fee0dd26ea0b (xen: introduce ERRP_AUTO_PROPAGATE) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200110194158.14190-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: no-reply@patchew.org To: vsementsov@virtuozzo.com Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, mdroth@linux.vnet.ibm.com, qemu-block@nongnu.org, paul@xen.org, philmd@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com, groug@kaod.org, sstabellini@kernel.org, kraxel@redhat.com, stefanha@redhat.com, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, mreitz@redhat.com, lersek@redhat.com, armbru@redhat.com, stefanb@linux.ibm.com Subject: Re: [Xen-devel] [PATCH v6 00/11] error: auto propagated local_err part I Date: Fri, 10 Jan 2020 12:22:31 -0800 (PST) [thread overview] Message-ID: <157868774947.15422.14658847667190512659@37313f22b938> (raw) In-Reply-To: <20200110194158.14190-1-vsementsov@virtuozzo.com> Patchew URL: https://patchew.org/QEMU/20200110194158.14190-1-vsementsov@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Xen-devel] [PATCH v6 00/11] error: auto propagated local_err part I Type: series Message-id: 20200110194158.14190-1-vsementsov@virtuozzo.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' fee0dd2 xen: introduce ERRP_AUTO_PROPAGATE 9074b45 nbd: introduce ERRP_AUTO_PROPAGATE 05632cb TPM: introduce ERRP_AUTO_PROPAGATE 2a019cd virtio-9p: introduce ERRP_AUTO_PROPAGATE b4e0525 fw_cfg: introduce ERRP_AUTO_PROPAGATE 3a69800 pflash: introduce ERRP_AUTO_PROPAGATE f4ac870 SD (Secure Card): introduce ERRP_AUTO_PROPAGATE 29fbc1d hw/sd/ssi-sd: fix error handling in ssi_sd_realize 6ebc57a scripts: add coccinelle script to use auto propagated errp 477b9ec error: auto propagated local_err 0c38914 qapi/error: add (Error **errp) cleaning APIs === OUTPUT BEGIN === 1/11 Checking commit 0c389147591a (qapi/error: add (Error **errp) cleaning APIs) 2/11 Checking commit 477b9ec03898 (error: auto propagated local_err) ERROR: Macros with multiple statements should be enclosed in a do - while loop #138: FILE: include/qapi/error.h:428: +#define ERRP_AUTO_PROPAGATE() \ + g_auto(ErrorPropagator) _auto_errp_prop = {.errp = errp}; \ + errp = ((errp == NULL || *errp == error_fatal) \ + ? &_auto_errp_prop.local_err : errp) total: 1 errors, 0 warnings, 102 lines checked Patch 2/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/11 Checking commit 6ebc57a94cf0 (scripts: add coccinelle script to use auto propagated errp) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 148 lines checked Patch 3/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/11 Checking commit 29fbc1d61eb1 (hw/sd/ssi-sd: fix error handling in ssi_sd_realize) 5/11 Checking commit f4ac87065f2c (SD (Secure Card): introduce ERRP_AUTO_PROPAGATE) 6/11 Checking commit 3a69800331a4 (pflash: introduce ERRP_AUTO_PROPAGATE) 7/11 Checking commit b4e0525d3dcf (fw_cfg: introduce ERRP_AUTO_PROPAGATE) 8/11 Checking commit 2a019cd1f992 (virtio-9p: introduce ERRP_AUTO_PROPAGATE) 9/11 Checking commit 05632cbe2d39 (TPM: introduce ERRP_AUTO_PROPAGATE) 10/11 Checking commit 9074b450cb34 (nbd: introduce ERRP_AUTO_PROPAGATE) 11/11 Checking commit fee0dd26ea0b (xen: introduce ERRP_AUTO_PROPAGATE) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200110194158.14190-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-10 20:24 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-10 19:41 [PATCH v6 00/11] error: auto propagated local_err part I Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [PATCH v6 01/11] qapi/error: add (Error **errp) cleaning APIs Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-15 7:46 ` Greg Kurz 2020-01-15 7:46 ` [Xen-devel] " Greg Kurz 2020-01-17 13:15 ` Eric Blake 2020-01-17 13:15 ` [Xen-devel] " Eric Blake 2020-01-10 19:41 ` [PATCH v6 02/11] error: auto propagated local_err Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-13 8:50 ` Paul Durrant 2020-01-13 8:50 ` [Xen-devel] " Paul Durrant 2020-01-13 9:25 ` Vladimir Sementsov-Ogievskiy 2020-01-13 9:25 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-15 18:33 ` Greg Kurz 2020-01-15 18:33 ` [Xen-devel] " Greg Kurz 2020-01-17 14:18 ` Eric Blake 2020-01-17 14:18 ` [Xen-devel] " Eric Blake 2020-01-10 19:41 ` [PATCH v6 03/11] scripts: add coccinelle script to use auto propagated errp Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-17 14:24 ` Eric Blake 2020-01-17 14:24 ` [Xen-devel] " Eric Blake 2020-01-17 14:50 ` Vladimir Sementsov-Ogievskiy 2020-01-17 14:50 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [PATCH v6 04/11] hw/sd/ssi-sd: fix error handling in ssi_sd_realize Vladimir Sementsov-Ogievskiy 2020-01-17 14:26 ` Eric Blake 2020-01-10 19:41 ` [PATCH v6 05/11] SD (Secure Card): introduce ERRP_AUTO_PROPAGATE Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [PATCH v6 06/11] pflash: " Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [PATCH v6 07/11] fw_cfg: " Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [PATCH v6 08/11] virtio-9p: " Vladimir Sementsov-Ogievskiy 2020-01-13 10:40 ` Greg Kurz 2020-01-10 19:41 ` [PATCH v6 09/11] TPM: " Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [PATCH v6 10/11] nbd: " Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [PATCH v6 11/11] xen: " Vladimir Sementsov-Ogievskiy 2020-01-10 19:41 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-13 8:57 ` Paul Durrant 2020-01-13 8:57 ` [Xen-devel] " Paul Durrant 2020-01-13 9:25 ` Vladimir Sementsov-Ogievskiy 2020-01-13 9:25 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-10 20:22 ` no-reply [this message] 2020-01-10 20:22 ` [Xen-devel] [PATCH v6 00/11] error: auto propagated local_err part I no-reply 2020-01-30 12:36 ` Vladimir Sementsov-Ogievskiy 2020-01-30 12:36 ` [Xen-devel] " Vladimir Sementsov-Ogievskiy 2020-01-30 16:50 ` Markus Armbruster 2020-01-30 16:50 ` [Xen-devel] " Markus Armbruster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=157868774947.15422.14658847667190512659@37313f22b938 \ --to=no-reply@patchew.org \ --cc=anthony.perard@citrix.com \ --cc=armbru@redhat.com \ --cc=cohuck@redhat.com \ --cc=groug@kaod.org \ --cc=kraxel@redhat.com \ --cc=kwolf@redhat.com \ --cc=lersek@redhat.com \ --cc=mdroth@linux.vnet.ibm.com \ --cc=mreitz@redhat.com \ --cc=paul@xen.org \ --cc=philmd@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=stefanb@linux.ibm.com \ --cc=stefanha@redhat.com \ --cc=vsementsov@virtuozzo.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.