All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Fix iotest 153
@ 2020-05-04 13:19 Maxim Levitsky
  2020-05-04 13:55 ` Max Reitz
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Maxim Levitsky @ 2020-05-04 13:19 UTC (permalink / raw)
  To: qemu-devel
  Cc: Kevin Wolf, Maxim Levitsky, Markus Armbruster, qemu-block, Max Reitz

Commit f62514b3def5fb2acbef64d0e053c0c31fa45aff made qemu-img reject -o "" but this test uses it.
Since this test only tries to do a dry-run run of qemu-img amend,
replace the -o "" with dummy -o "size=$size".

Fixes: f62514b3def5fb2acbef64d0e053c0c31fa45aff

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
 tests/qemu-iotests/153     |  2 +-
 tests/qemu-iotests/153.out | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153
index 2b13111768..cf961d3609 100755
--- a/tests/qemu-iotests/153
+++ b/tests/qemu-iotests/153
@@ -122,7 +122,7 @@ for opts1 in "" "read-only=on" "read-only=on,force-share=on"; do
         _run_cmd $QEMU_IMG check       $L "${TEST_IMG}"
         _run_cmd $QEMU_IMG compare     $L "${TEST_IMG}" "${TEST_IMG}"
         _run_cmd $QEMU_IMG map         $L "${TEST_IMG}"
-        _run_cmd $QEMU_IMG amend -o "" $L "${TEST_IMG}"
+        _run_cmd $QEMU_IMG amend -o "size=$size" $L "${TEST_IMG}"
         _run_cmd $QEMU_IMG commit      $L "${TEST_IMG}"
         _run_cmd $QEMU_IMG resize      $L "${TEST_IMG}" $size
         _run_cmd $QEMU_IMG rebase      $L "${TEST_IMG}" -b "${TEST_IMG}.base"
diff --git a/tests/qemu-iotests/153.out b/tests/qemu-iotests/153.out
index f7464dd8d3..b2a90caa6b 100644
--- a/tests/qemu-iotests/153.out
+++ b/tests/qemu-iotests/153.out
@@ -56,7 +56,7 @@ _qemu_img_wrapper map TEST_DIR/t.qcow2
 qemu-img: Could not open 'TEST_DIR/t.qcow2': Failed to get shared "write" lock
 Is another process using the image [TEST_DIR/t.qcow2]?
 
-_qemu_img_wrapper amend -o  TEST_DIR/t.qcow2
+_qemu_img_wrapper amend -o size=32M TEST_DIR/t.qcow2
 qemu-img: Could not open 'TEST_DIR/t.qcow2': Failed to get "write" lock
 Is another process using the image [TEST_DIR/t.qcow2]?
 
@@ -118,7 +118,7 @@ _qemu_img_wrapper compare -U TEST_DIR/t.qcow2 TEST_DIR/t.qcow2
 
 _qemu_img_wrapper map -U TEST_DIR/t.qcow2
 
-_qemu_img_wrapper amend -o  -U TEST_DIR/t.qcow2
+_qemu_img_wrapper amend -o size=32M -U TEST_DIR/t.qcow2
 qemu-img: unrecognized option '-U'
 Try 'qemu-img --help' for more information
 
@@ -187,7 +187,7 @@ _qemu_img_wrapper compare TEST_DIR/t.qcow2 TEST_DIR/t.qcow2
 
 _qemu_img_wrapper map TEST_DIR/t.qcow2
 
-_qemu_img_wrapper amend -o  TEST_DIR/t.qcow2
+_qemu_img_wrapper amend -o size=32M TEST_DIR/t.qcow2
 qemu-img: Could not open 'TEST_DIR/t.qcow2': Failed to get "write" lock
 Is another process using the image [TEST_DIR/t.qcow2]?
 
@@ -241,7 +241,7 @@ _qemu_img_wrapper compare -U TEST_DIR/t.qcow2 TEST_DIR/t.qcow2
 
 _qemu_img_wrapper map -U TEST_DIR/t.qcow2
 
-_qemu_img_wrapper amend -o  -U TEST_DIR/t.qcow2
+_qemu_img_wrapper amend -o size=32M -U TEST_DIR/t.qcow2
 qemu-img: unrecognized option '-U'
 Try 'qemu-img --help' for more information
 
@@ -303,7 +303,7 @@ _qemu_img_wrapper compare TEST_DIR/t.qcow2 TEST_DIR/t.qcow2
 
 _qemu_img_wrapper map TEST_DIR/t.qcow2
 
-_qemu_img_wrapper amend -o  TEST_DIR/t.qcow2
+_qemu_img_wrapper amend -o size=32M TEST_DIR/t.qcow2
 
 _qemu_img_wrapper commit TEST_DIR/t.qcow2
 
@@ -345,7 +345,7 @@ _qemu_img_wrapper compare -U TEST_DIR/t.qcow2 TEST_DIR/t.qcow2
 
 _qemu_img_wrapper map -U TEST_DIR/t.qcow2
 
-_qemu_img_wrapper amend -o  -U TEST_DIR/t.qcow2
+_qemu_img_wrapper amend -o size=32M -U TEST_DIR/t.qcow2
 qemu-img: unrecognized option '-U'
 Try 'qemu-img --help' for more information
 
-- 
2.17.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] Fix iotest 153
  2020-05-04 13:19 [PATCH v2] Fix iotest 153 Maxim Levitsky
@ 2020-05-04 13:55 ` Max Reitz
  2020-05-04 13:56   ` Maxim Levitsky
  2020-05-05  8:16 ` no-reply
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Max Reitz @ 2020-05-04 13:55 UTC (permalink / raw)
  To: Maxim Levitsky, qemu-devel; +Cc: Kevin Wolf, Markus Armbruster, qemu-block


[-- Attachment #1.1: Type: text/plain, Size: 632 bytes --]

On 04.05.20 15:19, Maxim Levitsky wrote:
> Commit f62514b3def5fb2acbef64d0e053c0c31fa45aff made qemu-img reject -o "" but this test uses it.
> Since this test only tries to do a dry-run run of qemu-img amend,
> replace the -o "" with dummy -o "size=$size".
> 
> Fixes: f62514b3def5fb2acbef64d0e053c0c31fa45aff
> 
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
>  tests/qemu-iotests/153     |  2 +-
>  tests/qemu-iotests/153.out | 12 ++++++------
>  2 files changed, 7 insertions(+), 7 deletions(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] Fix iotest 153
  2020-05-04 13:55 ` Max Reitz
@ 2020-05-04 13:56   ` Maxim Levitsky
  0 siblings, 0 replies; 6+ messages in thread
From: Maxim Levitsky @ 2020-05-04 13:56 UTC (permalink / raw)
  To: Max Reitz, qemu-devel; +Cc: Kevin Wolf, Markus Armbruster, qemu-block

On Mon, 2020-05-04 at 15:55 +0200, Max Reitz wrote:
> On 04.05.20 15:19, Maxim Levitsky wrote:
> > Commit f62514b3def5fb2acbef64d0e053c0c31fa45aff made qemu-img reject -o "" but this test uses it.
> > Since this test only tries to do a dry-run run of qemu-img amend,
> > replace the -o "" with dummy -o "size=$size".
> > 
> > Fixes: f62514b3def5fb2acbef64d0e053c0c31fa45aff
> > 
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> > ---
> >  tests/qemu-iotests/153     |  2 +-
> >  tests/qemu-iotests/153.out | 12 ++++++------
> >  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> Thanks, applied to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 
> Max
> 
Thanks!
Best regards,
	Maxim Levitsky



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] Fix iotest 153
  2020-05-04 13:19 [PATCH v2] Fix iotest 153 Maxim Levitsky
  2020-05-04 13:55 ` Max Reitz
@ 2020-05-05  8:16 ` no-reply
  2020-05-05  8:17 ` no-reply
  2020-05-05  9:18 ` no-reply
  3 siblings, 0 replies; 6+ messages in thread
From: no-reply @ 2020-05-05  8:16 UTC (permalink / raw)
  To: mlevitsk; +Cc: kwolf, qemu-block, qemu-devel, armbru, mreitz, mlevitsk

Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevitsk@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200504131959.9533-1-mlevitsk@redhat.com
Subject: [PATCH v2] Fix iotest 153
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
fatal: unable to write new index file
Traceback (most recent call last):
  File "patchew-tester/src/patchew-cli", line 521, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester/src/patchew-cli", line 57, in git_clone_repo
    cwd=clone)
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'checkout', 'refs/tags/patchew/20200504131959.9533-1-mlevitsk@redhat.com', '-b', 'test']' returned non-zero exit status 128.



The full log is available at
http://patchew.org/logs/20200504131959.9533-1-mlevitsk@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] Fix iotest 153
  2020-05-04 13:19 [PATCH v2] Fix iotest 153 Maxim Levitsky
  2020-05-04 13:55 ` Max Reitz
  2020-05-05  8:16 ` no-reply
@ 2020-05-05  8:17 ` no-reply
  2020-05-05  9:18 ` no-reply
  3 siblings, 0 replies; 6+ messages in thread
From: no-reply @ 2020-05-05  8:17 UTC (permalink / raw)
  To: mlevitsk; +Cc: kwolf, qemu-block, qemu-devel, armbru, mreitz, mlevitsk

Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevitsk@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20200504131959.9533-1-mlevitsk@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] Fix iotest 153
  2020-05-04 13:19 [PATCH v2] Fix iotest 153 Maxim Levitsky
                   ` (2 preceding siblings ...)
  2020-05-05  8:17 ` no-reply
@ 2020-05-05  9:18 ` no-reply
  3 siblings, 0 replies; 6+ messages in thread
From: no-reply @ 2020-05-05  9:18 UTC (permalink / raw)
  To: mlevitsk; +Cc: kwolf, qemu-block, qemu-devel, armbru, mreitz, mlevitsk

Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevitsk@redhat.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20200504131959.9533-1-mlevitsk@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-05  9:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 13:19 [PATCH v2] Fix iotest 153 Maxim Levitsky
2020-05-04 13:55 ` Max Reitz
2020-05-04 13:56   ` Maxim Levitsky
2020-05-05  8:16 ` no-reply
2020-05-05  8:17 ` no-reply
2020-05-05  9:18 ` no-reply

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.