* [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset
@ 2020-04-30 12:17 Jason Yan
2020-04-30 13:17 ` himanshu.madhani
2020-05-08 2:54 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-30 12:17 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
himanshu.madhani, aeasi, linux-scsi, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/scsi/qla2xxx/qla_tmpl.c:1031:6-20: WARNING: Assignment of 0/1 to
bool variable
drivers/scsi/qla2xxx/qla_tmpl.c:1062:3-17: WARNING: Assignment of 0/1 to
bool variable
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/qla2xxx/qla_tmpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
index 819c46f31c05..281973b317a8 100644
--- a/drivers/scsi/qla2xxx/qla_tmpl.c
+++ b/drivers/scsi/qla2xxx/qla_tmpl.c
@@ -1028,7 +1028,7 @@ void
qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
{
ulong flags = 0;
- bool need_mpi_reset = 1;
+ bool need_mpi_reset = true;
#ifndef __CHECKER__
if (!hardware_locked)
@@ -1059,7 +1059,7 @@ qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
"-> fwdt1 fwdump residual=%+ld\n",
fwdt->dump_size - len);
} else {
- need_mpi_reset = 0;
+ need_mpi_reset = false;
}
vha->hw->mpi_fw_dump_len = len;
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset
2020-04-30 12:17 [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset Jason Yan
@ 2020-04-30 13:17 ` himanshu.madhani
2020-05-08 2:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: himanshu.madhani @ 2020-04-30 13:17 UTC (permalink / raw)
To: Jason Yan, njavali, GR-QLogic-Storage-Upstream, jejb,
martin.petersen, aeasi, linux-scsi, linux-kernel
On 4/30/20 7:17 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_tmpl.c:1031:6-20: WARNING: Assignment of 0/1 to
> bool variable
> drivers/scsi/qla2xxx/qla_tmpl.c:1062:3-17: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/qla2xxx/qla_tmpl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
> index 819c46f31c05..281973b317a8 100644
> --- a/drivers/scsi/qla2xxx/qla_tmpl.c
> +++ b/drivers/scsi/qla2xxx/qla_tmpl.c
> @@ -1028,7 +1028,7 @@ void
> qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
> {
> ulong flags = 0;
> - bool need_mpi_reset = 1;
> + bool need_mpi_reset = true;
>
> #ifndef __CHECKER__
> if (!hardware_locked)
> @@ -1059,7 +1059,7 @@ qla27xx_mpi_fwdump(scsi_qla_host_t *vha, int hardware_locked)
> "-> fwdt1 fwdump residual=%+ld\n",
> fwdt->dump_size - len);
> } else {
> - need_mpi_reset = 0;
> + need_mpi_reset = false;
> }
>
> vha->hw->mpi_fw_dump_len = len;
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani
Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset
2020-04-30 12:17 [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset Jason Yan
2020-04-30 13:17 ` himanshu.madhani
@ 2020-05-08 2:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-05-08 2:54 UTC (permalink / raw)
To: jejb, Jason Yan, njavali, himanshu.madhani,
GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, aeasi
Cc: Martin K . Petersen
On Thu, 30 Apr 2020 20:17:51 +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_tmpl.c:1031:6-20: WARNING: Assignment of 0/1 to
> bool variable
> drivers/scsi/qla2xxx/qla_tmpl.c:1062:3-17: WARNING: Assignment of 0/1 to
> bool variable
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Use true, false for need_mpi_reset
https://git.kernel.org/mkp/scsi/c/bda552a7741a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-08 2:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 12:17 [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset Jason Yan
2020-04-30 13:17 ` himanshu.madhani
2020-05-08 2:54 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.