* [linux-next:master 8165/9362] drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev'
@ 2020-05-14 18:35 kbuild test robot
2020-05-14 18:58 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2020-05-14 18:35 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2906 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c9529331c7a22b8eb7eb03e1e0e221d0f58b43de
commit: 8a226e2c71bb3763e27a063d36eac5fa4ea53c3f [8165/9362] remoteproc: wcss: add support for rpmsg communication
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8a226e2c71bb3763e27a063d36eac5fa4ea53c3f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_probe':
>> drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev'
563 | qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
| ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/remoteproc/qcom_q6v5_wcss.c:16:
drivers/remoteproc/qcom_common.h:35:6: note: declared here
35 | void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink,
| ^~~~~~~~~~~~~~~~~~~~~
vim +/qcom_add_glink_subdev +563 drivers/remoteproc/qcom_q6v5_wcss.c
530
531 static int q6v5_wcss_probe(struct platform_device *pdev)
532 {
533 struct q6v5_wcss *wcss;
534 struct rproc *rproc;
535 int ret;
536
537 rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_wcss_ops,
538 "IPQ8074/q6_fw.mdt", sizeof(*wcss));
539 if (!rproc) {
540 dev_err(&pdev->dev, "failed to allocate rproc\n");
541 return -ENOMEM;
542 }
543
544 wcss = rproc->priv;
545 wcss->dev = &pdev->dev;
546
547 ret = q6v5_wcss_init_mmio(wcss, pdev);
548 if (ret)
549 goto free_rproc;
550
551 ret = q6v5_alloc_memory_region(wcss);
552 if (ret)
553 goto free_rproc;
554
555 ret = q6v5_wcss_init_reset(wcss);
556 if (ret)
557 goto free_rproc;
558
559 ret = qcom_q6v5_init(&wcss->q6v5, pdev, rproc, WCSS_CRASH_REASON, NULL);
560 if (ret)
561 goto free_rproc;
562
> 563 qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
564 qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss");
565
566 ret = rproc_add(rproc);
567 if (ret)
568 goto free_rproc;
569
570 platform_set_drvdata(pdev, rproc);
571
572 return 0;
573
574 free_rproc:
575 rproc_free(rproc);
576
577 return ret;
578 }
579
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73955 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] remoteproc: wcss: Fix arguments passed to qcom_add_glink_subdev()
2020-05-14 18:35 [linux-next:master 8165/9362] drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev' kbuild test robot
@ 2020-05-14 18:58 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-05-14 18:58 UTC (permalink / raw)
To: Bjorn Andersson, Ohad Ben-Cohen, Sivaprakash Murugesan
Cc: linux-arm-msm, linux-remoteproc, linux-kernel, kbuild-all,
kbuild test robot
Recently qcom_add_glink_subdev() was extended to also take the glink_ssr
identifier as an argument and I missed this while applying '8a226e2c71bb
("remoteproc: wcss: add support for rpmsg communication")'.
Fixes: 8a226e2c71bb ("remoteproc: wcss: add support for rpmsg communication")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/remoteproc/qcom_q6v5_wcss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
index 48d16d81f94d..88c76b9417fa 100644
--- a/drivers/remoteproc/qcom_q6v5_wcss.c
+++ b/drivers/remoteproc/qcom_q6v5_wcss.c
@@ -560,7 +560,7 @@ static int q6v5_wcss_probe(struct platform_device *pdev)
if (ret)
goto free_rproc;
- qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
+ qcom_add_glink_subdev(rproc, &wcss->glink_subdev, "q6wcss");
qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss");
ret = rproc_add(rproc);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] remoteproc: wcss: Fix arguments passed to qcom_add_glink_subdev()
@ 2020-05-14 18:58 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-05-14 18:58 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
Recently qcom_add_glink_subdev() was extended to also take the glink_ssr
identifier as an argument and I missed this while applying '8a226e2c71bb
("remoteproc: wcss: add support for rpmsg communication")'.
Fixes: 8a226e2c71bb ("remoteproc: wcss: add support for rpmsg communication")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/remoteproc/qcom_q6v5_wcss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
index 48d16d81f94d..88c76b9417fa 100644
--- a/drivers/remoteproc/qcom_q6v5_wcss.c
+++ b/drivers/remoteproc/qcom_q6v5_wcss.c
@@ -560,7 +560,7 @@ static int q6v5_wcss_probe(struct platform_device *pdev)
if (ret)
goto free_rproc;
- qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
+ qcom_add_glink_subdev(rproc, &wcss->glink_subdev, "q6wcss");
qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss");
ret = rproc_add(rproc);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: wcss: Fix arguments passed to qcom_add_glink_subdev()
2020-05-14 18:58 ` Bjorn Andersson
(?)
@ 2020-05-14 20:00 ` patchwork-bot+linux-remoteproc
-1 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2020-05-14 20:00 UTC (permalink / raw)
To: Bjorn Andersson; +Cc: linux-remoteproc
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next).
On Thu, 14 May 2020 11:58:56 -0700 you wrote:
> Recently qcom_add_glink_subdev() was extended to also take the glink_ssr
> identifier as an argument and I missed this while applying '8a226e2c71bb
> ("remoteproc: wcss: add support for rpmsg communication")'.
>
> Fixes: 8a226e2c71bb ("remoteproc: wcss: add support for rpmsg communication")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> [...]
Here is a summary with links:
- remoteproc: wcss: Fix arguments passed to qcom_add_glink_subdev()
https://git.kernel.org/andersson/remoteproc/c/25f9f5a2107fdc6510463be4e55012d17d83ab2b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-14 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 18:35 [linux-next:master 8165/9362] drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev' kbuild test robot
2020-05-14 18:58 ` [PATCH] remoteproc: wcss: Fix arguments passed to qcom_add_glink_subdev() Bjorn Andersson
2020-05-14 18:58 ` Bjorn Andersson
2020-05-14 20:00 ` patchwork-bot+linux-remoteproc
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.