From: Alex Shi <alex.shi@linux.alibaba.com> To: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, Vlastimil Babka <vbabka@suse.cz>, Mike Kravetz <mike.kravetz@oracle.com> Subject: [PATCH v16 04/22] mm/compaction: rename compact_deferred as compact_should_defer Date: Sat, 11 Jul 2020 08:58:38 +0800 [thread overview] Message-ID: <1594429136-20002-5-git-send-email-alex.shi@linux.alibaba.com> (raw) In-Reply-To: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> The compact_deferred is a defer suggestion check, deferring action does in defer_compaction not here. so, better rename it to avoid confusing. Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Mike Kravetz <mike.kravetz@oracle.com> Cc: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org --- include/linux/compaction.h | 4 ++-- include/trace/events/compaction.h | 2 +- mm/compaction.c | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/compaction.h b/include/linux/compaction.h index 6fa0eea3f530..be9ed7437a38 100644 --- a/include/linux/compaction.h +++ b/include/linux/compaction.h @@ -100,7 +100,7 @@ extern enum compact_result compaction_suitable(struct zone *zone, int order, unsigned int alloc_flags, int highest_zoneidx); extern void defer_compaction(struct zone *zone, int order); -extern bool compaction_deferred(struct zone *zone, int order); +extern bool compaction_should_defer(struct zone *zone, int order); extern void compaction_defer_reset(struct zone *zone, int order, bool alloc_success); extern bool compaction_restarting(struct zone *zone, int order); @@ -199,7 +199,7 @@ static inline void defer_compaction(struct zone *zone, int order) { } -static inline bool compaction_deferred(struct zone *zone, int order) +static inline bool compaction_should_defer(struct zone *zone, int order) { return true; } diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h index 54e5bf081171..33633c71df04 100644 --- a/include/trace/events/compaction.h +++ b/include/trace/events/compaction.h @@ -274,7 +274,7 @@ 1UL << __entry->defer_shift) ); -DEFINE_EVENT(mm_compaction_defer_template, mm_compaction_deferred, +DEFINE_EVENT(mm_compaction_defer_template, mm_compaction_should_defer, TP_PROTO(struct zone *zone, int order), diff --git a/mm/compaction.c b/mm/compaction.c index cd1ef9e5e638..f14780fc296a 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -154,7 +154,7 @@ void defer_compaction(struct zone *zone, int order) } /* Returns true if compaction should be skipped this time */ -bool compaction_deferred(struct zone *zone, int order) +bool compaction_should_defer(struct zone *zone, int order) { unsigned long defer_limit = 1UL << zone->compact_defer_shift; @@ -168,7 +168,7 @@ bool compaction_deferred(struct zone *zone, int order) if (zone->compact_considered >= defer_limit) return false; - trace_mm_compaction_deferred(zone, order); + trace_mm_compaction_should_defer(zone, order); return true; } @@ -2377,7 +2377,7 @@ enum compact_result try_to_compact_pages(gfp_t gfp_mask, unsigned int order, enum compact_result status; if (prio > MIN_COMPACT_PRIORITY - && compaction_deferred(zone, order)) { + && compaction_should_defer(zone, order)) { rc = max_t(enum compact_result, COMPACT_DEFERRED, rc); continue; } @@ -2561,7 +2561,7 @@ static void kcompactd_do_work(pg_data_t *pgdat) if (!populated_zone(zone)) continue; - if (compaction_deferred(zone, cc.order)) + if (compaction_should_defer(zone, cc.order)) continue; if (compaction_suitable(zone, cc.order, 0, zoneid) != -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org, daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org, richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org Cc: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>, Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>, Mike Kravetz <mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Subject: [PATCH v16 04/22] mm/compaction: rename compact_deferred as compact_should_defer Date: Sat, 11 Jul 2020 08:58:38 +0800 [thread overview] Message-ID: <1594429136-20002-5-git-send-email-alex.shi@linux.alibaba.com> (raw) In-Reply-To: <1594429136-20002-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> The compact_deferred is a defer suggestion check, deferring action does in defer_compaction not here. so, better rename it to avoid confusing. Signed-off-by: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> Cc: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> Cc: Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Cc: Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org> Cc: Mike Kravetz <mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org --- include/linux/compaction.h | 4 ++-- include/trace/events/compaction.h | 2 +- mm/compaction.c | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/compaction.h b/include/linux/compaction.h index 6fa0eea3f530..be9ed7437a38 100644 --- a/include/linux/compaction.h +++ b/include/linux/compaction.h @@ -100,7 +100,7 @@ extern enum compact_result compaction_suitable(struct zone *zone, int order, unsigned int alloc_flags, int highest_zoneidx); extern void defer_compaction(struct zone *zone, int order); -extern bool compaction_deferred(struct zone *zone, int order); +extern bool compaction_should_defer(struct zone *zone, int order); extern void compaction_defer_reset(struct zone *zone, int order, bool alloc_success); extern bool compaction_restarting(struct zone *zone, int order); @@ -199,7 +199,7 @@ static inline void defer_compaction(struct zone *zone, int order) { } -static inline bool compaction_deferred(struct zone *zone, int order) +static inline bool compaction_should_defer(struct zone *zone, int order) { return true; } diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h index 54e5bf081171..33633c71df04 100644 --- a/include/trace/events/compaction.h +++ b/include/trace/events/compaction.h @@ -274,7 +274,7 @@ 1UL << __entry->defer_shift) ); -DEFINE_EVENT(mm_compaction_defer_template, mm_compaction_deferred, +DEFINE_EVENT(mm_compaction_defer_template, mm_compaction_should_defer, TP_PROTO(struct zone *zone, int order), diff --git a/mm/compaction.c b/mm/compaction.c index cd1ef9e5e638..f14780fc296a 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -154,7 +154,7 @@ void defer_compaction(struct zone *zone, int order) } /* Returns true if compaction should be skipped this time */ -bool compaction_deferred(struct zone *zone, int order) +bool compaction_should_defer(struct zone *zone, int order) { unsigned long defer_limit = 1UL << zone->compact_defer_shift; @@ -168,7 +168,7 @@ bool compaction_deferred(struct zone *zone, int order) if (zone->compact_considered >= defer_limit) return false; - trace_mm_compaction_deferred(zone, order); + trace_mm_compaction_should_defer(zone, order); return true; } @@ -2377,7 +2377,7 @@ enum compact_result try_to_compact_pages(gfp_t gfp_mask, unsigned int order, enum compact_result status; if (prio > MIN_COMPACT_PRIORITY - && compaction_deferred(zone, order)) { + && compaction_should_defer(zone, order)) { rc = max_t(enum compact_result, COMPACT_DEFERRED, rc); continue; } @@ -2561,7 +2561,7 @@ static void kcompactd_do_work(pg_data_t *pgdat) if (!populated_zone(zone)) continue; - if (compaction_deferred(zone, cc.order)) + if (compaction_should_defer(zone, cc.order)) continue; if (compaction_suitable(zone, cc.order, 0, zoneid) != -- 1.8.3.1
next prev parent reply other threads:[~2020-07-11 1:00 UTC|newest] Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-11 0:58 [PATCH v16 00/22] per memcg lru_lock Alex Shi 2020-07-11 0:58 ` [PATCH v16 01/22] mm/vmscan: remove unnecessary lruvec adding Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 02/22] mm/page_idle: no unlikely double check for idle page counting Alex Shi 2020-07-11 0:58 ` [PATCH v16 03/22] mm/compaction: correct the comments of compact_defer_shift Alex Shi 2020-07-11 0:58 ` Alex Shi [this message] 2020-07-11 0:58 ` [PATCH v16 04/22] mm/compaction: rename compact_deferred as compact_should_defer Alex Shi 2020-07-11 0:58 ` [PATCH v16 05/22] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi 2020-07-16 8:59 ` Alex Shi 2020-07-16 8:59 ` Alex Shi 2020-07-16 13:17 ` Kirill A. Shutemov 2020-07-16 13:17 ` Kirill A. Shutemov 2020-07-17 5:13 ` Alex Shi 2020-07-17 5:13 ` Alex Shi 2020-07-20 8:37 ` Kirill A. Shutemov 2020-07-20 8:37 ` Kirill A. Shutemov 2020-07-11 0:58 ` [PATCH v16 06/22] mm/thp: clean up lru_add_page_tail Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-20 8:43 ` Kirill A. Shutemov 2020-07-20 8:43 ` Kirill A. Shutemov 2020-07-11 0:58 ` [PATCH v16 07/22] mm/thp: remove code path which never got into Alex Shi 2020-07-20 8:43 ` Kirill A. Shutemov 2020-07-20 8:43 ` Kirill A. Shutemov 2020-07-11 0:58 ` [PATCH v16 08/22] mm/thp: narrow lru locking Alex Shi 2020-07-11 0:58 ` [PATCH v16 09/22] mm/memcg: add debug checking in lock_page_memcg Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 10/22] mm/swap: fold vm event PGROTATED into pagevec_move_tail_fn Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 11/22] mm/lru: move lru_lock holding in func lru_note_cost_page Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 12/22] mm/lru: move lock into lru_note_cost Alex Shi 2020-07-11 0:58 ` [PATCH v16 13/22] mm/lru: introduce TestClearPageLRU Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-16 9:06 ` Alex Shi 2020-07-16 9:06 ` Alex Shi 2020-07-16 21:12 ` Alexander Duyck 2020-07-16 21:12 ` Alexander Duyck 2020-07-16 21:12 ` Alexander Duyck 2020-07-17 7:45 ` Alex Shi 2020-07-17 7:45 ` Alex Shi 2020-07-17 18:26 ` Alexander Duyck 2020-07-17 18:26 ` Alexander Duyck 2020-07-19 4:45 ` Alex Shi 2020-07-19 4:45 ` Alex Shi 2020-07-19 11:24 ` Alex Shi 2020-07-19 11:24 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page() Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-17 9:30 ` Alex Shi 2020-07-17 9:30 ` Alex Shi 2020-07-20 8:49 ` Kirill A. Shutemov 2020-07-20 8:49 ` Kirill A. Shutemov 2020-07-20 9:04 ` Alex Shi 2020-07-20 9:04 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 15/22] mm/compaction: do page isolation first in compaction Alex Shi 2020-07-16 21:32 ` Alexander Duyck 2020-07-16 21:32 ` Alexander Duyck 2020-07-16 21:32 ` Alexander Duyck 2020-07-17 5:09 ` Alex Shi 2020-07-17 5:09 ` Alex Shi 2020-07-17 16:09 ` Alexander Duyck 2020-07-17 16:09 ` Alexander Duyck 2020-07-17 16:09 ` Alexander Duyck 2020-07-19 3:59 ` Alex Shi 2020-07-19 3:59 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 16/22] mm/mlock: reorder isolation sequence during munlock Alex Shi 2020-07-17 20:30 ` Alexander Duyck 2020-07-17 20:30 ` Alexander Duyck 2020-07-17 20:30 ` Alexander Duyck 2020-07-19 3:55 ` Alex Shi 2020-07-19 3:55 ` Alex Shi 2020-07-20 18:51 ` Alexander Duyck 2020-07-20 18:51 ` Alexander Duyck 2020-07-20 18:51 ` Alexander Duyck 2020-07-21 9:26 ` Alex Shi 2020-07-21 9:26 ` Alex Shi 2020-07-21 13:51 ` Alex Shi 2020-07-21 13:51 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 17/22] mm/swap: serialize memcg changes during pagevec_lru_move_fn Alex Shi 2020-07-11 0:58 ` [PATCH v16 18/22] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-17 21:38 ` Alexander Duyck 2020-07-17 21:38 ` Alexander Duyck 2020-07-17 21:38 ` Alexander Duyck 2020-07-18 14:15 ` Alex Shi 2020-07-19 9:12 ` Alex Shi 2020-07-19 9:12 ` Alex Shi 2020-07-19 15:14 ` Alexander Duyck 2020-07-19 15:14 ` Alexander Duyck 2020-07-19 15:14 ` Alexander Duyck 2020-07-20 5:47 ` Alex Shi 2020-07-20 5:47 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 19/22] mm/lru: introduce the relock_page_lruvec function Alex Shi 2020-07-11 0:58 ` Alex Shi 2020-07-17 22:03 ` Alexander Duyck 2020-07-17 22:03 ` Alexander Duyck 2020-07-18 14:01 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 20/22] mm/vmscan: use relock for move_pages_to_lru Alex Shi 2020-07-17 21:44 ` Alexander Duyck 2020-07-17 21:44 ` Alexander Duyck 2020-07-17 21:44 ` Alexander Duyck 2020-07-18 14:15 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 21/22] mm/pgdat: remove pgdat lru_lock Alex Shi 2020-07-17 21:09 ` Alexander Duyck 2020-07-17 21:09 ` Alexander Duyck 2020-07-18 14:17 ` Alex Shi 2020-07-18 14:17 ` Alex Shi 2020-07-11 0:58 ` [PATCH v16 22/22] mm/lru: revise the comments of lru_lock Alex Shi 2020-07-11 1:02 ` [PATCH v16 00/22] per memcg lru_lock Alex Shi 2020-07-11 1:02 ` Alex Shi 2020-07-16 8:49 ` Alex Shi 2020-07-16 14:11 ` Alexander Duyck 2020-07-16 14:11 ` Alexander Duyck 2020-07-16 14:11 ` Alexander Duyck 2020-07-17 5:24 ` Alex Shi 2020-07-17 5:24 ` Alex Shi 2020-07-19 15:23 ` Hugh Dickins 2020-07-19 15:23 ` Hugh Dickins 2020-07-20 3:01 ` Alex Shi 2020-07-20 3:01 ` Alex Shi 2020-07-20 4:47 ` Hugh Dickins 2020-07-20 4:47 ` Hugh Dickins 2020-07-20 4:47 ` Hugh Dickins 2020-07-20 7:30 ` Alex Shi 2020-07-20 7:30 ` Alex Shi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1594429136-20002-5-git-send-email-alex.shi@linux.alibaba.com \ --to=alex.shi@linux.alibaba.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=daniel.m.jordan@oracle.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=khlebnikov@yandex-team.ru \ --cc=kirill@shutemov.name \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ --cc=mgorman@techsingularity.net \ --cc=mike.kravetz@oracle.com \ --cc=mingo@redhat.com \ --cc=richard.weiyang@gmail.com \ --cc=rostedt@goodmis.org \ --cc=shakeelb@google.com \ --cc=tj@kernel.org \ --cc=vbabka@suse.cz \ --cc=willy@infradead.org \ --cc=yang.shi@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.