From: Liu Yi L <yi.l.liu@intel.com> To: alex.williamson@redhat.com, eric.auger@redhat.com, baolu.lu@linux.intel.com, joro@8bytes.org Cc: kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, ashok.raj@intel.com, yi.l.liu@intel.com, jun.j.tian@intel.com, yi.y.sun@intel.com, jean-philippe@linaro.org, peterx@redhat.com, jasowang@redhat.com, hao.wu@intel.com, stefanha@gmail.com, iommu@lists.linux-foundation.org, kvm@vger.kernel.org Subject: [PATCH v7 06/16] iommu/vt-d: Remove get_task_mm() in bind_gpasid() Date: Thu, 10 Sep 2020 03:45:23 -0700 [thread overview] Message-ID: <1599734733-6431-7-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1599734733-6431-1-git-send-email-yi.l.liu@intel.com> This patch is to address a REVISIT. As ioasid_set is added to domain, upper layer/VFIO can set ioasid_set to iommu driver, and track the PASID ownership, so no need to get_task_mm() in intel_svm_bind_gpasid(). Cc: Kevin Tian <kevin.tian@intel.com> CC: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Eric Auger <eric.auger@redhat.com> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Joerg Roedel <joro@8bytes.org> Cc: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> --- drivers/iommu/intel/svm.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index 519eabb..d3cf52b 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -400,12 +400,6 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, ret = -ENOMEM; goto out; } - /* REVISIT: upper layer/VFIO can track host process that bind - * the PASID. ioasid_set = mm might be sufficient for vfio to - * check pasid VMM ownership. We can drop the following line - * once VFIO and IOASID set check is in place. - */ - svm->mm = get_task_mm(current); svm->pasid = data->hpasid; if (data->flags & IOMMU_SVA_GPASID_VAL) { svm->gpasid = data->gpasid; @@ -420,7 +414,6 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, INIT_WORK(&svm->work, intel_svm_free_async_fn); ioasid_attach_data(data->hpasid, svm); INIT_LIST_HEAD_RCU(&svm->devs); - mmput(svm->mm); } sdev = kzalloc(sizeof(*sdev), GFP_KERNEL); if (!sdev) { -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Liu Yi L <yi.l.liu@intel.com> To: alex.williamson@redhat.com, eric.auger@redhat.com, baolu.lu@linux.intel.com, joro@8bytes.org Cc: jean-philippe@linaro.org, kevin.tian@intel.com, ashok.raj@intel.com, kvm@vger.kernel.org, stefanha@gmail.com, jun.j.tian@intel.com, iommu@lists.linux-foundation.org, yi.y.sun@intel.com, jasowang@redhat.com, hao.wu@intel.com Subject: [PATCH v7 06/16] iommu/vt-d: Remove get_task_mm() in bind_gpasid() Date: Thu, 10 Sep 2020 03:45:23 -0700 [thread overview] Message-ID: <1599734733-6431-7-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1599734733-6431-1-git-send-email-yi.l.liu@intel.com> This patch is to address a REVISIT. As ioasid_set is added to domain, upper layer/VFIO can set ioasid_set to iommu driver, and track the PASID ownership, so no need to get_task_mm() in intel_svm_bind_gpasid(). Cc: Kevin Tian <kevin.tian@intel.com> CC: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Eric Auger <eric.auger@redhat.com> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Joerg Roedel <joro@8bytes.org> Cc: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> --- drivers/iommu/intel/svm.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index 519eabb..d3cf52b 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -400,12 +400,6 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, ret = -ENOMEM; goto out; } - /* REVISIT: upper layer/VFIO can track host process that bind - * the PASID. ioasid_set = mm might be sufficient for vfio to - * check pasid VMM ownership. We can drop the following line - * once VFIO and IOASID set check is in place. - */ - svm->mm = get_task_mm(current); svm->pasid = data->hpasid; if (data->flags & IOMMU_SVA_GPASID_VAL) { svm->gpasid = data->gpasid; @@ -420,7 +414,6 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, INIT_WORK(&svm->work, intel_svm_free_async_fn); ioasid_attach_data(data->hpasid, svm); INIT_LIST_HEAD_RCU(&svm->devs); - mmput(svm->mm); } sdev = kzalloc(sizeof(*sdev), GFP_KERNEL); if (!sdev) { -- 2.7.4 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-10 10:45 UTC|newest] Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-10 10:45 [PATCH v7 00/16] vfio: expose virtual Shared Virtual Addressing to VMs Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` [PATCH v7 01/16] iommu: Report domain nesting info Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-11 19:38 ` Alex Williamson 2020-09-11 19:38 ` Alex Williamson 2020-09-10 10:45 ` [PATCH v7 02/16] iommu/smmu: Report empty " Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2021-01-12 6:50 ` Vivek Gautam 2021-01-12 6:50 ` Vivek Gautam 2021-01-12 9:21 ` Liu, Yi L 2021-01-12 9:21 ` Liu, Yi L 2021-01-12 11:05 ` Vivek Gautam 2021-01-12 11:05 ` Vivek Gautam 2021-01-13 5:56 ` Liu, Yi L 2021-01-13 5:56 ` Liu, Yi L 2021-01-19 10:03 ` Auger Eric 2021-01-19 10:03 ` Auger Eric 2021-01-23 8:59 ` Liu, Yi L 2021-01-23 8:59 ` Liu, Yi L 2021-02-12 7:14 ` Vivek Gautam 2021-02-12 7:14 ` Vivek Gautam 2021-02-12 9:57 ` Auger Eric 2021-02-12 9:57 ` Auger Eric 2021-02-12 10:18 ` Vivek Kumar Gautam 2021-02-12 10:18 ` Vivek Kumar Gautam 2021-02-12 11:01 ` Vivek Kumar Gautam 2021-02-12 11:01 ` Vivek Kumar Gautam 2021-03-03 9:44 ` Liu, Yi L 2021-03-03 9:44 ` Liu, Yi L 2020-09-10 10:45 ` [PATCH v7 03/16] vfio/type1: Report iommu nesting info to userspace Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-11 20:16 ` Alex Williamson 2020-09-11 20:16 ` Alex Williamson 2020-09-12 8:24 ` Liu, Yi L 2020-09-12 8:24 ` Liu, Yi L 2020-09-10 10:45 ` [PATCH v7 04/16] vfio: Add PASID allocation/free support Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-11 20:54 ` Alex Williamson 2020-09-11 20:54 ` Alex Williamson 2020-09-15 4:03 ` Liu, Yi L 2020-09-15 4:03 ` Liu, Yi L 2020-09-10 10:45 ` [PATCH v7 05/16] iommu/vt-d: Support setting ioasid set to domain Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` Liu Yi L [this message] 2020-09-10 10:45 ` [PATCH v7 06/16] iommu/vt-d: Remove get_task_mm() in bind_gpasid() Liu Yi L 2020-09-10 10:45 ` [PATCH v7 07/16] vfio/type1: Add VFIO_IOMMU_PASID_REQUEST (alloc/free) Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-11 21:38 ` Alex Williamson 2020-09-11 21:38 ` Alex Williamson 2020-09-12 6:17 ` Liu, Yi L 2020-09-10 10:45 ` [PATCH v7 08/16] iommu: Pass domain to sva_unbind_gpasid() Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` [PATCH v7 09/16] iommu/vt-d: Check ownership for PASIDs from user-space Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` [PATCH v7 10/16] vfio/type1: Support binding guest page tables to PASID Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-11 22:03 ` Alex Williamson 2020-09-11 22:03 ` Alex Williamson 2020-09-12 6:02 ` Liu, Yi L 2020-09-12 6:02 ` Liu, Yi L 2020-09-10 10:45 ` [PATCH v7 11/16] vfio/type1: Allow invalidating first-level/stage IOMMU cache Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` [PATCH v7 12/16] vfio/type1: Add vSVA support for IOMMU-backed mdevs Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` [PATCH v7 13/16] vfio/pci: Expose PCIe PASID capability to guest Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-11 22:13 ` Alex Williamson 2020-09-11 22:13 ` Alex Williamson 2020-09-12 7:17 ` Liu, Yi L 2020-09-12 7:17 ` Liu, Yi L 2020-09-10 10:45 ` [PATCH v7 14/16] vfio: Document dual stage control Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` [PATCH v7 15/16] iommu/vt-d: Only support nesting when nesting caps are consistent across iommu units Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-10 10:45 ` [PATCH v7 16/16] iommu/vt-d: Support reporting nesting capability info Liu Yi L 2020-09-10 10:45 ` Liu Yi L 2020-09-14 4:20 ` [PATCH v7 00/16] vfio: expose virtual Shared Virtual Addressing to VMs Jason Wang 2020-09-14 4:20 ` Jason Wang 2020-09-14 8:01 ` Tian, Kevin 2020-09-14 8:01 ` Tian, Kevin 2020-09-14 8:57 ` Jason Wang 2020-09-14 8:57 ` Jason Wang 2020-09-14 10:38 ` Tian, Kevin 2020-09-14 10:38 ` Tian, Kevin 2020-09-14 11:38 ` Jason Gunthorpe 2020-09-14 11:38 ` Jason Gunthorpe 2020-09-14 13:31 ` Jean-Philippe Brucker 2020-09-14 13:31 ` Jean-Philippe Brucker 2020-09-14 13:47 ` Jason Gunthorpe 2020-09-14 13:47 ` Jason Gunthorpe 2020-09-14 16:22 ` Raj, Ashok 2020-09-14 16:22 ` Raj, Ashok 2020-09-14 16:33 ` Jason Gunthorpe 2020-09-14 16:33 ` Jason Gunthorpe 2020-09-14 16:58 ` Alex Williamson 2020-09-14 16:58 ` Alex Williamson 2020-09-14 17:41 ` Jason Gunthorpe 2020-09-14 17:41 ` Jason Gunthorpe 2020-09-14 18:23 ` Alex Williamson 2020-09-14 18:23 ` Alex Williamson 2020-09-14 19:00 ` Jason Gunthorpe 2020-09-14 19:00 ` Jason Gunthorpe 2020-09-14 22:33 ` Alex Williamson 2020-09-14 22:33 ` Alex Williamson 2020-09-15 14:29 ` Jason Gunthorpe 2020-09-15 14:29 ` Jason Gunthorpe 2020-09-16 1:19 ` Tian, Kevin 2020-09-16 1:19 ` Tian, Kevin 2020-09-16 8:32 ` Jean-Philippe Brucker 2020-09-16 8:32 ` Jean-Philippe Brucker 2020-09-16 14:51 ` Jason Gunthorpe 2020-09-16 14:51 ` Jason Gunthorpe 2020-09-16 16:20 ` Jean-Philippe Brucker 2020-09-16 16:20 ` Jean-Philippe Brucker 2020-09-16 16:32 ` Jason Gunthorpe 2020-09-16 16:32 ` Jason Gunthorpe 2020-09-16 16:50 ` Auger Eric 2020-09-16 16:50 ` Auger Eric 2020-09-16 14:44 ` Jason Gunthorpe 2020-09-16 14:44 ` Jason Gunthorpe 2020-09-17 6:01 ` Tian, Kevin 2020-09-17 6:01 ` Tian, Kevin 2020-09-14 22:44 ` Raj, Ashok 2020-09-15 11:33 ` Jason Gunthorpe 2020-09-15 11:33 ` Jason Gunthorpe 2020-09-15 18:11 ` Raj, Ashok 2020-09-15 18:11 ` Raj, Ashok 2020-09-15 18:45 ` Jason Gunthorpe 2020-09-15 18:45 ` Jason Gunthorpe 2020-09-15 19:26 ` Raj, Ashok 2020-09-15 19:26 ` Raj, Ashok 2020-09-15 23:45 ` Jason Gunthorpe 2020-09-15 23:45 ` Jason Gunthorpe 2020-09-16 2:33 ` Jason Wang 2020-09-16 2:33 ` Jason Wang 2020-09-15 22:08 ` Jacob Pan 2020-09-15 22:08 ` Jacob Pan 2020-09-15 23:51 ` Jason Gunthorpe 2020-09-15 23:51 ` Jason Gunthorpe 2020-09-16 0:22 ` Jacob Pan (Jun) 2020-09-16 1:46 ` Lu Baolu 2020-09-16 1:46 ` Lu Baolu 2020-09-16 15:07 ` Jason Gunthorpe 2020-09-16 15:07 ` Jason Gunthorpe 2020-09-16 16:33 ` Raj, Ashok 2020-09-16 16:33 ` Raj, Ashok 2020-09-16 17:01 ` Jason Gunthorpe 2020-09-16 17:01 ` Jason Gunthorpe 2020-09-16 18:21 ` Jacob Pan (Jun) 2020-09-16 18:21 ` Jacob Pan (Jun) 2020-09-16 18:38 ` Jason Gunthorpe 2020-09-16 18:38 ` Jason Gunthorpe 2020-09-16 23:09 ` Jacob Pan (Jun) 2020-09-16 23:09 ` Jacob Pan (Jun) 2020-09-17 3:53 ` Jason Wang 2020-09-17 3:53 ` Jason Wang 2020-09-17 17:31 ` Jason Gunthorpe 2020-09-17 17:31 ` Jason Gunthorpe 2020-09-17 18:17 ` Jacob Pan (Jun) 2020-09-17 18:17 ` Jacob Pan (Jun) 2020-09-18 3:58 ` Jason Wang 2020-09-18 3:58 ` Jason Wang 2020-09-16 2:29 ` Jason Wang 2020-09-16 2:29 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1599734733-6431-7-git-send-email-yi.l.liu@intel.com \ --to=yi.l.liu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=eric.auger@redhat.com \ --cc=hao.wu@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jasowang@redhat.com \ --cc=jean-philippe@linaro.org \ --cc=joro@8bytes.org \ --cc=jun.j.tian@intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=peterx@redhat.com \ --cc=stefanha@gmail.com \ --cc=yi.y.sun@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.