All of lore.kernel.org
 help / color / mirror / Atom feed
From: satya priya <skakit@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	gregkh@linuxfoundation.org, Andy Gross <agross@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, akashast@codeaurora.org,
	rojay@codeaurora.org, msavaliy@qti.qualcomm.com,
	dianders@chromium.org, satya priya <skakit@codeaurora.org>
Subject: [PATCH V5 4/4] tty: serial: qcom_geni_serial: Fix the UART wakeup issue
Date: Thu, 10 Sep 2020 18:23:58 +0530	[thread overview]
Message-ID: <1599742438-16811-5-git-send-email-skakit@codeaurora.org> (raw)
In-Reply-To: <1599742438-16811-1-git-send-email-skakit@codeaurora.org>

As a part of system suspend uart_port_suspend is called from the
Serial driver, which calls set_mctrl passing mctrl as 0. This
makes RFR high(NOT_READY) during suspend.

Due to this BT SoC is not able to send wakeup bytes to UART during
suspend. Include if check for non-suspend case to keep RFR low
during suspend.

Signed-off-by: satya priya <skakit@codeaurora.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Akash Asthana <akashast@codeaurora.org>
---
Changes in V2:
 - This patch fixes the UART flow control issue during suspend.
   Newly added in V2.

Changes in V3:
 - As per Matthias's comment removed the extra parentheses.

Changes in V4:
 - No change.

Changes in V5:
 - As per Matthias comment, fixed nit-pick in commit text.

 drivers/tty/serial/qcom_geni_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 3aa29d2..bc63c54 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -242,7 +242,7 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport,
 	if (mctrl & TIOCM_LOOP)
 		port->loopback = RX_TX_CTS_RTS_SORTED;
 
-	if (!(mctrl & TIOCM_RTS))
+	if (!(mctrl & TIOCM_RTS) && !uport->suspended)
 		uart_manual_rfr = UART_MANUAL_RFR_EN | UART_RFR_NOT_READY;
 	writel(uart_manual_rfr, uport->membase + SE_UART_MANUAL_RFR);
 }
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


  parent reply	other threads:[~2020-09-10 21:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 12:53 [PATCH V5 0/4] Add wakeup support over UART RX satya priya
2020-09-10 12:53 ` [PATCH V5 1/4] arm64: dts: qcom: sc7180: Improve the pin config settings for CTS and TX satya priya
2020-09-10 14:40   ` Doug Anderson
2020-09-11 10:14     ` skakit
2020-09-10 12:53 ` [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART satya priya
2020-09-10 14:40   ` Doug Anderson
2020-09-11 10:15     ` skakit
2020-09-11 13:52       ` Bjorn Andersson
2020-09-11 15:30         ` Doug Anderson
2020-09-10 15:35   ` Matthias Kaehlcke
2020-09-11 10:15     ` skakit
2020-09-10 23:45   ` Bjorn Andersson
2020-09-11 10:16     ` skakit
2020-09-10 12:53 ` [PATCH V5 3/4] arm64: dts: qcom: sc7180-trogdor: Add " satya priya
2020-09-10 14:42   ` Doug Anderson
2020-09-11 10:15     ` skakit
2020-09-10 12:53 ` satya priya [this message]
2020-09-10 23:06   ` [PATCH V5 4/4] tty: serial: qcom_geni_serial: Fix the UART wakeup issue Bjorn Andersson
2020-09-16 12:25     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599742438-16811-5-git-send-email-skakit@codeaurora.org \
    --to=skakit@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=akashast@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=msavaliy@qti.qualcomm.com \
    --cc=robh+dt@kernel.org \
    --cc=rojay@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.