* [PATCH] tests/9pfs: Force removing of local 9pfs test directory
@ 2020-10-30 12:46 Greg Kurz
2020-10-30 14:27 ` Christian Schoenebeck
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kurz @ 2020-10-30 12:46 UTC (permalink / raw)
To: Christian Schoenebeck; +Cc: qemu-devel
No need to get a complaint from "rm" if some path disappeared for some
reason.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
I remember seeing a "rm: cannot remove 'some-path': No such file or directory"
recently but I can't reproduce it with current master :)
---
tests/qtest/libqos/virtio-9p.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/libqos/virtio-9p.c
index 6b22fa0e9a49..ab9d88a9b7de 100644
--- a/tests/qtest/libqos/virtio-9p.c
+++ b/tests/qtest/libqos/virtio-9p.c
@@ -62,7 +62,7 @@ static void create_local_test_dir(void)
static void remove_local_test_dir(void)
{
g_assert(local_test_path != NULL);
- char *cmd = g_strdup_printf("rm -r '%s'\n", local_test_path);
+ char *cmd = g_strdup_printf("rm -fr '%s'\n", local_test_path);
int res = system(cmd);
if (res < 0) {
/* ignore error, dummy check to prevent compiler error */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/9pfs: Force removing of local 9pfs test directory
2020-10-30 12:46 [PATCH] tests/9pfs: Force removing of local 9pfs test directory Greg Kurz
@ 2020-10-30 14:27 ` Christian Schoenebeck
0 siblings, 0 replies; 2+ messages in thread
From: Christian Schoenebeck @ 2020-10-30 14:27 UTC (permalink / raw)
To: qemu-devel; +Cc: Greg Kurz
On Freitag, 30. Oktober 2020 13:46:34 CET Greg Kurz wrote:
> No need to get a complaint from "rm" if some path disappeared for some
> reason.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>
> I remember seeing a "rm: cannot remove 'some-path': No such file or
> directory" recently but I can't reproduce it with current master :)
> ---
> tests/qtest/libqos/virtio-9p.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/libqos/virtio-9p.c
> index 6b22fa0e9a49..ab9d88a9b7de 100644
> --- a/tests/qtest/libqos/virtio-9p.c
> +++ b/tests/qtest/libqos/virtio-9p.c
> @@ -62,7 +62,7 @@ static void create_local_test_dir(void)
> static void remove_local_test_dir(void)
> {
> g_assert(local_test_path != NULL);
> - char *cmd = g_strdup_printf("rm -r '%s'\n", local_test_path);
> + char *cmd = g_strdup_printf("rm -fr '%s'\n", local_test_path);
> int res = system(cmd);
> if (res < 0) {
> /* ignore error, dummy check to prevent compiler error */
Makes sense, and trivial enough to put it into v2 PR.
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-30 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 12:46 [PATCH] tests/9pfs: Force removing of local 9pfs test directory Greg Kurz
2020-10-30 14:27 ` Christian Schoenebeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.