[PATCH] rtw88: coex: remove useless if and else

[PATCH] rtw88: coex: remove useless if and else

[Tian Tao]

Fix the following coccinelle report:
drivers/net/wireless/realtek/rtw88/coex.c:1619:3-5: WARNING:
possible condition with no effect (if == else)

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/net/wireless/realtek/rtw88/coex.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index 24530ca..df6676a 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -1616,12 +1616,7 @@ static void rtw_coex_action_bt_relink(struct rtw_dev *rtwdev)
 	if (efuse->share_ant) { /* Shared-Ant */
 		if (coex_stat->wl_gl_busy) {
 			table_case = 26;
-			if (coex_stat->bt_hid_exist &&
-			    coex_stat->bt_profile_num == 1) {
-				tdma_case = 20;
-			} else {
-				tdma_case = 20;
-			}
+			tdma_case = 20;
 		} else {
 			table_case = 1;
 			tdma_case = 0;
-- 
2.7.4

RE: [PATCH] rtw88: coex: remove useless if and else

[Pkshih]

> -----Original Message-----
> From: Tian Tao [mailto:tiantao6@hisilicon.com]
> Sent: Tuesday, December 22, 2020 8:29 PM
> To: tony0620emma@gmail.com; kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org
> Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org
> Subject: [PATCH] rtw88: coex: remove useless if and else
> 
> Fix the following coccinelle report:
> drivers/net/wireless/realtek/rtw88/coex.c:1619:3-5: WARNING:
> possible condition with no effect (if == else)
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>  drivers/net/wireless/realtek/rtw88/coex.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
> index 24530ca..df6676a 100644
> --- a/drivers/net/wireless/realtek/rtw88/coex.c
> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
> @@ -1616,12 +1616,7 @@ static void rtw_coex_action_bt_relink(struct rtw_dev *rtwdev)
>  	if (efuse->share_ant) { /* Shared-Ant */
>  		if (coex_stat->wl_gl_busy) {
>  			table_case = 26;
> -			if (coex_stat->bt_hid_exist &&
> -			    coex_stat->bt_profile_num == 1) {
> -				tdma_case = 20;
> -			} else {
> -				tdma_case = 20;
> -			}
> +			tdma_case = 20;
>  		} else {
>  			table_case = 1;
>  			tdma_case = 0;

I found we miss something in these branches, so I sent a patch,
namely "rtw88: coex: set 4 slot TDMA for BT link and WL busy", to fix it.

The link is
https://patchwork.kernel.org/project/linux-wireless/patch/20201230033602.13636-1-pkshih@realtek.com/

---
Ping-Ke