Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine

From: Roger Lu <roger.lu@mediatek.com>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Nicolas Boichat <drinkcat@google.com>, Nishanth Menon <nm@ti.com>,
	Kevin Hilman <khilman@kernel.org>,
	Enric Balletbo Serra <eballetbo@gmail.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	Angus Lin <Angus.Lin@mediatek.com>,
	Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	"Devicetree List" <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	HenryC Chen <HenryC.Chen@mediatek.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Charles Yang" <Charles.Yang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	YT Lee <yt.lee@mediatek.com>, Fan Chen <fan.chen@mediatek.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v10 3/7] [v10, 3/7]: soc: mediatek: SVS: introduce MTK SVS engine
Date: Wed, 6 Jan 2021 16:41:55 +0800	[thread overview]
Message-ID: <1609922515.18506.17.camel@mtksdaap41> (raw)
In-Reply-To: <1609750266.20758.40.camel@mtksdaap41>

Hi Nicolas,

[snip]
> > 
> > > +
> > > +       /* Svs efuse parsing */
> > > +       ft_pgm = (svsp->efuse[0] >> 4) & GENMASK(3, 0);
> > > +
> > > +       for (idx = 0; idx < svsp->bank_num; idx++) {
> > > +               svsb = &svsp->banks[idx];
> > > +
> > > +               if (ft_pgm <= 1)
> > > +                       svsb->init01_volt_flag = SVSB_INIT01_VOLT_IGNORE;
> > > +
> > > +               switch (svsb->sw_id) {
> > > +               case SVSB_CPU_LITTLE:
> > > +                       svsb->bdes = svsp->efuse[16] & GENMASK(7, 0);
> > > +                       svsb->mdes = (svsp->efuse[16] >> 8) & GENMASK(7, 0);
> > > +                       svsb->dcbdet = (svsp->efuse[16] >> 16) & GENMASK(7, 0);
> > > +                       svsb->dcmdet = (svsp->efuse[16] >> 24) & GENMASK(7, 0);
> > > +                       svsb->mtdes  = (svsp->efuse[17] >> 16) & GENMASK(7, 0);
> > 
> > Again, if all of those values were u8, there'd be no need for these GENMASK
> 
> Ok, I'll use u8 instead of GENMASK. Thanks.

After refining the codes, I think it's much explicit to assign the bits
I want by GENMASK() and will remove other GENMASK() that are repetitive
like in svs_set_bank_phase() or svs_set_freqs_pct_v2().

[snip]