All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t v2] runner: Don't kill a test on taint if watching timeouts
Date: Thu, 07 Jan 2021 09:49:23 +0000	[thread overview]
Message-ID: <161001296371.839.15704890818022752458@build.alporthouse.com> (raw)
In-Reply-To: <20210107094002.GL7444@platvala-desk.ger.corp.intel.com>

Quoting Petri Latvala (2021-01-07 09:40:02)
> On Wed, Jan 06, 2021 at 09:41:37AM +0000, Chris Wilson wrote:
> > Quoting Janusz Krzysztofik (2020-12-04 19:50:07)
> > > We may still be interested in results of a test even if it has tainted
> > > the kernel.  On the other hand, we need to kill the test on taint if no
> > > other means of killing it on a jam is active.
> > > 
> > > If abort on both kernel taint or a timeout is requested, decrease all
> > > potential timeouts significantly while the taint is detected instead of
> > > aborting immediately.  However, report the taint as the reason of the
> > > abort if a timeout decreased by the taint expires.
> > 
> > This has the nasty side effect of not stopping the test run after a
> > kernel taint. Instead the next test inherits the tainted condition from
> > the previous test and usually ends up being declared incomplete.
> > 
> > False positives are frustrating.
> > -Chris
> 
> 
> Do you have a link to a test run where this happened? This patch
> didn't change the between-tests abort checks.

The taint is from the warnings in the penultimate test:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9550/shard-skl7/igt_runner20.txt
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t v2] runner: Don't kill a test on taint if watching timeouts
Date: Thu, 07 Jan 2021 09:49:23 +0000	[thread overview]
Message-ID: <161001296371.839.15704890818022752458@build.alporthouse.com> (raw)
In-Reply-To: <20210107094002.GL7444@platvala-desk.ger.corp.intel.com>

Quoting Petri Latvala (2021-01-07 09:40:02)
> On Wed, Jan 06, 2021 at 09:41:37AM +0000, Chris Wilson wrote:
> > Quoting Janusz Krzysztofik (2020-12-04 19:50:07)
> > > We may still be interested in results of a test even if it has tainted
> > > the kernel.  On the other hand, we need to kill the test on taint if no
> > > other means of killing it on a jam is active.
> > > 
> > > If abort on both kernel taint or a timeout is requested, decrease all
> > > potential timeouts significantly while the taint is detected instead of
> > > aborting immediately.  However, report the taint as the reason of the
> > > abort if a timeout decreased by the taint expires.
> > 
> > This has the nasty side effect of not stopping the test run after a
> > kernel taint. Instead the next test inherits the tainted condition from
> > the previous test and usually ends up being declared incomplete.
> > 
> > False positives are frustrating.
> > -Chris
> 
> 
> Do you have a link to a test run where this happened? This patch
> didn't change the between-tests abort checks.

The taint is from the warnings in the penultimate test:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9550/shard-skl7/igt_runner20.txt
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-01-07  9:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 19:50 [Intel-gfx] [PATCH i-g-t v2] runner: Don't kill a test on taint if watching timeouts Janusz Krzysztofik
2020-12-04 20:54 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Don't kill a test on taint if watching timeouts (rev2) Patchwork
2020-12-05  0:13 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-12-07 10:46   ` Janusz Krzysztofik
2020-12-07 13:09 ` [Intel-gfx] [PATCH i-g-t v2] runner: Don't kill a test on taint if watching timeouts Petri Latvala
2020-12-07 13:09   ` [igt-dev] " Petri Latvala
2020-12-07 13:18   ` [Intel-gfx] " Janusz Krzysztofik
2020-12-07 13:18     ` [igt-dev] " Janusz Krzysztofik
2020-12-08 17:39 ` [igt-dev] ✓ Fi.CI.IGT: success for runner: Don't kill a test on taint if watching timeouts (rev2) Patchwork
2021-01-06  9:41 ` [Intel-gfx] [PATCH i-g-t v2] runner: Don't kill a test on taint if watching timeouts Chris Wilson
2021-01-06  9:41   ` [igt-dev] " Chris Wilson
2021-01-07  9:40   ` [Intel-gfx] " Petri Latvala
2021-01-07  9:49     ` Chris Wilson [this message]
2021-01-07  9:49       ` [igt-dev] " Chris Wilson
2021-01-07 10:06       ` [Intel-gfx] [igt-dev] " Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161001296371.839.15704890818022752458@build.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.