* [PATCH v1] drm/nouveau: delete unused variables "dev" in nouveau_ttm_tt_populate()
@ 2021-02-25 8:08 ` Luo Jiaxing
0 siblings, 0 replies; 3+ messages in thread
From: Luo Jiaxing @ 2021-02-25 8:08 UTC (permalink / raw)
To: nouveau, dri-devel, bskeggs; +Cc: linux-kernel, linuxarm, luojiaxing
After switch to new allocator, dev is no longer used here and should be
deleted.
Fixes: 461619f5c324 ("drm/nouveau: switch to new allocator")
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 2375711..0b94f8a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1251,7 +1251,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev,
{
struct ttm_tt *ttm_dma = (void *)ttm;
struct nouveau_drm *drm;
- struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
if (ttm_tt_is_populated(ttm))
@@ -1264,7 +1263,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev,
}
drm = nouveau_bdev(bdev);
- dev = drm->dev->dev;
return ttm_pool_alloc(&drm->ttm.bdev.pool, ttm, ctx);
}
@@ -1274,14 +1272,12 @@ nouveau_ttm_tt_unpopulate(struct ttm_bo_device *bdev,
struct ttm_tt *ttm)
{
struct nouveau_drm *drm;
- struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
if (slave)
return;
drm = nouveau_bdev(bdev);
- dev = drm->dev->dev;
return ttm_pool_free(&drm->ttm.bdev.pool, ttm);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Nouveau] [PATCH v1] drm/nouveau: delete unused variables "dev" in nouveau_ttm_tt_populate()
@ 2021-02-25 8:08 ` Luo Jiaxing
0 siblings, 0 replies; 3+ messages in thread
From: Luo Jiaxing @ 2021-02-25 8:08 UTC (permalink / raw)
To: nouveau, dri-devel, bskeggs; +Cc: luojiaxing, linux-kernel, linuxarm
After switch to new allocator, dev is no longer used here and should be
deleted.
Fixes: 461619f5c324 ("drm/nouveau: switch to new allocator")
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 2375711..0b94f8a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1251,7 +1251,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev,
{
struct ttm_tt *ttm_dma = (void *)ttm;
struct nouveau_drm *drm;
- struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
if (ttm_tt_is_populated(ttm))
@@ -1264,7 +1263,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev,
}
drm = nouveau_bdev(bdev);
- dev = drm->dev->dev;
return ttm_pool_alloc(&drm->ttm.bdev.pool, ttm, ctx);
}
@@ -1274,14 +1272,12 @@ nouveau_ttm_tt_unpopulate(struct ttm_bo_device *bdev,
struct ttm_tt *ttm)
{
struct nouveau_drm *drm;
- struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
if (slave)
return;
drm = nouveau_bdev(bdev);
- dev = drm->dev->dev;
return ttm_pool_free(&drm->ttm.bdev.pool, ttm);
}
--
2.7.4
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v1] drm/nouveau: delete unused variables "dev" in nouveau_ttm_tt_populate()
@ 2021-02-25 8:08 ` Luo Jiaxing
0 siblings, 0 replies; 3+ messages in thread
From: Luo Jiaxing @ 2021-02-25 8:08 UTC (permalink / raw)
To: nouveau, dri-devel, bskeggs; +Cc: luojiaxing, linux-kernel, linuxarm
After switch to new allocator, dev is no longer used here and should be
deleted.
Fixes: 461619f5c324 ("drm/nouveau: switch to new allocator")
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 2375711..0b94f8a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1251,7 +1251,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev,
{
struct ttm_tt *ttm_dma = (void *)ttm;
struct nouveau_drm *drm;
- struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
if (ttm_tt_is_populated(ttm))
@@ -1264,7 +1263,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev,
}
drm = nouveau_bdev(bdev);
- dev = drm->dev->dev;
return ttm_pool_alloc(&drm->ttm.bdev.pool, ttm, ctx);
}
@@ -1274,14 +1272,12 @@ nouveau_ttm_tt_unpopulate(struct ttm_bo_device *bdev,
struct ttm_tt *ttm)
{
struct nouveau_drm *drm;
- struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
if (slave)
return;
drm = nouveau_bdev(bdev);
- dev = drm->dev->dev;
return ttm_pool_free(&drm->ttm.bdev.pool, ttm);
}
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-25 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 8:08 [PATCH v1] drm/nouveau: delete unused variables "dev" in nouveau_ttm_tt_populate() Luo Jiaxing
2021-02-25 8:08 ` Luo Jiaxing
2021-02-25 8:08 ` [Nouveau] " Luo Jiaxing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.