From: Kees Cook <keescook@chromium.org>
To: Gabriel Somlo <somlo@cmu.edu>,
Nathan Chancellor <nathan@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
qemu-devel@nongnu.org, clang-built-linux@googlegroups.com,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute
Date: Thu, 25 Feb 2021 13:25:04 -0800 [thread overview]
Message-ID: <161428829728.2305454.15456455443457551559.b4-ty@chromium.org> (raw)
In-Reply-To: <20210211194258.4137998-1-nathan@kernel.org>
On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote:
> fw_cfg_showrev() is called by an indirect call in kobj_attr_show(),
> which violates clang's CFI checking because fw_cfg_showrev()'s second
> parameter is 'struct attribute', whereas the ->show() member of 'struct
> kobj_structure' expects the second parameter to be of type 'struct
> kobj_attribute'.
>
> $ cat /sys/firmware/qemu_fw_cfg/rev
> 3
>
> [...]
Applied to kspp/cfi/cleanups, thanks!
[1/1] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute
https://git.kernel.org/kees/c/f5c4679d6c49
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Gabriel Somlo <somlo@cmu.edu>,
Nathan Chancellor <nathan@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute
Date: Thu, 25 Feb 2021 13:25:04 -0800 [thread overview]
Message-ID: <161428829728.2305454.15456455443457551559.b4-ty@chromium.org> (raw)
In-Reply-To: <20210211194258.4137998-1-nathan@kernel.org>
On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote:
> fw_cfg_showrev() is called by an indirect call in kobj_attr_show(),
> which violates clang's CFI checking because fw_cfg_showrev()'s second
> parameter is 'struct attribute', whereas the ->show() member of 'struct
> kobj_structure' expects the second parameter to be of type 'struct
> kobj_attribute'.
>
> $ cat /sys/firmware/qemu_fw_cfg/rev
> 3
>
> [...]
Applied to kspp/cfi/cleanups, thanks!
[1/1] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute
https://git.kernel.org/kees/c/f5c4679d6c49
--
Kees Cook
next prev parent reply other threads:[~2021-02-25 21:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 19:42 [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute Nathan Chancellor
2021-02-11 19:42 ` Nathan Chancellor
2021-02-11 20:41 ` Sami Tolvanen
2021-02-11 20:41 ` Sami Tolvanen
2021-02-24 18:08 ` Sedat Dilek
2021-02-24 18:08 ` Sedat Dilek
2021-02-22 19:02 ` Nick Desaulniers
2021-02-22 19:02 ` Nick Desaulniers
2021-02-22 19:08 ` Nathan Chancellor
2021-02-22 19:08 ` Nathan Chancellor
2021-02-25 4:57 ` Kees Cook
2021-02-25 4:57 ` Kees Cook
2021-02-25 10:41 ` Philippe Mathieu-Daudé
2021-02-25 10:41 ` Philippe Mathieu-Daudé
2021-02-25 21:25 ` Kees Cook [this message]
2021-02-25 21:25 ` Kees Cook
2021-04-02 6:42 ` Sedat Dilek
2021-04-02 6:42 ` Sedat Dilek
2021-04-02 18:25 ` Kees Cook
2021-04-02 18:25 ` Kees Cook
2021-04-02 18:31 ` Nathan Chancellor
2021-04-02 18:31 ` Nathan Chancellor
2021-04-02 18:44 ` Sedat Dilek
2021-04-02 18:44 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161428829728.2305454.15456455443457551559.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=qemu-devel@nongnu.org \
--cc=samitolvanen@google.com \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.