* [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers.
@ 2021-04-13 16:02 Mark Yacoub
2021-04-13 16:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Mark Yacoub @ 2021-04-13 16:02 UTC (permalink / raw)
To: igt-dev; +Cc: petri.latvala, bas, seanpaul, markyacoub, Mark Yacoub
From: Mark Yacoub <markyacoub@google.com>
Calculate the width and height of the tile on amdgpu when the modifier
is not linear.
Cc: bas@basnieuwenhuizen.nl
Cc: daniel.vetter@ffwll.ch
Signed-off-by: markyacoub@chromium.org
---
lib/igt_fb.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4ded7e78..3d1fdae5 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -396,6 +396,19 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
vc4_modifier_param = fourcc_mod_broadcom_param(modifier);
modifier = fourcc_mod_broadcom_mod(modifier);
}
+ // For all non-linear modifiers, AMD uses 64 KiB tiles
+ else if (IS_AMD_FMT_MOD(modifier)) {
+ igt_require_amdgpu(fd);
+ const int bytes_per_pixel = fb_bpp / 8;
+ const int format_log2 = log2(bytes_per_pixel);
+ const int pixel_log2 = log2(64 * 1024) - format_log2;
+ const int width_log2 = (pixel_log2 + 1) / 2;
+ const int height_log2 = pixel_log2 - width_log2;
+
+ *width_ret = 1 << width_log2;
+ *height_ret = 1 << height_log2;
+ return;
+ }
switch (modifier) {
case LOCAL_DRM_FORMAT_MOD_NONE:
--
2.31.1.295.g9ea45b61b8-goog
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: Support Tile Size for AMD non linear modifiers.
2021-04-13 16:02 [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers Mark Yacoub
@ 2021-04-13 16:43 ` Patchwork
2021-04-13 17:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-06-07 16:13 ` [igt-dev] [PATCH] " Mark Yacoub
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-04-13 16:43 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 2397 bytes --]
== Series Details ==
Series: lib/igt_fb: Support Tile Size for AMD non linear modifiers.
URL : https://patchwork.freedesktop.org/series/89017/
State : success
== Summary ==
CI Bug Log - changes from IGT_6064 -> IGTPW_5738
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/index.html
Known issues
------------
Here are the changes found in IGTPW_5738 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-icl-y: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/fi-icl-y/igt@amdgpu/amd_basic@semaphore.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-icl-y: [INCOMPLETE][2] ([i915#2782]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/fi-icl-y/igt@i915_selftest@live@hangcheck.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/fi-icl-y/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [FAIL][4] ([i915#579]) -> [SKIP][5] ([fdo#109271])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (47 -> 41)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6064 -> IGTPW_5738
CI-20190529: 20190529
CI_DRM_9963: f71c7917b4b6d6c093f1e65e62acd3360d96e63a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5738: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/index.html
IGT_6064: 48d89e2c65c54883b0776930a884e6d3bcefb45b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/index.html
[-- Attachment #1.2: Type: text/html, Size: 3028 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_fb: Support Tile Size for AMD non linear modifiers.
2021-04-13 16:02 [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers Mark Yacoub
2021-04-13 16:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-04-13 17:41 ` Patchwork
2021-06-07 16:13 ` [igt-dev] [PATCH] " Mark Yacoub
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-04-13 17:41 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 30256 bytes --]
== Series Details ==
Series: lib/igt_fb: Support Tile Size for AMD non linear modifiers.
URL : https://patchwork.freedesktop.org/series/89017/
State : success
== Summary ==
CI Bug Log - changes from IGT_6064_full -> IGTPW_5738_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/index.html
Known issues
------------
Here are the changes found in IGTPW_5738_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-snb: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb5/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@idempotent:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb7/igt@gem_ctx_persistence@idempotent.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][3] -> [FAIL][4] ([i915#2842]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-glk1/igt@gem_exec_fair@basic-pace@vecs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk9/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_params@no-blt:
- shard-tglb: NOTRUN -> [SKIP][7] ([fdo#109283])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb3/igt@gem_exec_params@no-blt.html
- shard-iclb: NOTRUN -> [SKIP][8] ([fdo#109283])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb2/igt@gem_exec_params@no-blt.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][9] ([i915#2389]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl7/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][10] ([i915#2389]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#307])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-glk2/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk6/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][13] ([i915#2658])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb7/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@linear-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][14] ([i915#768])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb8/igt@gem_render_copy@linear-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][15] ([i915#2724])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb5/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@batch-zero-length:
- shard-iclb: NOTRUN -> [SKIP][16] ([fdo#112306])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb5/igt@gen9_exec_parse@batch-zero-length.html
- shard-tglb: NOTRUN -> [SKIP][17] ([fdo#112306])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb7/igt@gen9_exec_parse@batch-zero-length.html
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][18] ([i915#454])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl7/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: NOTRUN -> [DMESG-WARN][19] ([i915#180]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl1/igt@i915_suspend@debugfs-reader.html
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][20] -> [DMESG-WARN][21] ([i915#180])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-apl7/igt@i915_suspend@forcewake.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl8/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271]) +231 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl8/igt@kms_big_fb@linear-16bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#111615]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb2/igt@kms_big_fb@yf-tiled-addfb.html
* igt@kms_big_joiner@invalid-modeset:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#2705])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl7/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-iclb: NOTRUN -> [SKIP][25] ([fdo#109284] / [fdo#111827]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb4/igt@kms_chamelium@dp-hpd-for-each-pipe.html
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk8/igt@kms_chamelium@dp-hpd-for-each-pipe.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +19 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl7/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +5 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl4/igt@kms_color_chamelium@pipe-c-ctm-0-25.html
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#109284] / [fdo#111827]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb3/igt@kms_color_chamelium@pipe-c-ctm-0-25.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +20 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb5/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#3116])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb8/igt@kms_content_protection@dp-mst-lic-type-1.html
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#3116])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb7/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_cursor_crc@pipe-a-cursor-32x32-offscreen:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#3319]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-32x32-offscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109278]) +6 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb1/igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement.html
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109274] / [fdo#109278]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb7/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-glk: [PASS][36] -> [FAIL][37] ([i915#52] / [i915#54]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-glk3/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][38] -> [INCOMPLETE][39] ([i915#155] / [i915#180] / [i915#636])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109274])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb6/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][41] ([i915#180]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][42] -> [DMESG-WARN][43] ([i915#180]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-kbl: NOTRUN -> [FAIL][44] ([i915#2641])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#2587])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
- shard-glk: NOTRUN -> [FAIL][46] ([i915#2628])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
- shard-apl: NOTRUN -> [FAIL][47] ([i915#2641])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][48] ([fdo#109271]) +387 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109280]) +7 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#111825]) +10 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt.html
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109289])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb2/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#109289])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb2/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#533]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#533])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-glk: NOTRUN -> [FAIL][56] ([fdo#108145] / [i915#265])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk9/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][58] ([i915#265])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
- shard-glk: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk9/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
- shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
- shard-iclb: NOTRUN -> [SKIP][62] ([i915#658])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][65] ([i915#31])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb5/igt@kms_setmode@basic.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2437])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl8/igt@kms_writeback@writeback-invalid-parameters.html
* igt@nouveau_crc@pipe-a-source-rg:
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#2530]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb5/igt@nouveau_crc@pipe-a-source-rg.html
- shard-tglb: NOTRUN -> [SKIP][68] ([i915#2530]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb6/igt@nouveau_crc@pipe-a-source-rg.html
* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +136 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@prime_nv_pcopy@test2.html
* igt@prime_nv_pcopy@test3_3:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109291])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb6/igt@prime_nv_pcopy@test3_3.html
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271]) +22 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk8/igt@prime_nv_pcopy@test3_3.html
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109291])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb2/igt@prime_nv_pcopy@test3_3.html
* igt@runner@aborted:
- shard-snb: NOTRUN -> [FAIL][73] ([i915#3002] / [i915#698])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-snb5/igt@runner@aborted.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#2994]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl6/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2994])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl2/igt@sysfs_clients@fair-3.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][76] ([i915#658]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb1/igt@feature_discovery@psr2.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][78] ([i915#2846]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-kbl: [FAIL][80] ([i915#2842]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][82] ([i915#2842]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][84] ([i915#2842]) -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-glk: [DMESG-WARN][86] ([i915#118] / [i915#95]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-glk4/igt@gem_exec_whisper@basic-queues-forked-all.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk7/igt@gem_exec_whisper@basic-queues-forked-all.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][88] ([i915#454]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb1/igt@i915_pm_dc@dc6-psr.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][90] ([i915#2574]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
* igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
- shard-glk: [FAIL][92] ([i915#52] / [i915#54]) -> [PASS][93] +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-glk3/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-glk8/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][94] ([i915#180]) -> [PASS][95] +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-apl8/igt@kms_flip@flip-vs-suspend@a-dp1.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][96] ([i915#180]) -> [PASS][97] +4 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][98] ([fdo#109441]) -> [PASS][99] +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb5/igt@kms_psr@psr2_sprite_render.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][100] ([i915#180] / [i915#295]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][102] ([i915#2842]) -> [FAIL][103] ([i915#2849])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [FAIL][104] ([i915#307]) -> [FAIL][105] ([i915#2428])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][106] ([i915#2684]) -> [WARN][107] ([i915#1804] / [i915#2684])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][108] ([i915#1226]) -> [SKIP][109] ([fdo#109349])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][110] ([i915#658]) -> [SKIP][111] ([i915#2920]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb8/igt@kms_psr2_sf@cursor-plane-update-sf.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][112] ([i915#2920]) -> [SKIP][113] ([i915#658]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#602]) -> ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129]) ([i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#92])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl1/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl7/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl6/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl1/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl1/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl1/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl7/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl3/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6064/shard-kbl6/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl6/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl2/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl6/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl1/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/shard-kbl6/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2574]: https://gitlab.freedesktop.org/drm/intel/issues/2574
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2628]: https://gitlab.freedesktop.org/drm/intel/issues/2628
[i915#2641]: https://gitlab.freedesktop.org/drm/intel/issues/2641
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#698]: https://gitlab.freedesktop.org/drm/intel/issues/698
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6064 -> IGTPW_5738
CI-20190529: 20190529
CI_DRM_9963: f71c7917b4b6d6c093f1e65e62acd3360d96e63a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5738: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/index.html
IGT_6064: 48d89e2c65c54883b0776930a884e6d3bcefb45b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5738/index.html
[-- Attachment #1.2: Type: text/html, Size: 38154 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers.
2021-04-13 16:02 [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers Mark Yacoub
2021-04-13 16:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-04-13 17:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2021-06-07 16:13 ` Mark Yacoub
2021-06-17 23:45 ` Bas Nieuwenhuizen
2 siblings, 1 reply; 7+ messages in thread
From: Mark Yacoub @ 2021-06-07 16:13 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala, Sean Paul, Bas Nieuwenhuizen, Mark Yacoub
friendly ping.
On Tue, Apr 13, 2021 at 12:02 PM Mark Yacoub <markyacoub@chromium.org> wrote:
>
> From: Mark Yacoub <markyacoub@google.com>
>
> Calculate the width and height of the tile on amdgpu when the modifier
> is not linear.
>
> Cc: bas@basnieuwenhuizen.nl
> Cc: daniel.vetter@ffwll.ch
> Signed-off-by: markyacoub@chromium.org
> ---
> lib/igt_fb.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 4ded7e78..3d1fdae5 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -396,6 +396,19 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
> vc4_modifier_param = fourcc_mod_broadcom_param(modifier);
> modifier = fourcc_mod_broadcom_mod(modifier);
> }
> + // For all non-linear modifiers, AMD uses 64 KiB tiles
> + else if (IS_AMD_FMT_MOD(modifier)) {
> + igt_require_amdgpu(fd);
> + const int bytes_per_pixel = fb_bpp / 8;
> + const int format_log2 = log2(bytes_per_pixel);
> + const int pixel_log2 = log2(64 * 1024) - format_log2;
> + const int width_log2 = (pixel_log2 + 1) / 2;
> + const int height_log2 = pixel_log2 - width_log2;
> +
> + *width_ret = 1 << width_log2;
> + *height_ret = 1 << height_log2;
> + return;
> + }
>
> switch (modifier) {
> case LOCAL_DRM_FORMAT_MOD_NONE:
> --
> 2.31.1.295.g9ea45b61b8-goog
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers.
2021-06-07 16:13 ` [igt-dev] [PATCH] " Mark Yacoub
@ 2021-06-17 23:45 ` Bas Nieuwenhuizen
2021-06-18 10:40 ` Bas Nieuwenhuizen
0 siblings, 1 reply; 7+ messages in thread
From: Bas Nieuwenhuizen @ 2021-06-17 23:45 UTC (permalink / raw)
To: Mark Yacoub
Cc: Petri Latvala, Development mailing list for IGT GPU Tools,
Sean Paul, Mark Yacoub
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
though I'm not sure how useful it is without also appropriately
catching the stride weirdness wrt amdgpu.
On Mon, Jun 7, 2021 at 6:13 PM Mark Yacoub <markyacoub@chromium.org> wrote:
>
> friendly ping.
>
> On Tue, Apr 13, 2021 at 12:02 PM Mark Yacoub <markyacoub@chromium.org> wrote:
> >
> > From: Mark Yacoub <markyacoub@google.com>
> >
> > Calculate the width and height of the tile on amdgpu when the modifier
> > is not linear.
> >
> > Cc: bas@basnieuwenhuizen.nl
> > Cc: daniel.vetter@ffwll.ch
> > Signed-off-by: markyacoub@chromium.org
> > ---
> > lib/igt_fb.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index 4ded7e78..3d1fdae5 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -396,6 +396,19 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
> > vc4_modifier_param = fourcc_mod_broadcom_param(modifier);
> > modifier = fourcc_mod_broadcom_mod(modifier);
> > }
> > + // For all non-linear modifiers, AMD uses 64 KiB tiles
> > + else if (IS_AMD_FMT_MOD(modifier)) {
> > + igt_require_amdgpu(fd);
> > + const int bytes_per_pixel = fb_bpp / 8;
> > + const int format_log2 = log2(bytes_per_pixel);
> > + const int pixel_log2 = log2(64 * 1024) - format_log2;
> > + const int width_log2 = (pixel_log2 + 1) / 2;
> > + const int height_log2 = pixel_log2 - width_log2;
> > +
> > + *width_ret = 1 << width_log2;
> > + *height_ret = 1 << height_log2;
> > + return;
> > + }
> >
> > switch (modifier) {
> > case LOCAL_DRM_FORMAT_MOD_NONE:
> > --
> > 2.31.1.295.g9ea45b61b8-goog
> >
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers.
2021-06-17 23:45 ` Bas Nieuwenhuizen
@ 2021-06-18 10:40 ` Bas Nieuwenhuizen
2021-06-21 15:43 ` Mark Yacoub
0 siblings, 1 reply; 7+ messages in thread
From: Bas Nieuwenhuizen @ 2021-06-18 10:40 UTC (permalink / raw)
To: Mark Yacoub
Cc: Petri Latvala, Development mailing list for IGT GPU Tools,
Sean Paul, Mark Yacoub
On Fri, Jun 18, 2021 at 1:45 AM Bas Nieuwenhuizen
<bas@basnieuwenhuizen.nl> wrote:
>
> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
>
> though I'm not sure how useful it is without also appropriately
> catching the stride weirdness wrt amdgpu.
>
> On Mon, Jun 7, 2021 at 6:13 PM Mark Yacoub <markyacoub@chromium.org> wrote:
> >
> > friendly ping.
> >
> > On Tue, Apr 13, 2021 at 12:02 PM Mark Yacoub <markyacoub@chromium.org> wrote:
> > >
> > > From: Mark Yacoub <markyacoub@google.com>
> > >
> > > Calculate the width and height of the tile on amdgpu when the modifier
> > > is not linear.
> > >
> > > Cc: bas@basnieuwenhuizen.nl
> > > Cc: daniel.vetter@ffwll.ch
> > > Signed-off-by: markyacoub@chromium.org
> > > ---
> > > lib/igt_fb.c | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > > index 4ded7e78..3d1fdae5 100644
> > > --- a/lib/igt_fb.c
> > > +++ b/lib/igt_fb.c
> > > @@ -396,6 +396,19 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
> > > vc4_modifier_param = fourcc_mod_broadcom_param(modifier);
> > > modifier = fourcc_mod_broadcom_mod(modifier);
> > > }
> > > + // For all non-linear modifiers, AMD uses 64 KiB tiles
> > > + else if (IS_AMD_FMT_MOD(modifier)) {
> > > + igt_require_amdgpu(fd);
> > > + const int bytes_per_pixel = fb_bpp / 8;
> > > + const int format_log2 = log2(bytes_per_pixel);
> > > + const int pixel_log2 = log2(64 * 1024) - format_log2;
> > > + const int width_log2 = (pixel_log2 + 1) / 2;
> > > + const int height_log2 = pixel_log2 - width_log2;
> > > +
> > > + *width_ret = 1 << width_log2;
Actually looking at the documentation of this function width_ret
should be the width in bytes, not pixels, so we should probably use
"bytes_per_pixel << width_log2".
> > > + *height_ret = 1 << height_log2;
> > > + return;
> > > + }
> > >
> > > switch (modifier) {
> > > case LOCAL_DRM_FORMAT_MOD_NONE:
> > > --
> > > 2.31.1.295.g9ea45b61b8-goog
> > >
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers.
2021-06-18 10:40 ` Bas Nieuwenhuizen
@ 2021-06-21 15:43 ` Mark Yacoub
0 siblings, 0 replies; 7+ messages in thread
From: Mark Yacoub @ 2021-06-21 15:43 UTC (permalink / raw)
To: Bas Nieuwenhuizen
Cc: Petri Latvala, Development mailing list for IGT GPU Tools,
Sean Paul, Mark Yacoub
On Fri, Jun 18, 2021 at 6:40 AM Bas Nieuwenhuizen
<bas@basnieuwenhuizen.nl> wrote:
>
> On Fri, Jun 18, 2021 at 1:45 AM Bas Nieuwenhuizen
> <bas@basnieuwenhuizen.nl> wrote:
> >
> > Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
> >
> > though I'm not sure how useful it is without also appropriately
> > catching the stride weirdness wrt amdgpu.
> >
> > On Mon, Jun 7, 2021 at 6:13 PM Mark Yacoub <markyacoub@chromium.org> wrote:
> > >
> > > friendly ping.
> > >
> > > On Tue, Apr 13, 2021 at 12:02 PM Mark Yacoub <markyacoub@chromium.org> wrote:
> > > >
> > > > From: Mark Yacoub <markyacoub@google.com>
> > > >
> > > > Calculate the width and height of the tile on amdgpu when the modifier
> > > > is not linear.
> > > >
> > > > Cc: bas@basnieuwenhuizen.nl
> > > > Cc: daniel.vetter@ffwll.ch
> > > > Signed-off-by: markyacoub@chromium.org
> > > > ---
> > > > lib/igt_fb.c | 13 +++++++++++++
> > > > 1 file changed, 13 insertions(+)
> > > >
> > > > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > > > index 4ded7e78..3d1fdae5 100644
> > > > --- a/lib/igt_fb.c
> > > > +++ b/lib/igt_fb.c
> > > > @@ -396,6 +396,19 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
> > > > vc4_modifier_param = fourcc_mod_broadcom_param(modifier);
> > > > modifier = fourcc_mod_broadcom_mod(modifier);
> > > > }
> > > > + // For all non-linear modifiers, AMD uses 64 KiB tiles
> > > > + else if (IS_AMD_FMT_MOD(modifier)) {
> > > > + igt_require_amdgpu(fd);
> > > > + const int bytes_per_pixel = fb_bpp / 8;
> > > > + const int format_log2 = log2(bytes_per_pixel);
> > > > + const int pixel_log2 = log2(64 * 1024) - format_log2;
> > > > + const int width_log2 = (pixel_log2 + 1) / 2;
> > > > + const int height_log2 = pixel_log2 - width_log2;
> > > > +
> > > > + *width_ret = 1 << width_log2;
>
> Actually looking at the documentation of this function width_ret
> should be the width in bytes, not pixels, so we should probably use
> "bytes_per_pixel << width_log2".
>
Thanks! updated and sent v2: Thanks! updated it and sent v2:
https://patchwork.freedesktop.org/patch/440283/?series=89017&rev=2
> > > > + *height_ret = 1 << height_log2;
> > > > + return;
> > > > + }
> > > >
> > > > switch (modifier) {
> > > > case LOCAL_DRM_FORMAT_MOD_NONE:
> > > > --
> > > > 2.31.1.295.g9ea45b61b8-goog
> > > >
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-06-21 15:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 16:02 [igt-dev] [PATCH] lib/igt_fb: Support Tile Size for AMD non linear modifiers Mark Yacoub
2021-04-13 16:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-04-13 17:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-06-07 16:13 ` [igt-dev] [PATCH] " Mark Yacoub
2021-06-17 23:45 ` Bas Nieuwenhuizen
2021-06-18 10:40 ` Bas Nieuwenhuizen
2021-06-21 15:43 ` Mark Yacoub
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.