* [PATCH][next] net: axienet: Fix fall-through warning for Clang
@ 2021-05-28 19:58 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-28 19:58 UTC (permalink / raw)
To: Radhey Shyam Pandey, David S. Miller, Jakub Kicinski, Michal Simek
Cc: netdev, linux-arm-kernel, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding a fallthrough statement instead of just
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
JFYI: We had thousands of these sorts of warnings and now we are down
to just 25 in linux-next. This is one of those last remaining
warnings.
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index b508c9453f40..e29ad9a86a3c 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1543,6 +1543,7 @@ static void axienet_validate(struct phylink_config *config,
case PHY_INTERFACE_MODE_MII:
phylink_set(mask, 100baseT_Full);
phylink_set(mask, 10baseT_Full);
+ fallthrough;
default:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH][next] net: axienet: Fix fall-through warning for Clang
@ 2021-05-28 19:58 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-28 19:58 UTC (permalink / raw)
To: Radhey Shyam Pandey, David S. Miller, Jakub Kicinski, Michal Simek
Cc: netdev, linux-arm-kernel, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding a fallthrough statement instead of just
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
JFYI: We had thousands of these sorts of warnings and now we are down
to just 25 in linux-next. This is one of those last remaining
warnings.
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index b508c9453f40..e29ad9a86a3c 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1543,6 +1543,7 @@ static void axienet_validate(struct phylink_config *config,
case PHY_INTERFACE_MODE_MII:
phylink_set(mask, 100baseT_Full);
phylink_set(mask, 10baseT_Full);
+ fallthrough;
default:
break;
}
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] net: axienet: Fix fall-through warning for Clang
2021-05-28 19:58 ` Gustavo A. R. Silva
(?)
@ 2021-05-30 20:50 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-30 20:50 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: radhey.shyam.pandey, davem, kuba, michal.simek, netdev,
linux-arm-kernel, linux-kernel, linux-hardening
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 28 May 2021 14:58:31 -0500 you wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding a fallthrough statement instead of just
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> [...]
Here is the summary with links:
- [next] net: axienet: Fix fall-through warning for Clang
https://git.kernel.org/netdev/net-next/c/03a6ef31f2bc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] net: axienet: Fix fall-through warning for Clang
2021-05-28 19:58 ` Gustavo A. R. Silva
@ 2021-06-01 19:19 ` Kees Cook
-1 siblings, 0 replies; 5+ messages in thread
From: Kees Cook @ 2021-06-01 19:19 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Radhey Shyam Pandey, David S. Miller, Jakub Kicinski,
Michal Simek, netdev, linux-arm-kernel, linux-kernel,
linux-hardening
On Fri, May 28, 2021 at 02:58:31PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding a fallthrough statement instead of just
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] net: axienet: Fix fall-through warning for Clang
@ 2021-06-01 19:19 ` Kees Cook
0 siblings, 0 replies; 5+ messages in thread
From: Kees Cook @ 2021-06-01 19:19 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Radhey Shyam Pandey, David S. Miller, Jakub Kicinski,
Michal Simek, netdev, linux-arm-kernel, linux-kernel,
linux-hardening
On Fri, May 28, 2021 at 02:58:31PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding a fallthrough statement instead of just
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-01 19:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 19:58 [PATCH][next] net: axienet: Fix fall-through warning for Clang Gustavo A. R. Silva
2021-05-28 19:58 ` Gustavo A. R. Silva
2021-05-30 20:50 ` patchwork-bot+netdevbpf
2021-06-01 19:19 ` Kees Cook
2021-06-01 19:19 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.