* [PATCH] mpls: defer ttl decrement in mpls_forward()
@ 2021-07-22 18:50 Kangmin Park
2021-07-23 16:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Kangmin Park @ 2021-07-22 18:50 UTC (permalink / raw)
To: David S. Miller
Cc: Jakub Kicinski, Martin Varghese, Jiapeng Chong,
Gustavo A. R. Silva, Guillaume Nault, netdev, linux-kernel
Defer ttl decrement to optimize in tx_err case. There is no need
to decrease ttl in the case of goto tx_err.
Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
---
net/mpls/af_mpls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 05a21dd072df..ffeb2df8be7a 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -407,7 +407,6 @@ static int mpls_forward(struct sk_buff *skb, struct net_device *dev,
/* Verify ttl is valid */
if (dec.ttl <= 1)
goto err;
- dec.ttl -= 1;
/* Find the output device */
out_dev = rcu_dereference(nh->nh_dev);
@@ -431,6 +430,7 @@ static int mpls_forward(struct sk_buff *skb, struct net_device *dev,
skb->dev = out_dev;
skb->protocol = htons(ETH_P_MPLS_UC);
+ dec.ttl -= 1;
if (unlikely(!new_header_size && dec.bos)) {
/* Penultimate hop popping */
if (!mpls_egress(dev_net(out_dev), rt, skb, dec))
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mpls: defer ttl decrement in mpls_forward()
2021-07-22 18:50 [PATCH] mpls: defer ttl decrement in mpls_forward() Kangmin Park
@ 2021-07-23 16:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-23 16:20 UTC (permalink / raw)
To: Kangmin Park
Cc: davem, kuba, martin.varghese, jiapeng.chong, gustavoars, gnault,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 23 Jul 2021 03:50:28 +0900 you wrote:
> Defer ttl decrement to optimize in tx_err case. There is no need
> to decrease ttl in the case of goto tx_err.
>
> Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
> ---
> net/mpls/af_mpls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- mpls: defer ttl decrement in mpls_forward()
https://git.kernel.org/netdev/net-next/c/6a6b83ca471c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-23 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 18:50 [PATCH] mpls: defer ttl decrement in mpls_forward() Kangmin Park
2021-07-23 16:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.