From: Stephen Boyd <sboyd@kernel.org> To: Michael Turquette <mturquette@baylibre.com>, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Rob Herring <robh+dt@kernel.org> Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: Add DT bindings for PLL of Toshiba Visconti TMPV770x SoC Date: Sat, 28 Aug 2021 22:09:54 -0700 [thread overview] Message-ID: <163021379431.2676726.15668763072935534900@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <20210804092244.390376-2-nobuhiro1.iwamatsu@toshiba.co.jp> Quoting Nobuhiro Iwamatsu (2021-08-04 02:22:41) > Add device tree bindings for PLL of Toshiba Visconti TMPV770x SoC series. > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > --- > .../clock/toshiba,tmpv770x-pipllct.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml > > diff --git a/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml > new file mode 100644 > index 000000000000..7b7300ce96d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/toshiba,tmpv770x-pipllct.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 TMPV770X PLL Controller Device Tree Bindings > + > +maintainers: > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > + > +description: > + Toshia Visconti5 PLL controller which supports the PLLs on TMPV770X. > + > +properties: > + compatible: > + const: toshiba,tmpv7708-pipllct > + > + reg: > + maxItems: 1 > + > + '#clock-cells': > + const: 1 > + > + clocks: > + description: External reference clock (OSC2) > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + > + osc2_clk: osc2-clk { > + compatible = "fixed-clock"; > + clock-frequency = <20000000>; > + #clock-cells = <0>; > + }; > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pipllct: clock-controller@24220000 { > + compatible = "toshiba,tmpv7708-pipllct"; The driver makes it look like this is actually part of a syscon node. Is that right? It's not clear to me that this is a syscon. But then looking at the binding it seems that one device has been split up into PLL and "not PLL" parts sort of arbitrarily. > + reg = <0 0x24220000 0 0x820>; > + #clock-cells = <1>; > + clocks = <&osc2_clk>; > + }; > + }; > +...
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Michael Turquette <mturquette@baylibre.com>, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Rob Herring <robh+dt@kernel.org> Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: Add DT bindings for PLL of Toshiba Visconti TMPV770x SoC Date: Sat, 28 Aug 2021 22:09:54 -0700 [thread overview] Message-ID: <163021379431.2676726.15668763072935534900@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <20210804092244.390376-2-nobuhiro1.iwamatsu@toshiba.co.jp> Quoting Nobuhiro Iwamatsu (2021-08-04 02:22:41) > Add device tree bindings for PLL of Toshiba Visconti TMPV770x SoC series. > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > --- > .../clock/toshiba,tmpv770x-pipllct.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml > > diff --git a/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml > new file mode 100644 > index 000000000000..7b7300ce96d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/toshiba,tmpv770x-pipllct.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 TMPV770X PLL Controller Device Tree Bindings > + > +maintainers: > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > + > +description: > + Toshia Visconti5 PLL controller which supports the PLLs on TMPV770X. > + > +properties: > + compatible: > + const: toshiba,tmpv7708-pipllct > + > + reg: > + maxItems: 1 > + > + '#clock-cells': > + const: 1 > + > + clocks: > + description: External reference clock (OSC2) > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + > + osc2_clk: osc2-clk { > + compatible = "fixed-clock"; > + clock-frequency = <20000000>; > + #clock-cells = <0>; > + }; > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pipllct: clock-controller@24220000 { > + compatible = "toshiba,tmpv7708-pipllct"; The driver makes it look like this is actually part of a syscon node. Is that right? It's not clear to me that this is a syscon. But then looking at the binding it seems that one device has been split up into PLL and "not PLL" parts sort of arbitrarily. > + reg = <0 0x24220000 0 0x820>; > + #clock-cells = <1>; > + clocks = <&osc2_clk>; > + }; > + }; > +... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-29 5:09 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-04 9:22 [PATCH v4 0/4] clk: visconti: Add support common clock driver and reset driver Nobuhiro Iwamatsu 2021-08-04 9:22 ` Nobuhiro Iwamatsu 2021-08-04 9:22 ` [PATCH v4 1/4] dt-bindings: clock: Add DT bindings for PLL of Toshiba Visconti TMPV770x SoC Nobuhiro Iwamatsu 2021-08-04 9:22 ` Nobuhiro Iwamatsu 2021-08-11 18:53 ` Rob Herring 2021-08-11 18:53 ` Rob Herring 2021-08-29 5:09 ` Stephen Boyd [this message] 2021-08-29 5:09 ` Stephen Boyd 2021-08-31 2:14 ` Nobuhiro Iwamatsu 2021-08-31 2:14 ` Nobuhiro Iwamatsu 2021-08-04 9:22 ` [PATCH v4 2/4] dt-bindings: clock: Add DT bindings for SMU " Nobuhiro Iwamatsu 2021-08-04 9:22 ` Nobuhiro Iwamatsu 2021-08-11 18:53 ` Rob Herring 2021-08-11 18:53 ` Rob Herring 2021-08-04 9:22 ` [PATCH v4 3/4] clk: visconti: Add support common clock driver and reset driver Nobuhiro Iwamatsu 2021-08-04 9:22 ` Nobuhiro Iwamatsu 2021-08-29 5:08 ` Stephen Boyd 2021-08-29 5:08 ` Stephen Boyd 2021-10-25 0:29 ` Nobuhiro Iwamatsu 2021-10-25 0:29 ` Nobuhiro Iwamatsu 2021-08-04 9:22 ` [PATCH v4 4/4] MAINTAINERS: Add entries for Toshiba Visconti PLL and clock controller Nobuhiro Iwamatsu 2021-08-04 9:22 ` Nobuhiro Iwamatsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=163021379431.2676726.15668763072935534900@swboyd.mtv.corp.google.com \ --to=sboyd@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=nobuhiro1.iwamatsu@toshiba.co.jp \ --cc=punit1.agrawal@toshiba.co.jp \ --cc=robh+dt@kernel.org \ --cc=yuji2.ishikawa@toshiba.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.