* [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection
@ 2021-09-19 17:24 M Chetan Kumar
2021-09-20 9:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 3+ messages in thread
From: M Chetan Kumar @ 2021-09-19 17:24 UTC (permalink / raw)
To: netdev
Cc: kuba, davem, johannes, ryazanov.s.a, loic.poulain,
krishna.c.sudi, m.chetan.kumar, linuxwwan
This patch series brings-in support for M.2 7560 Device firmware flashing &
coredump collection using devlink.
- Driver Registers with Devlink framework.
- Register devlink params callback for configuring device params
required in flashing or coredump flow.
- Implements devlink ops flash_update callback that programs modem
firmware.
- Creates region & snapshot required for device coredump log collection.
On early detection of device in boot rom stage. Driver registers with
Devlink framework and establish transport channel for PSI (Primary Signed
Image) injection. Once PSI is injected to device, the device execution
stage details are read to determine whether device is in flash or
exception mode. The collected information is reported to devlink user
space application & based on this informationi, application proceeds with
either modem firmware flashing or coredump collection.
Refer to iosm devlink documentation for details on Devlink Params, flash
update and coredump collection command usage.
Note: Patches are interdependent. Need to apply complete patch series for
compilation.
Changes since v1:
* Break down single patch into multiple patches.
* IOSM Driver devlink documentation.
* Fixes NULL parameter deference in ipc_devlink_flash_update() reported
by smatch static checker.
* Fixes memory leak in ipc_devlink_create_region().
* Use kmemdup instead of kzalloc and memcpy in ipc_flash_boot_psi().
* Fixes linux-net build error.
M Chetan Kumar (6):
net: wwan: iosm: devlink registration
net: wwan: iosm: fw flashing support
net: wwan: iosm: coredump collection support
net: wwan: iosm: transport layer support for fw flashing/cd
net: wwan: iosm: devlink fw flashing & cd collection documentation
net: wwan: iosm: fw flashing & cd collection infrastructure changes
Documentation/networking/devlink/index.rst | 1 +
Documentation/networking/devlink/iosm.rst | 182 +++++++
drivers/net/wwan/Kconfig | 1 +
drivers/net/wwan/iosm/Makefile | 5 +-
drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.c | 6 +-
drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.h | 1 +
drivers/net/wwan/iosm/iosm_ipc_coredump.c | 110 ++++
drivers/net/wwan/iosm/iosm_ipc_coredump.h | 75 +++
drivers/net/wwan/iosm/iosm_ipc_devlink.c | 363 +++++++++++++
drivers/net/wwan/iosm/iosm_ipc_devlink.h | 207 ++++++++
drivers/net/wwan/iosm/iosm_ipc_flash.c | 561 +++++++++++++++++++++
drivers/net/wwan/iosm/iosm_ipc_flash.h | 271 ++++++++++
drivers/net/wwan/iosm/iosm_ipc_imem.c | 103 +++-
drivers/net/wwan/iosm/iosm_ipc_imem.h | 18 +-
drivers/net/wwan/iosm/iosm_ipc_imem_ops.c | 317 ++++++++++++
drivers/net/wwan/iosm/iosm_ipc_imem_ops.h | 49 +-
16 files changed, 2239 insertions(+), 31 deletions(-)
create mode 100644 Documentation/networking/devlink/iosm.rst
create mode 100644 drivers/net/wwan/iosm/iosm_ipc_coredump.c
create mode 100644 drivers/net/wwan/iosm/iosm_ipc_coredump.h
create mode 100644 drivers/net/wwan/iosm/iosm_ipc_devlink.c
create mode 100644 drivers/net/wwan/iosm/iosm_ipc_devlink.h
create mode 100644 drivers/net/wwan/iosm/iosm_ipc_flash.c
create mode 100644 drivers/net/wwan/iosm/iosm_ipc_flash.h
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection
2021-09-19 17:24 [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection M Chetan Kumar
@ 2021-09-20 9:10 ` patchwork-bot+netdevbpf
2021-09-20 20:28 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-20 9:10 UTC (permalink / raw)
To: M Chetan Kumar
Cc: netdev, kuba, davem, johannes, ryazanov.s.a, loic.poulain,
krishna.c.sudi, m.chetan.kumar, linuxwwan
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sun, 19 Sep 2021 22:54:24 +0530 you wrote:
> This patch series brings-in support for M.2 7560 Device firmware flashing &
> coredump collection using devlink.
> - Driver Registers with Devlink framework.
> - Register devlink params callback for configuring device params
> required in flashing or coredump flow.
> - Implements devlink ops flash_update callback that programs modem
> firmware.
> - Creates region & snapshot required for device coredump log collection.
>
> [...]
Here is the summary with links:
- [V2,net-next,1/6] net: wwan: iosm: devlink registration
https://git.kernel.org/netdev/net-next/c/4dcd183fbd67
- [V2,net-next,2/6] net: wwan: iosm: fw flashing support
https://git.kernel.org/netdev/net-next/c/b55734745568
- [V2,net-next,3/6] net: wwan: iosm: coredump collection support
https://git.kernel.org/netdev/net-next/c/09e7b002ff67
- [V2,net-next,4/6] net: wwan: iosm: transport layer support for fw flashing/cd
https://git.kernel.org/netdev/net-next/c/8d9be0634181
- [V2,net-next,5/6] net: wwan: iosm: devlink fw flashing & cd collection documentation
https://git.kernel.org/netdev/net-next/c/64302024bce5
- [V2,net-next,6/6] net: wwan: iosm: fw flashing & cd collection infrastructure changes
https://git.kernel.org/netdev/net-next/c/607d574aba6e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection
2021-09-20 9:10 ` patchwork-bot+netdevbpf
@ 2021-09-20 20:28 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-09-20 20:28 UTC (permalink / raw)
To: davem
Cc: M Chetan Kumar, netdev, johannes, ryazanov.s.a, loic.poulain,
krishna.c.sudi, m.chetan.kumar, linuxwwan
On Mon, 20 Sep 2021 09:10:11 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
> On Sun, 19 Sep 2021 22:54:24 +0530 you wrote:
> > This patch series brings-in support for M.2 7560 Device firmware flashing &
> > coredump collection using devlink.
> > - Driver Registers with Devlink framework.
> > - Register devlink params callback for configuring device params
> > required in flashing or coredump flow.
> > - Implements devlink ops flash_update callback that programs modem
> > firmware.
> > - Creates region & snapshot required for device coredump log collection.
> >
> > [...]
>
> Here is the summary with links:
> - [V2,net-next,1/6] net: wwan: iosm: devlink registration
> https://git.kernel.org/netdev/net-next/c/4dcd183fbd67
> - [V2,net-next,2/6] net: wwan: iosm: fw flashing support
> https://git.kernel.org/netdev/net-next/c/b55734745568
> - [V2,net-next,3/6] net: wwan: iosm: coredump collection support
> https://git.kernel.org/netdev/net-next/c/09e7b002ff67
> - [V2,net-next,4/6] net: wwan: iosm: transport layer support for fw flashing/cd
> https://git.kernel.org/netdev/net-next/c/8d9be0634181
> - [V2,net-next,5/6] net: wwan: iosm: devlink fw flashing & cd collection documentation
> https://git.kernel.org/netdev/net-next/c/64302024bce5
> - [V2,net-next,6/6] net: wwan: iosm: fw flashing & cd collection infrastructure changes
> https://git.kernel.org/netdev/net-next/c/607d574aba6e
>
> You are awesome, thank you!
I had to post a revert of v1 because it was merged too quickly,
and the same exact thing happens to v2. Maybe it's just me but
feels very disheartening.
The flashing API is really easy to extended all the devlink params
here should be part of the flashing API.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-20 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-19 17:24 [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection M Chetan Kumar
2021-09-20 9:10 ` patchwork-bot+netdevbpf
2021-09-20 20:28 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.